ToTiOS fails compile step |
|||
Issue descriptionNow that it gets past gclient runhooks ( issue 807994 ), it fails the compile step. From https://ci.chromium.org/buildbot/chromium.clang/ToTiOS/1250 FAILED: obj/ios/chrome/browser/drag_and_drop/drag_and_drop/drop_and_navigate_interaction.o ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/ios/chrome/browser/drag_and_drop/drag_and_drop/drop_and_navigate_interaction.o.d -DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_XCODE_VERSION=0920 -DCR_CLANG_REVISION=\"324463\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DNS_BLOCK_ASSERTIONS=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -I../.. -Igen -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/boringssl/src/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -fcolor-diagnostics -no-canonical-prefixes -arch armv7 -Wall -Werror -Wextra -Wthread-safety -Wunguarded-availability -Wundeclared-selector -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-tautological-unsigned-zero-compare -Wno-null-pointer-arithmetic -Wno-tautological-constant-compare -Wtautological-constant-out-of-range-compare -Oz -fno-omit-frame-pointer -gdwarf-2 -isysroot /b/c/xcode_ios_9c40b.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS11.2.sdk -stdlib=libc++ -miphoneos-version-min=10.0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -std=c++14 -fobjc-call-cxx-cdtors -Wobjc-missing-property-synthesis -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -fobjc-arc -c ../../ios/chrome/browser/drag_and_drop/drop_and_navigate_interaction.mm -o obj/ios/chrome/browser/drag_and_drop/drag_and_drop/drop_and_navigate_interaction.o GlobalValue with non default visibility must be dso_local! %struct._class_t* @"OBJC_CLASS_$_DropAndNavigateInteraction" GlobalValue with non default visibility must be dso_local! %struct._class_t* @"OBJC_METACLASS_$_DropAndNavigateInteraction" fatal error: error in backend: Broken module found, compilation aborted! clang++: error: clang frontend command failed with exit code 70 (use -v to see invocation) clang version 7.0.0 (trunk 324463) Target: arm-apple-darwin16.3.0 Thread model: posix InstalledDir: ../../third_party/llvm-build/Release+Asserts/bin clang++: note: diagnostic msg: PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace, preprocessed source, and associated run script. clang++: note: diagnostic msg: ********************
,
Feb 7 2018
creduce came up with this:
__attribute__((availability(ios, introduced = 11.0))) @interface a @end
@implementation a @end
$ clang -cc1 -triple thumbv7-apple-ios10.0.0 -emit-obj -fvisibility hidden -fvisibility-inlines-hidden -x objective-c++ a.ii
a.ii:1:66: warning: class 'a' defined without specifying a base class
__attribute__((availability(ios, introduced = 11.0))) @interface a @end
^
a.ii:1:67: note: add a super class to fix this problem
__attribute__((availability(ios, introduced = 11.0))) @interface a @end
^
GlobalValue with non default visibility must be dso_local!
%struct._class_t* @"OBJC_CLASS_$_a"
GlobalValue with non default visibility must be dso_local!
%struct._class_t* @"OBJC_METACLASS_$_a"
fatal error: error in backend: Broken module found, compilation aborted!
Bisecting now...
,
Feb 7 2018
Biesction points to: --- Author: rafael Date: Wed Jan 17 18:08:23 2018 New Revision: 322806 URL: http://llvm.org/viewvc/llvm-project?rev=322806&view=rev Log: Make GlobalValues with non-default visibilility dso_local. This is similar to r322317, but for visibility. It is not as neat because we have to special case extern_weak. The idea is the same as the previous change, make the transition to explicit dso_local easier for the frontends. With this they only have to add dso_local to symbols where we need some external information to decide if it is dso_local (like it being part of an ELF executable). ---
,
Feb 7 2018
There was a similar issue here: https://bugs.llvm.org/show_bug.cgi?id=36044
,
Feb 7 2018
Upstream bug for our issue: https://bugs.llvm.org/show_bug.cgi?id=36268
,
Feb 8 2018
upstream bug fixed in 324551 ; https://ci.chromium.org/buildbot/chromium.clang/ToTiOS/1254 should have that
,
Feb 8 2018
And it's green! |
|||
►
Sign in to add a comment |
|||
Comment 1 by h...@chromium.org
, Feb 7 20181.5 MB
1.5 MB Download
8.4 KB
8.4 KB View Download