New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 809913 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Localization doesn't appear for 'saved passwords for this site' text after saving password from bubble.

Reported by vku...@etouch.net, Feb 7 2018

Issue description

Chrome Version: 66.0.3342.0 (Official Build) Revision 7a08be580eb458170d11b34a8de66fe08db41bc5-refs/heads/master@{#534887}(32/64-bit) 
OS: Win(7,8,8.1,10)

What steps will reproduce the problem?
(1)Launch chrome navigate to chrome://settings/ > Languages  and select 'French' language from 'Add languages' list.
(2)Click on iron icon of french language and click on 'display google chrome...' > relaunch 
(3)Navigate to https://twitter.com/ login with valid credentials, click on save button from password bubble and observe the overlay.

Actual: Localization doesn't appear for 'saved passwords for this site' text after saving password from bubble.

Expected: Localization should be seen for 'saved passwords for this site' text after saving password from bubble.

This is a regression issue broken in 'M66' andbelow is the manual bisect info:
Good Build: 66.0.3336.0 (Revision:533410)
Bad Build:  66.0.3338.0 (Revision:534242)

Note: Issue not seen on Mac(10.12.6, 10.13.1,10.13.4) & Linux(14.04 LTS)

 
Actual_password.png
514 KB View Download
Expected_password.png
575 KB View Download

Comment 1 by vku...@etouch.net, Feb 7 2018

Labels: hasbisect-per-revision RegressedIn-66 FoundIn-66 Target-66
Owner: pbos@chromium.org
Status: Assigned (was: Unconfirmed)
CL:
https://chromium.googlesource.com/chromium/src/+log/66.0.3336.0..66.0.3338.0?pretty=fuller&n=10000
(Unable to narrow down the range using tool per revision bisect as all the chrome build crashes after launch)

Suspecting: r533865 or r533422 ?

@pbos: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Comment 2 by vku...@etouch.net, Feb 7 2018

Labels: -hasbisect-per-revision hasbisect
Components: -UI>Localization UI>Browser
Labels: Needs-TestConfirmation
Hi,

Thank you for reporting. This has something to do with a placeholder.
I'll be looping in the Engineering Team to assist.

Regards!

Comment 4 by pbos@chromium.org, Feb 9 2018

I'm assuming this just hasn't been translated in TC yet or hasn't propagated down to the client (we're not using hard-coded strings). I've a reminder to look again in a couple of days, but I think this should resolve itself.

Comment 5 by vku...@etouch.net, Feb 12 2018

Labels: -Needs-TestConfirmation
Update : 
Retested above issue on Windows(7,8,8.1,10) OS using latest Canary version #66.0.3345.0 and issue is still reproducible. Kindly review the attached screenshot.
Actual_Canary.png
293 KB View Download

Comment 6 by pbos@chromium.org, Feb 12 2018

Cc: abdulsyed@chromium.org
The string's visible in TC just not translated for most languages. I don't think there's any action to take here yet.

+abdulsyed@ has any string translation been done for M66 yet or will they happen automagically as expected?

Comment 7 by pbos@chromium.org, Feb 12 2018

Cc: gov...@chromium.org
Status: WontFix (was: Assigned)
After talking to govind@: This is expected, string translation should happen before branch point so this string should be translated within a few weeks. I'll mark this as obsolete as there's no action to take (WontFix is a misleading label name here).

Sign in to add a comment