New issue
Advanced search Search tips

Issue 809911 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug

Blocking:
issue 789561



Sign in to add a comment

The 'More actions' icon for export passwords appears misaligned in chrome://settings/passwords

Reported by vineetha...@etouch.net, Feb 7 2018

Issue description

Chrome Version: 66.0.3342.0 (Official Build) Revision 7a08be580eb458170d11b34a8de66fe08db41bc5-refs/heads/master@{#534887}(32/64 bit)
OS: Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.4) and Linux(14.04 LTS).

Pre-condition: Enabled 'Password export' flag from chrome://flags

What steps will reproduce the problem?
(1) Launch chrome, sign in to any website for e.g: www.gmail.com with valid credentials. 
(2) Click on 'Save' button of the Save Password overlay.
(3) Navigate to chrome://settings/passwords and observe the More actions icon for export passwords.

Actual: The More actions icon for export passwords appears misaligned.
Expected: The More actions icon for export passwords should not appear misaligned.

This is a non-regression issue, seen from M-64 build #64.0.3269.0.
  
NOTE: 
1. 'Password export' flag has been enabled by default from build #66.0.3336.0
2. Issue is also seen on M-64 Stable/Beta(build #64.0.3282.140), Dev(build #65.0.3325.51)

 
ActualVideo.mp4
304 KB View Download
Status: Untriaged (was: Unconfirmed)
As this being a Non-Regression issue, changing the status to Untriaged so that the issue would get addressed.

Thank You!
Cc: vabr@chromium.org
Owner: cfroussios@chromium.org
Status: Assigned (was: Untriaged)
Blocking: 789561
Attaching screenshot of fix
aligned.png
108 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46a3c9743e3ae5772b1763ef04c8e2bdbef39a5d

commit 46a3c9743e3ae5772b1763ef04c8e2bdbef39a5d
Author: Christos Froussios <cfroussios@chromium.org>
Date: Fri Feb 09 18:50:53 2018

[Password Manager] Align "more options" buttons in settings page

The "more options" buttons in the header and in the password list should
be be aligned.

Bug:  809911 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I618a88fdd8a8404ad1dd51d83e033e0a1d7e7d5a
Reviewed-on: https://chromium-review.googlesource.com/911028
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535765}
[modify] https://crrev.com/46a3c9743e3ae5772b1763ef04c8e2bdbef39a5d/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

Status: Fixed (was: Assigned)
Labels: TE-Verified-M66 TE-Verified-66.0.3345.0
Update : 
Retested above issue on Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.4) and Linux(14.04 LTS) OS using latest Canary #66.0.3345.0 and issue is fixed. Kindly review the attached screen-cast.
FixedVideo.mov
1.1 MB View Download
Cc: -vabr@chromium.org

Sign in to add a comment