New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 809903 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Feature



Sign in to add a comment

Add UMA stats for WebRTC log uploading

Project Member Reported by grunell@chromium.org, Feb 7 2018

Issue description

It would be great to see how many WebRTC log uploads that succeed, fail, and get cancelled.
 
Labels: -M-66 M-69
See also b/72100511.
Cc: ossu@chromium.org
Labels: -M-69 Target-72
Status: Started (was: Assigned)
Have CL that adds start, discard, upload started, upload successful, and upload failed. Since upload information is the most interesting, I don't think metrics around store is needed.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e94a2eb8bf2650cf976010a4f22a92f00f917d34

commit e94a2eb8bf2650cf976010a4f22a92f00f917d34
Author: Henrik Grunell <grunell@chromium.org>
Date: Wed Dec 05 09:21:53 2018

UMA stats for WebRTC text logging.

Adds stats for start, discard, upload started, upload succeeded, and upload failed.

Bug:  809903 
Change-Id: I330cff6f975ddfa93a189d3de131627cb7249155
Reviewed-on: https://chromium-review.googlesource.com/c/1354446
Reviewed-by: Tommi <tommi@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Oskar Sundbom <ossu@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613912}
[modify] https://crrev.com/e94a2eb8bf2650cf976010a4f22a92f00f917d34/chrome/browser/media/webrtc/webrtc_log_uploader.cc
[modify] https://crrev.com/e94a2eb8bf2650cf976010a4f22a92f00f917d34/chrome/browser/media/webrtc/webrtc_log_uploader.h
[modify] https://crrev.com/e94a2eb8bf2650cf976010a4f22a92f00f917d34/chrome/browser/media/webrtc/webrtc_logging_handler_host.cc
[modify] https://crrev.com/e94a2eb8bf2650cf976010a4f22a92f00f917d34/chrome/browser/media/webrtc/webrtc_logging_handler_host.h
[modify] https://crrev.com/e94a2eb8bf2650cf976010a4f22a92f00f917d34/chrome/browser/media/webrtc/webrtc_text_log_handler.cc
[modify] https://crrev.com/e94a2eb8bf2650cf976010a4f22a92f00f917d34/chrome/browser/media/webrtc/webrtc_text_log_handler.h
[modify] https://crrev.com/e94a2eb8bf2650cf976010a4f22a92f00f917d34/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/e94a2eb8bf2650cf976010a4f22a92f00f917d34/tools/metrics/histograms/histograms.xml

Cc: olka@chromium.org
Labels: Merge-Request-72
Status: Fixed (was: Started)
Project Member

Comment 7 by sheriffbot@chromium.org, Dec 6

Labels: -Merge-Request-72 Hotlist-Merge-Approved Merge-Approved-72
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 6

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b01859384eff502132605ccb3187d1427317d95

commit 3b01859384eff502132605ccb3187d1427317d95
Author: Henrik Grunell <grunell@chromium.org>
Date: Thu Dec 06 11:24:46 2018

UMA stats for WebRTC text logging.

Adds stats for start, discard, upload started, upload succeeded, and upload failed.

Bug:  809903 
Change-Id: I330cff6f975ddfa93a189d3de131627cb7249155
Reviewed-on: https://chromium-review.googlesource.com/c/1354446
Reviewed-by: Tommi <tommi@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Oskar Sundbom <ossu@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613912}(cherry picked from commit e94a2eb8bf2650cf976010a4f22a92f00f917d34)
Reviewed-on: https://chromium-review.googlesource.com/c/1365243
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#107}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/3b01859384eff502132605ccb3187d1427317d95/chrome/browser/media/webrtc/webrtc_log_uploader.cc
[modify] https://crrev.com/3b01859384eff502132605ccb3187d1427317d95/chrome/browser/media/webrtc/webrtc_log_uploader.h
[modify] https://crrev.com/3b01859384eff502132605ccb3187d1427317d95/chrome/browser/media/webrtc/webrtc_logging_handler_host.cc
[modify] https://crrev.com/3b01859384eff502132605ccb3187d1427317d95/chrome/browser/media/webrtc/webrtc_logging_handler_host.h
[modify] https://crrev.com/3b01859384eff502132605ccb3187d1427317d95/chrome/browser/media/webrtc/webrtc_text_log_handler.cc
[modify] https://crrev.com/3b01859384eff502132605ccb3187d1427317d95/chrome/browser/media/webrtc/webrtc_text_log_handler.h
[modify] https://crrev.com/3b01859384eff502132605ccb3187d1427317d95/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/3b01859384eff502132605ccb3187d1427317d95/tools/metrics/histograms/histograms.xml

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/3b01859384eff502132605ccb3187d1427317d95

Commit: 3b01859384eff502132605ccb3187d1427317d95
Author: grunell@chromium.org
Commiter: grunell@chromium.org
Date: 2018-12-06 11:24:46 +0000 UTC

UMA stats for WebRTC text logging.

Adds stats for start, discard, upload started, upload succeeded, and upload failed.

Bug:  809903 
Change-Id: I330cff6f975ddfa93a189d3de131627cb7249155
Reviewed-on: https://chromium-review.googlesource.com/c/1354446
Reviewed-by: Tommi <tommi@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Oskar Sundbom <ossu@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613912}(cherry picked from commit e94a2eb8bf2650cf976010a4f22a92f00f917d34)
Reviewed-on: https://chromium-review.googlesource.com/c/1365243
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#107}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment