New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 809902 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression:Bad password notification is seen missing in Connect to Network overlay when we enter wrong password

Project Member Reported by rkalavakuntla@chromium.org, Feb 7 2018

Issue description

Chrome Version:66.0.3341.0/10382.0.0 dev channel Peppy,Candy,Celes
OS:Chrome OS

What steps will reproduce the problem?
(1)Recover build>> In OOBE screen,go to Connect to Network overlay, give wrong password for some connection and Observe(please refer video)

Expected:Bad password notification should be seen
Actual:No Bad password notification is seen.Unable to know that password entered is wrong unless we again click on that connection name 

This is a Regression issue as same is working fine on 65.0.3293.0/10212.0.0 dev 

NOTE: Issue is not seen on Linux and Windows.

@alemate: Please confirm the behavior
 
Actual.mp4
16.7 MB Download
Expected notification.mp4
4.8 MB View Download
Labels: ReleaseBlock-Stable
Labels: -Pri-1 -ReleaseBlock-Stable Pri-2
Owner: steve...@chromium.org
This is tricky to get just right, I'll take a look.

The behavior of this has always been various flavors of imperfect so I am removing the RBS and reprioritizing this, but will plan to improve for 66.

Cc: est...@chromium.org
It looks like the notification should be getting triggered, but it is not getting displayed somehow.

Right now I do not see any system notifications from the login screen at all (e.g. ctrl-shift-+/- should generate 'Resolution changed'). That notification is working on 66.0.3344.0, so that appears to be a recent regression, I'll have to track that down first.

Cc: zalcorn@chromium.org
+Zach since this affects OOBE and the sign-in screen
Connecting to wifi is literally one of the very first steps in setting up your device, and a new user's first interaction with Chrome OS. If we aren't showing any system notifications on the login screen (including an error message for an incorrect password), we should probably fix that. It sounds like there are corner cases we can't get right 100% of the time, but let's at least address the most common cases especially since this is reproducible every time and is a regression. What do you think?
Labels: ReleaseBlock-Stable
Not showing any system notifications on the login screen / OOBE is RBS even if this particular notification isn't. Steven, feel free to break this bug up into separate parts if it helps track.
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a5003a497c23879f023b588483738146075a639

commit 1a5003a497c23879f023b588483738146075a639
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Feb 28 18:31:06 2018

Network config: Only set AutoConnect to false

Setting 'AutoConnect' to true during configuration causes Shill to
attempt to connect immediately after configuration which breaks
the notification logic. By default Shill will set AutoConenct to
true on the first successful connect if not explicitly set to false.

This also adds yet more / better logging.

Bug:  809902 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ibace61a761b7adf7b5c87e8db93d54d3b3942a48
Reviewed-on: https://chromium-review.googlesource.com/940338
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539896}
[modify] https://crrev.com/1a5003a497c23879f023b588483738146075a639/chrome/browser/ui/ash/network/network_state_notifier.cc
[modify] https://crrev.com/1a5003a497c23879f023b588483738146075a639/chromeos/network/network_connection_handler_impl.cc
[modify] https://crrev.com/1a5003a497c23879f023b588483738146075a639/ui/webui/resources/cr_components/chromeos/network/network_config.js

Labels: -M-66 Merge-Request-65 M-65
Status: Fixed (was: Assigned)
This also affects 65. The fix is small, safe, and isolated, and will greatly improve the OOBE experience when a badd password is entered. I would love to get this in for 65.

Project Member

Comment 9 by sheriffbot@chromium.org, Feb 28 2018

Labels: -Merge-Request-65 Merge-Review-65 Hotlist-Merge-Review
This bug requires manual review: We are only 5 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: bhthompson@chromium.org
Labels: -Hotlist-Merge-Review -Merge-Review-65 Merge-Approved-65
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 28 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8d2b51b91a73eabacd167f39dd55f743ab9e444

commit f8d2b51b91a73eabacd167f39dd55f743ab9e444
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Feb 28 21:15:06 2018

Network config: Only set AutoConnect to false

Setting 'AutoConnect' to true during configuration causes Shill to
attempt to connect immediately after configuration which breaks
the notification logic. By default Shill will set AutoConenct to
true on the first successful connect if not explicitly set to false.

This also adds yet more / better logging.

TBR=stevenjb@chromium.org

(cherry picked from commit 1a5003a497c23879f023b588483738146075a639)

Bug:  809902 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ibace61a761b7adf7b5c87e8db93d54d3b3942a48
Reviewed-on: https://chromium-review.googlesource.com/940338
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#539896}
Reviewed-on: https://chromium-review.googlesource.com/941505
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#628}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/f8d2b51b91a73eabacd167f39dd55f743ab9e444/chrome/browser/ui/ash/network/network_state_notifier.cc
[modify] https://crrev.com/f8d2b51b91a73eabacd167f39dd55f743ab9e444/chromeos/network/network_connection_handler_impl.cc
[modify] https://crrev.com/f8d2b51b91a73eabacd167f39dd55f743ab9e444/ui/webui/resources/cr_components/chromeos/network/network_config.js

Cc: conradlo@chromium.org

Comment 14 Deleted

Note: The fix in comment #7 and the merge in comment #12 actually apply to issue 819148, apologies for the confusion.

Sign in to add a comment