Issue metadata
Sign in to add a comment
|
Regression: Unwanted red square is seen after clicking on folder drop down button on bookmark bubble.
Reported by
pranjali...@etouch.net,
Feb 7 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version:66.0.3342.0 (Official Build) 7a08be580eb458170d11b34a8de66fe08db41bc5-refs/heads/master@{#534887}(64-bit) OS: Mac(10.12.6, 10.13.1, 10.13.4). Precondition: Enable ‘Force UI direction’ and ‘Enable RTL’ flags from chrome://flags Steps to reproduce: 1. Launch chrome and click on bookmark(i.e star) icon on omnibox. 2. Click on folder drop down and observe. Actual: Unwanted red square is seen after clicking on folder drop down button on bookmark bubble. Expected: Red square should not be seen after clicking on folder drop down button on bookmark bubble . This is Regression issue broken in 'M-66’ and Using the per-revision bisect providing the bisect results, Good Build:66.0.3340.0 (Revision : 534316) Bad Build:66.0.3341.0 (Revision : 534605) You are probably looking for a change made after 534572 (known good), but no later than 534573 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/4198089db7d1923cc83f6e24677131bb11bfefd7..9719e6fd16213f6ea9e99f81ef00a42b8af930b4 Suspect: https://chromium.googlesource.com/chromium/src/+/9719e6fd16213f6ea9e99f81ef00a42b8af930b4 @patricialor : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Note: Issue is not seen on Windows(7,8,8.1,10) and Linux(14.04 LTS) . Kindly refer attached screen cast for reference.
,
Feb 8 2018
Thanks for finding this! This seems pretty bad - I think this is probably not just broken in Comboboxes but everywhere that uses InkDropHostView::CreateDefaultInkDropImpl() (codesearch says there are 13 places that call this). I'm not sure what the right fix is - either we audit all the places that use InkDropHostView::CreateDefaultInkDropImpl(), check if they have this bug, and explicitly set the highlight mode to HIDE_ON_RIPPLE there, or maybe we need to expose InkDropImpl::show_highlight_on_hover_ to InkDropHostView and check that in addition to PlatformStyle::kUseRipples in InkDropHostView::CreateDefaultInkDropImpl(). CCing mohsen@ and ellyjones@ for ink drop expertise - do either of you have any better ideas?
,
Mar 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95253d13cf28bfeb52e453aeb33beebe1bc43a28 commit 95253d13cf28bfeb52e453aeb33beebe1bc43a28 Author: Patricia Lor <patricialor@chromium.org> Date: Mon Mar 12 07:00:57 2018 MacViews: Make sure highlights are unaffected by the ripple ban on Mac. r534573 fixed a bug where hover highlights would disappear when a normally-ripple-enabled button was long-pressed by always showing the highlight during the ripple animation (which is invisible on MacViews). However, this fix also caused non-highlight enabled bubbles to start showing the default highlight implementation, which looks like a transparent reddish square. Fix this by allowing ink drop clients to set their AutoHighlightMode according to the platform. Bug: 809896 , 795224 Change-Id: I4e1269900c38b75affb7606b6eab5f034cd609d4 Reviewed-on: https://chromium-review.googlesource.com/930522 Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#542433} [modify] https://crrev.com/95253d13cf28bfeb52e453aeb33beebe1bc43a28/chrome/browser/ui/views/hover_button.cc [modify] https://crrev.com/95253d13cf28bfeb52e453aeb33beebe1bc43a28/chrome/browser/ui/views/hover_button.h [modify] https://crrev.com/95253d13cf28bfeb52e453aeb33beebe1bc43a28/ui/views/animation/ink_drop_host_view.cc [modify] https://crrev.com/95253d13cf28bfeb52e453aeb33beebe1bc43a28/ui/views/animation/ink_drop_impl.cc [modify] https://crrev.com/95253d13cf28bfeb52e453aeb33beebe1bc43a28/ui/views/animation/ink_drop_impl.h [modify] https://crrev.com/95253d13cf28bfeb52e453aeb33beebe1bc43a28/ui/views/controls/button/button.cc
,
Mar 12 2018
,
Mar 14 2018
Update: Rechecked the above issue on Mac(10.12.6,10.13.1,10.13.4) OS with latest canary chrome version #67.0.3370.0 and issue is fixed. Kindly refer the attached screen cast for reference. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by pranjali...@etouch.net
, Feb 7 2018