New issue
Advanced search Search tips

Issue 809858 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 279386



Sign in to add a comment

HQP Sets Inline Autocompletion Incorrectly

Project Member Reported by mpear...@chromium.org, Feb 7 2018

Issue description


This isn't much (or any?) of an issue when HistoryURL provider exists.  That said:

Repro steps:
1. For an intranet web site that you've visited frequently (typed visits), say "cr".
2. Open chrome://omnibox
3. Check the boxes "show all details" and "show results per provider".
4. Type "cr" in the box on the page.  Hit "submit".
6. Observe in the "Results for individual providers" section for HistoryQuick, the line for http://cr/ has a fill_into_edit of "cr/" and an inline autocompletion of "/".  This is all reasonable.  (The omnibox adds trailing slashes to known intranet hostnames to make it clear these are URLs.)
7. Now revise the box to contain "cr/" and hit submit.

Expected results:
8.  In the "Results for individual providers" section for HistoryQuick, the line for http://cr/ has a fill_into_edit of "cr/" and an empty inline autocompletion.

Actual results:
8.  The line for http://cr/ has a fill_into_edit of "cr/" and an inline autocompletion of "/".  In other words, if this suggestion actually appeared in the omnibox, it would show "cr//", which the second slash being the selected inline autocompletion.

This is particularly problematic because if the user wants to delete and type something else, they cannot easily.  Press backspace will delete the "/" inline autocompletion, returning the input text to "cr/", which then immediately gets re-completed to "cr//".  It's impossible to backspace out of this state.
 
Blocking: 279386

Comment 2 by k...@chromium.org, Feb 26 2018

Owner: k...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83e643d0634ca4d49f93ffcf0c1529430d9f0dc6

commit 83e643d0634ca4d49f93ffcf0c1529430d9f0dc6
Author: Kevin Bailey <krb@chromium.org>
Date: Thu Mar 08 16:01:41 2018

[omnibox] Fix input offset after URL formatting

If the user enters a URL with a slash e.g. 'url/', the formatter,
having no context, will reduce it to 'url' and assume that the cursor
is before the slash '/'. This CL clears the bit requesting such ellision,
preserving the slash.

Bug:  809858 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I241fb58a6ff4223818884adf61f07e801e86e851
Reviewed-on: https://chromium-review.googlesource.com/934640
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541807}
[modify] https://crrev.com/83e643d0634ca4d49f93ffcf0c1529430d9f0dc6/chrome/browser/ui/toolbar/chrome_toolbar_model_delegate.cc
[modify] https://crrev.com/83e643d0634ca4d49f93ffcf0c1529430d9f0dc6/components/omnibox/browser/autocomplete_input.cc
[modify] https://crrev.com/83e643d0634ca4d49f93ffcf0c1529430d9f0dc6/components/omnibox/browser/autocomplete_input.h
[modify] https://crrev.com/83e643d0634ca4d49f93ffcf0c1529430d9f0dc6/components/omnibox/browser/history_quick_provider.cc
[modify] https://crrev.com/83e643d0634ca4d49f93ffcf0c1529430d9f0dc6/components/omnibox/browser/history_quick_provider.h
[modify] https://crrev.com/83e643d0634ca4d49f93ffcf0c1529430d9f0dc6/components/omnibox/browser/history_quick_provider_unittest.cc
[modify] https://crrev.com/83e643d0634ca4d49f93ffcf0c1529430d9f0dc6/components/omnibox/browser/history_url_provider.cc
[modify] https://crrev.com/83e643d0634ca4d49f93ffcf0c1529430d9f0dc6/components/omnibox/browser/physical_web_provider.cc
[modify] https://crrev.com/83e643d0634ca4d49f93ffcf0c1529430d9f0dc6/components/omnibox/browser/search_provider.cc
[modify] https://crrev.com/83e643d0634ca4d49f93ffcf0c1529430d9f0dc6/components/omnibox/browser/search_suggestion_parser.cc
[modify] https://crrev.com/83e643d0634ca4d49f93ffcf0c1529430d9f0dc6/components/omnibox/browser/titled_url_match_utils.cc
[modify] https://crrev.com/83e643d0634ca4d49f93ffcf0c1529430d9f0dc6/components/omnibox/browser/zero_suggest_provider.cc
[modify] https://crrev.com/83e643d0634ca4d49f93ffcf0c1529430d9f0dc6/ios/chrome/browser/ui/toolbar/toolbar_model_delegate_ios.mm

Comment 4 by k...@chromium.org, Mar 14 2018

Status: Fixed (was: Assigned)

Sign in to add a comment