New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 809837 link

Starred by 2 users
Status: Assigned
Owner:
dominickn@chromium.org
Cc:
█ mgiuca@chromium.org
dominickn@chromium.org
█ bgalbs@google.com
pcovell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Ensure web manifest scope is within service worker scope for installability check

Project Member Reported by dominickn@chromium.org, Feb 7 2018 
Recent changes to the web app manifest spec (https://www.w3.org/TR/appmanifest/#scope-member)

We want to ensure that the manifest's scope lies within the realm controlled by a service worker. Currently, we check that the start_url is within the scope of a service worker. We should:

1. update the manifest parser to use the start_url as the default scope if scope is not supplied by the developer
2. update the installbility check to ensure that the manifest scope is within the service worker scope, rather than the manifest URL being within the service worker scope.

Comment 1 by mgiuca@chromium.org, Feb 7 2018 

> 1. update the manifest parser to use the start_url as the default scope if scope is not supplied by the developer

I thought we already did this. But perhaps we do it at a later stage in the pipeline (e.g., in WebAPK server, and separately in Desktop implementation). So this first step would be a welcome refactor (exactly matching how it's defined in the spec), not a behavioural change, I'd imagine.

#2 sounds good.

Comment 2 by dominickn@chromium.org, Feb 7 2018 

#1: correct, we substitute in the start_url as the default scope in the Chrome layer, not in the manifest implementation. Currently the manifest parser sets scope as the empty URL if it isn't supplied (as per the spec prior to your very recent changes).

We could then remove the substitution at the higher layers (which I believe is duplicated across desktop and Android implementations, in C++ and and Java respectively).

The substitution is done prior to sending data to the WebAPK server so it shouldn't need any changes.
►

Sign in to add a comment