Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of calamity@google.com WizardControllerCellularFirstTest.CellularFirstFlow and 1 other(s) in browser_tests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1) Builders failed on: - Linux Chromium OS ASan LSan Tests (1): https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29 Almost certainly failing due to https://chromium-review.googlesource.com/c/chromium/src/+/898385 as the test was flagged as a failure and reverted once before. Merge conflict on revert: https://chromium-review.googlesource.com/c/chromium/src/+/905723 Assigning to author for investigation.
SoM filed a second bug for some reason..
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed44fc45d0c3b3675efec4c550d28c5de1569c9d commit ed44fc45d0c3b3675efec4c550d28c5de1569c9d Author: Yuri Wiitala <miu@chromium.org> Date: Sat Dec 15 03:14:24 2018 Complete the screen capture color space plumbing. Adds all remaining "plumbing" of color space information, throughout the CopyOutputRequest execution pipeline and the FrameSinkVideoCapturer pipeline. This ensures the color space being used to draw the original RenderPass within the compositor is being specified in the metadata for all result images. DevTools: Remove a hack from the color picker tool, now that the color space information for the screen capture frame is being provided. browser_tests/content_browsertests changes: Multilple browser tests were fixed as a result of this change revealing pre-existing bugs in the tests: the web page layout of the color regions, how pixels were being selected for analysis, and YUV→RGB color space conversion inaccuracies. Blink layout tests: Rebased a number of layout test expectations, as the the layout tests utilize the screen capture pipeline. I examined all of these changed expectations to confirm near 0% change: Meaning that just a tiny number of pixels in an image were imperceivably different because of adding the missing color space info. Bug: 758057, 8510131, 809835 , 863103, 884170, 795132 Change-Id: I11056ddc4f501ee338dc3283397703747a395571 Reviewed-on: https://chromium-review.googlesource.com/c/1372894 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Reviewed-by: Ria Jiang <riajiang@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#616936} [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/chrome/browser/devtools/devtools_eye_dropper.cc [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/chrome/test/data/extensions/api_test/tab_capture/offscreen_end_to_end.js [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/common/frame_sinks/copy_output_result.cc [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/common/frame_sinks/copy_output_result.h [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/display/gl_renderer_copier.cc [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/display/skia_output_surface.h [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/display/skia_renderer.cc [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/display/software_renderer.cc [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/display_embedder/skia_output_surface_impl.cc [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/display_embedder/skia_output_surface_impl.h [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.h [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/frame_sinks/video_capture/frame_sink_video_capturer_impl.cc [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/frame_sinks/video_capture/interprocess_frame_pool.cc [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/frame_sinks/video_capture/interprocess_frame_pool.h [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/frame_sinks/video_capture/video_capture_overlay.cc [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/frame_sinks/video_capture/video_capture_overlay.h [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/components/viz/service/frame_sinks/video_capture/video_capture_overlay_unittest.cc [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/content/browser/media/capture/aura_window_video_capture_device_browsertest.cc [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/content/browser/media/capture/content_capture_device_browsertest_base.cc [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/content/browser/media/capture/fake_video_capture_stack.cc [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/content/browser/media/capture/frame_test_util.cc [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/content/browser/media/capture/frame_test_util.h [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/content/browser/media/capture/lame_window_capturer_chromeos.cc [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/content/browser/media/capture/web_contents_video_capture_device_browsertest.cc [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/remoting/host/chromeos/aura_desktop_capturer_unittest.cc [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/editing/selection/4402375-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/editing/selection/replaced-boundaries-1-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/editing/selection/replaced-boundaries-2-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/editing/selection/replaced-boundaries-3-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/editing/selection/transformed-selection-rects-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/paint/invalidation/svg/text-selection-text-05-t-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/foreignObject-text-clipping-bug-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/selection-doubleclick-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/selection-tripleclick-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-align-02-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-align-03-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-align-04-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-align-06-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-intro-05-t-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-path-01-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-spacing-01-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-text-01-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-text-03-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-text-06-t-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-text-08-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/text-selection-ws-02-t-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/linux/svg/text/textPathBoundsBug-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac-mac10.10/editing/selection/replaced-boundaries-3-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac-mac10.11/editing/selection/replaced-boundaries-3-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/editing/selection/4402375-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/editing/selection/replaced-boundaries-1-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/editing/selection/replaced-boundaries-2-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/editing/selection/replaced-boundaries-3-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/editing/selection/transformed-selection-rects-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/paint/invalidation/svg/text-selection-text-05-t-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/foreignObject-text-clipping-bug-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/selection-doubleclick-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/selection-tripleclick-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-align-03-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-align-04-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-align-06-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-path-01-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-spacing-01-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-text-01-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-text-03-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-text-04-t-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-text-06-t-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-text-08-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-tselect-02-f-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-tspan-01-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-ws-01-t-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/text-selection-ws-02-t-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/mac/svg/text/textPathBoundsBug-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/editing/selection/4402375-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/editing/selection/replaced-boundaries-1-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/editing/selection/replaced-boundaries-2-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/editing/selection/replaced-boundaries-3-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/editing/selection/transformed-selection-rects-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/paint/invalidation/svg/text-selection-text-05-t-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/foreignObject-text-clipping-bug-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/selection-tripleclick-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-align-02-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-align-03-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-align-04-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-align-05-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-align-06-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-path-01-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-spacing-01-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-text-01-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-text-03-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-text-06-t-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-text-08-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-tselect-01-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-tselect-02-f-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-tspan-01-b-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-ws-01-t-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/text-selection-ws-02-t-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win/svg/text/textPathBoundsBug-expected.png [delete] https://crrev.com/4c40f61f89ae4d0a196c2c7b14b696bb7b5e0430/third_party/blink/web_tests/platform/win7/editing/selection/replaced-boundaries-1-expected.png [modify] https://crrev.com/ed44fc45d0c3b3675efec4c550d28c5de1569c9d/third_party/blink/web_tests/platform/win7/svg/text/text-selection-text-08-b-expected.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98a8f01a27f97ec27e6315fb006e61cd59192d29 commit 98a8f01a27f97ec27e6315fb006e61cd59192d29 Author: Morten Stenshorne <mstensho@chromium.org> Date: Mon Dec 17 11:41:19 2018 [LayoutNG] Rebaseline test expectations after color space changes. https://chromium-review.googlesource.com/c/chromium/src/+/1372894 made some invisible (to the naked eye) rebaselining to some test expectations, but not for LayoutNG. TBR=kojii@chromium.org Bug: 758057, 8510131, 809835 , 863103, 884170, 795132 Change-Id: Ie6b626c66c0930b1c8c00b7b01a0f01ddd06dada Reviewed-on: https://chromium-review.googlesource.com/c/1379953 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#617089} [modify] https://crrev.com/98a8f01a27f97ec27e6315fb006e61cd59192d29/third_party/blink/web_tests/FlagExpectations/enable-blink-features=LayoutNG [modify] https://crrev.com/98a8f01a27f97ec27e6315fb006e61cd59192d29/third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/editing/selection/4402375-expected.png [modify] https://crrev.com/98a8f01a27f97ec27e6315fb006e61cd59192d29/third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/editing/selection/transformed-selection-rects-expected.png [modify] https://crrev.com/98a8f01a27f97ec27e6315fb006e61cd59192d29/third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/svg/text/foreignObject-text-clipping-bug-expected.png
Comment 1 by calamity@chromium.org
, Feb 7 2018