Make chrome://view-http-cache use WebUI bindings |
||||||||||||
Issue descriptionContext https://bugs.chromium.org/p/chromium/issues/detail?id=776896 (see comment 12). CC'ing OWNERs.
,
Feb 7 2018
The context bug is access restricted.
,
Feb 7 2018
Thanks for the heads up. Working on getting the right permissions, will ping this thread soon, to try again.
,
Feb 7 2018
,
Feb 7 2018
,
Feb 7 2018
Eric, can you please take a look or help with an owner.
,
Feb 7 2018
Without access to the original bug, I don't think we can adequately approach this, or write regression tests.
,
Feb 7 2018
Added you mmenke@, please add others as needed.
,
Feb 7 2018
And, for the record "a proper WebUI page" is defined as one with WebUI bindings. Not sure if we have to use WebUI to deliver the response body - if so, that requires either modifying the WebUI interface itself, or completely reworking the cache pages to load data via scripts, since WebUI only manages static HTML/JS/CSS, I believe (They can load data via WebUI calls, but the HTML itself is static).
,
Feb 7 2018
Please add me to the context bug. (I would request that the cc list for this bug be pruned to people who have access to the context bug; otherwise you're spamming for no purpose.)
,
Feb 7 2018
Pruning...
,
Feb 7 2018
[+morlovich], [-everyone not on the other bug]
,
Feb 16 2018
,
Feb 21 2018
eroman: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers? If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one? If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 21 2018
,
Feb 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc commit 6ebc11f6f6d112e4cca5251d4c0203e18cd79adc Author: Eric Roman <eroman@chromium.org> Date: Wed Feb 21 19:32:24 2018 Remove chrome://view-http-cache. This was also aliased by chrome://cache. TBR=palmer@chromium.org,hubbe@chromium.org Bug: 811956 , 809823 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_mojo Change-Id: I2187a3956d913f8f110b0f7b5296e84beb2a82ac Reviewed-on: https://chromium-review.googlesource.com/917303 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#538186} [modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/chrome/browser/browser_about_handler.cc [modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/chrome/browser/browser_about_handler_unittest.cc [modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/chrome/browser/net/network_context_configuration_browsertest.cc [modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/chrome/browser/resources/net_internals/http_cache_view.html [modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/chrome/common/webui_url_constants.cc [modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/chrome/common/webui_url_constants.h [modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/content/browser/BUILD.gn [delete] https://crrev.com/421a0bb636d7fe67e4712a71c85c92c101c42268/content/browser/net/view_http_cache_job_factory.cc [delete] https://crrev.com/421a0bb636d7fe67e4712a71c85c92c101c42268/content/browser/net/view_http_cache_job_factory.h [modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/content/browser/webui/url_data_manager_backend.cc [delete] https://crrev.com/421a0bb636d7fe67e4712a71c85c92c101c42268/content/browser/webui/web_ui_browsertest.cc [modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/content/browser/webui/web_ui_url_loader_factory.cc [modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/content/public/common/url_constants.cc [modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/content/public/common/url_constants.h [modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/content/test/BUILD.gn [modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/media/cast/net/udp_socket_client_unittest.cc [modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/services/network/BUILD.gn [delete] https://crrev.com/421a0bb636d7fe67e4712a71c85c92c101c42268/services/network/cache_url_loader.cc [delete] https://crrev.com/421a0bb636d7fe67e4712a71c85c92c101c42268/services/network/cache_url_loader.h [modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/services/network/network_context.cc [modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/services/network/network_context.h [modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/services/network/public/mojom/network_service.mojom
,
Feb 21 2018
,
Feb 22 2018
,
Mar 6 2018
,
May 31 2018
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by dpa...@chromium.org
, Feb 7 2018