This is from the comment at the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/877512/9/content/public/browser/content_browser_client.cc When the above CL is landed, the ResourceDispatcherHostLoginDelegate is not only used for RDH, so it would be nice to rename it to LoginDelegate.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7502e51c35ca726b70bd63358575c8e7829efbc commit d7502e51c35ca726b70bd63358575c8e7829efbc Author: Jun Cai <juncai@chromium.org> Date: Fri Mar 02 23:49:07 2018 NetworkService: Rename ResourceDispatcherHostLoginDelegate to LoginDelegate This CL renames ResourceDispatcherHostLoginDelegate to LoginDelegate since it is not only used for ResourceDispatcherHost. Bug: 809819 , 783990 Change-Id: If07153ffa903c754f0ea5198745a560b266829ad Reviewed-on: https://chromium-review.googlesource.com/907319 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#540684} [modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/android_webview/browser/aw_content_browser_client.cc [modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/android_webview/browser/aw_content_browser_client.h [modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/android_webview/browser/aw_login_delegate.h [modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/chrome/browser/chrome_content_browser_client.h [modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc [modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/chrome/browser/ui/login/login_handler.h [modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/browser/loader/resource_dispatcher_host_impl.cc [modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/browser/loader/resource_dispatcher_host_impl.h [modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/browser/loader/resource_loader.cc [modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/browser/loader/resource_loader.h [modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/browser/loader/resource_loader_delegate.h [modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/browser/loader/resource_loader_unittest.cc [modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/browser/network_service_client.cc [modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/public/browser/BUILD.gn [modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/public/browser/content_browser_client.cc [modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/public/browser/content_browser_client.h [rename] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/public/browser/login_delegate.h [modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/shell/browser/layout_test/layout_test_content_browser_client.cc [modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/shell/browser/layout_test/layout_test_content_browser_client.h [modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/shell/browser/shell_content_browser_client.cc [modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/shell/browser/shell_content_browser_client.h [modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/shell/browser/shell_login_dialog.h
Comment 1 by juncai@chromium.org
, Feb 7 2018