New issue
Advanced search Search tips

Issue 809811 link

Starred by 1 user
Status: Fixed
Owner:
dgarr...@chromium.org
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

tryjobs should support "--chrome_version HEAD"

Project Member Reported by llozano@chromium.org, Feb 7 2018 
(Pasting from email discussion)

Whenever I modified the chromeos-chrome-9999.ebuild I used to do something like this to test:

cbuildbot --remote -g 831347 --chrome_rev=tot --hwtest falco-release


I had to use --chrome_ver=tot otherwise it would not uprev the 9999 version of the ebuild.

But with tryjob, I dont know how to do that:

Using the --chrome_version flag seems to want a chrome HASH. 

I tried the following:

cros tryjob -g 831347 --hwtest --chrome_version=tot falco-release-tryjob

I should have used "tot" instead of "latest", but I don't think that will work (trying now) because the error seems to indicate it is waiting for an actual HASH. 

see the error at: 

https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/release/builds/18413

on the other hand, if I just try to launch a tryjob without specifying chrome_rev=tot, I don't think chrome is upreved. See

https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/release/builds/18381

Comment 1 by llozano@chromium.org, Feb 7 2018 

I found a way to do this:

cros tryjob -g 831347 --hwtest --pass-through=--chrome_rev=tot falco-release-tryjob

dgarrett@ said:

"... I wonder if "--chrome_version HEAD" would have do what you want, I just launched a test tryjob, but it's still running.

cros tryjob --chrome_version HEAD falco-release-tryjob"

and stevenjb@ supported that idea.

but it currently does not work.

Comment 2 by dgarr...@chromium.org, Feb 7 2018

Summary: tryjobs should support "--chrome_version HEAD" (was: cros tryjob does not easily support for building with latest version of chrome. )

Comment 3 by dgarr...@chromium.org, Feb 7 2018

Labels: -Pri-3 Hotlist-Fixit Pri-2
Do you agree that --chrome_version HEAD would be reasonable?

If so, I'd like to address this by making it work and then dropping the old option fully.

However, since you have a workaround (though an ugly one), I'd like to keep this backburner for now.

Comment 4 by dgarr...@chromium.org, Feb 10 2018

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/eeca171f947d5849db7c0d3a5e74809e6c018690

commit eeca171f947d5849db7c0d3a5e74809e6c018690
Author: Don Garrett <dgarrett@google.com>
Date: Wed Feb 14 01:40:43 2018

sync_chrome: Add support for revision HEAD.

We want to be able to run tryjobs that use --chrome_version=HEAD. The
tryjobs pass the chrome_version along to sync_chrome. Sync chrome uses
the value to generate a gclient spec before syncing.

Accept 'HEAD' as a special case of a git SHA1 value.

BUG= chromium:809811 
TEST=Unittests
     cros tryjob -g 912273 --chrome_version=HEAD falco-release-tryjob

Change-Id: Iee7514710a5def264300a54fabd9cc0e32b67baf
Reviewed-on: https://chromium-review.googlesource.com/912273
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/eeca171f947d5849db7c0d3a5e74809e6c018690/lib/gclient_unittest.py
[modify] https://crrev.com/eeca171f947d5849db7c0d3a5e74809e6c018690/lib/gclient.py
[modify] https://crrev.com/eeca171f947d5849db7c0d3a5e74809e6c018690/cli/cros/cros_tryjob.py

Comment 6 by dgarr...@chromium.org, Feb 14 2018

Status: Fixed (was: Started)
►

Sign in to add a comment