New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 809807 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Ganesh layout test failures

Project Member Reported by enne@chromium.org, Feb 7 2018

Issue description

Looking into oop raster layout test failures, I also ran Blink's layout tests (fast/ and compositing/ only) with ganesh and found a number of things that looked wrong in ganesh vs software raster.

You can repro these by:
(1) Applying this patch: https://chromium-review.googlesource.com/c/chromium/src/+/876823
(2) ninja -C out/Debug content_shell image_diff blink_tests && third_party/WebKit/Tools/Scripts/run-webkit-tests -t Debug TESTNAMEHERE

In many cases, you can run chrome with --enable-gpu-rasterization and open up the page directly.  These files are all in third_party/WebKit/LayoutTests/.

Here's the classes of failures I saw:

(1) Gradients (often zero radius) not drawing:
    fast/gradients/crash-on-zero-radius.html
    fast/gradients/css3-radial-gradients2.html
    fast/gradients/radial-centered.html
    fast/gradients/unprefixed-radial-gradients2.html

(2) Gradient with a weird line (doesn't repro in browser, so swiftshader?):
    fast/gradients/conic-gradient-positioning.html

(3) Border radius artifact:
    fast/borders/border-radius-complex-inner.html

(4) Controls that don't look right (cut off buttons, misaligned sliders):
    fast/forms/control-clip-overflow.html
    fast/forms/input-appearance-height.html

 
conic-gradient-positioning-actual.png
151 KB View Download
radial-centered-actual.png
28.0 KB View Download
border-radius-complex-inner-actual.png
17.6 KB View Download
input-appearance-height-actual.png
19.3 KB View Download
control-clip-overflow-actual.png
20.0 KB View Download
Tangential question: is it not sufficient to pass --additional-driver-flag="--force-gpu-rasterization" to run-webkit-tests in order to repro?

(modulo issue 807311)

Comment 2 by enne@chromium.org, Feb 12 2018

Cc: ericrk@chromium.org

Comment 3 by xing...@intel.com, May 14 2018

Cc: xing...@intel.com

Comment 4 by enne@chromium.org, Jun 22 2018

I ran the layout tests with a fuzzy matcher (>1% pixel errors, errors only counted if >1 difference in r g or b), and these are still issues:

border radius:
 fast/borders/border-radius-complex-inner-double.html
 fast/borders/border-radius-complex-inner.html

gradients:
 fast/gradients/conic-gradient-positioning.html
 virtual/exotic-color-space/images/color-profile-background-clip-text.html

missing box:
 fast/text/font-format-support-cbdt-sbix-cff2.html

Comment 5 by hcm@google.com, Jun 22 2018

Labels: Hotlist-Ganesh

Sign in to add a comment