New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 809795 link

Starred by 1 user
Status: Fixed
Owner:
█ ichikawa@chromium.org
Last visit > 30 days ago
Closed: Feb 2018
Cc:
ios-bugs@chromium.org
█ ichikawa@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

shouldStartRequest is not called for non-HTTP URLs

Project Member Reported by ichikawa@google.com, Feb 7 2018 
-[CWVNavigationDelegate webView:shouldStartLoadWithRequest:navigationType:] is not called for non-HTTP URLs e.g., itms-apps://...
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bad0f861cec244e3b00c8c65cbc29f0d6ee9256

commit 7bad0f861cec244e3b00c8c65cbc29f0d6ee9256
Author: Hiroshi Ichikawa <ichikawa@chromium.org>
Date: Wed Feb 07 06:04:14 2018

Skip the logic in -shouldAllowLoadWithNavigationAction: if |_delegate| is nil.

This is a temporary workaround for  https://crbug.com/809795  until we move
this logic out of this class. This doesn't affect Chromium app because
|_delegate| is always set in Chromium app.

Bug:  809795 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7c46855a5f51d07fce71cae621c88b0b73e6bae8
Reviewed-on: https://chromium-review.googlesource.com/905872
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534928}
[modify] https://crrev.com/7bad0f861cec244e3b00c8c65cbc29f0d6ee9256/ios/web/web_state/ui/crw_web_controller.mm

Comment 2 by ichikawa@chromium.org, Feb 7 2018

Status: Fixed (was: Started)
►

Sign in to add a comment