Issue metadata
Sign in to add a comment
|
[desktop-pwas] Add origin to title bar |
||||||||||||||||||||||||
Issue descriptionThe origin should be animated out of the 3 dot menu on app launch, and then animated back in after a delay. go/dpwa-animations
,
Feb 14 2018
,
Mar 1 2018
#4 looks good! (to me)
,
Mar 2 2018
,
Mar 5 2018
+UrlFormatting: PTAL at the UI spec in #3 and WIP demo in #4. Is this eliding of the origin appropriate from a security perspective?
,
Mar 5 2018
#8 just elides from left? I think this is fine. +estark for security (please see the final window opened in the video on #4).
,
Mar 6 2018
c10 looks good. Thanks alancutter@!
,
Mar 6 2018
@hwi: I think the window opening animation overlaps with the origin slide in animation and makes it a bit unnoticeable, it might be worth adding a delay in here. I've attached a few demos that exhibit different delays on the opening animation, WDYT?
,
Mar 6 2018
c12: Great catch! I appreciate your attention to details, alancutter@. - 750ms delay looks good to me, wdyt? Additional note: - The animation looks linear and a bit slow to me looking at the screen recording. Could we try the following? --- Curve: cubic-bezier(0.16, 0.00, 0.00, 1.00) --- Origin fade/slide in: 800ms (this might feel fast for really long text, but that should be an edge case) --- Origin fade/slide out: 500ms Thanks!
,
Mar 6 2018
750ms feels a tad long to me but I don't have a problem with it. Oops, forgot about the cubic-bezier curve, ty. We're a bit restricted on the cubic-beziers available to standard animations, probably to enforce consistency. gfx::Tween::FAST_OUT_SLOW_IN_2 looks like the closest one to what you specified. It uses cubic-bezier(0.2, 0, 0.2, 1). The slide in and out durations have been 800ms and 500ms respectively in the recordings. Here's a recording of small, medium and big URLs with the 750ms delay and the cubic-bezier.
,
Mar 6 2018
Another thing that can happen during the animation is an extension browser action can be opened by the user (thanks calamity). See recording for example, the current behaviour seems reasonable to me.
,
Mar 6 2018
c14: lgtm c15: It's good to know. I don't have any strong feeling now. I'll keep watching out for it. Thanks alancutter@!
,
Mar 8 2018
Found a few more cases to account for in CL review (https://chromium-review.googlesource.com/c/chromium/src/+/942722). We need to support RTL layouts, dark theme colours and title bar colours changing with focus. See recording of all these things in action.
,
Mar 13 2018
Recording of the animation for CL https://chromium-review.googlesource.com/c/chromium/src/+/942722 without highlight animation. Highlight is being moved to a separate CL to separate out the implementation concerns from the rest of the animation.
,
Mar 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f20513c88275a6ff7c528bbca31d064cf5798057 commit f20513c88275a6ff7c528bbca31d064cf5798057 Author: Alan Cutter <alancutter@chromium.org> Date: Tue Mar 13 10:42:24 2018 Add URL origin opening animation to hosted app title bar This CL implements a title bar animation for hosted apps on chromeOS that shows the URL's origin for a few seconds when the window opens. This CL omits the menu button highlight animation as that will be implemented in a follow up CL. See bug for screencasts. Bug: 809794 Change-Id: Ied16c5720722f994fa73cafd15c2f42e3d671e50 Reviewed-on: https://chromium-review.googlesource.com/942722 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#542763} [modify] https://crrev.com/f20513c88275a6ff7c528bbca31d064cf5798057/ash/BUILD.gn [add] https://crrev.com/f20513c88275a6ff7c528bbca31d064cf5798057/ash/frame/frame_header_origin_text.cc [add] https://crrev.com/f20513c88275a6ff7c528bbca31d064cf5798057/ash/frame/frame_header_origin_text.h [modify] https://crrev.com/f20513c88275a6ff7c528bbca31d064cf5798057/chrome/browser/ui/extensions/hosted_app_browser_controller.cc [modify] https://crrev.com/f20513c88275a6ff7c528bbca31d064cf5798057/chrome/browser/ui/extensions/hosted_app_browser_controller.h [modify] https://crrev.com/f20513c88275a6ff7c528bbca31d064cf5798057/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc [modify] https://crrev.com/f20513c88275a6ff7c528bbca31d064cf5798057/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h [modify] https://crrev.com/f20513c88275a6ff7c528bbca31d064cf5798057/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc [modify] https://crrev.com/f20513c88275a6ff7c528bbca31d064cf5798057/chrome/browser/ui/views/frame/hosted_app_button_container.cc [modify] https://crrev.com/f20513c88275a6ff7c528bbca31d064cf5798057/chrome/browser/ui/views/frame/hosted_app_button_container.h
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/672d71b45aad7b32830d880159a5c144f777ba39 commit 672d71b45aad7b32830d880159a5c144f777ba39 Author: Alan Cutter <alancutter@chromium.org> Date: Fri Mar 16 00:18:22 2018 Add menu button highlight animation to origin title animation for hosted apps This CL adds a menu button highlight animation to run along side the origin title bar text animation for hosted apps added in: https://chromium-review.googlesource.com/c/chromium/src/+/942722 Screencast: https://bugs.chromium.org/p/chromium/issues/attachment?aid=327708&signed_aid=U4VyDkrKmEzMN56O5woqsw==&inline=1 Bug: 809794 Change-Id: I7ed8a7c9ccbf2c020bd9c76fb04f2a3123f265de Reviewed-on: https://chromium-review.googlesource.com/958899 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Mohsen Izadi <mohsen@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#543569} [modify] https://crrev.com/672d71b45aad7b32830d880159a5c144f777ba39/ash/shelf/shelf_view_unittest.cc [modify] https://crrev.com/672d71b45aad7b32830d880159a5c144f777ba39/chrome/browser/ui/views/frame/hosted_app_button_container.cc [modify] https://crrev.com/672d71b45aad7b32830d880159a5c144f777ba39/chrome/browser/ui/views/frame/hosted_app_button_container.h [modify] https://crrev.com/672d71b45aad7b32830d880159a5c144f777ba39/ui/views/animation/ink_drop.h [modify] https://crrev.com/672d71b45aad7b32830d880159a5c144f777ba39/ui/views/animation/ink_drop_impl.cc [modify] https://crrev.com/672d71b45aad7b32830d880159a5c144f777ba39/ui/views/animation/ink_drop_impl.h [modify] https://crrev.com/672d71b45aad7b32830d880159a5c144f777ba39/ui/views/animation/ink_drop_stub.cc [modify] https://crrev.com/672d71b45aad7b32830d880159a5c144f777ba39/ui/views/animation/ink_drop_stub.h [modify] https://crrev.com/672d71b45aad7b32830d880159a5c144f777ba39/ui/views/animation/test/test_ink_drop.cc [modify] https://crrev.com/672d71b45aad7b32830d880159a5c144f777ba39/ui/views/animation/test/test_ink_drop.h
,
Mar 16 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by alancutter@chromium.org
, Feb 14 2018