New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 809792 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression

Blocking:
issue 808174



Sign in to add a comment

upgrade stumpy test-ap (aka testbed-ap) in WIFI lab

Project Member Reported by grundler@chromium.org, Feb 7 2018

Issue description

Stumpy machines currently used in the Wifi test lab are running on:
grundler <2072>fgrep stumpy routers-DESCRIPTION.txt | sed s'/.*CHROMEOS_RELEASE_DESCRIPTION=//' | cut -d " " -f 1 | sort | uniq -c
      1 5613.0.2014_03_10_1714
      1 7298.0.2015_07_24_1640
     36 7424.0.2015_09_03_1514
      1 7677.0.2015_11_25_1634
      1 7849.0.2016_01_20_1944

But due to the update to netperf-2.7, I need to build and deploy a new stumpy-test-ap image.  This seems like a good idea anyway since we'd like all our APs to be running the same versions of SW.


1) build stumpy-test_ap:

cros tryjob -b release-R65-10323.B -g 900169 -g 902706 --hwtest --committer grundler@google.com stumpy-test-ap-tryjob
Verifying patches...
Submitting tryjob...
Successfully sent PUT request to [buildbucket_bucket:master.chromiumos.tryserver] with [config:stumpy-test-ap-tryjob] [buildbucket_id:8955308909329631504].
Tryjob submitted!
To view your tryjobs, visit:
  http://cros-goldeneye/chromeos/healthmonitoring/buildDetails?buildbucketId=8955308909329631504
  https://uberchromegw.corp.google.com/i/chromiumos.tryserver/waterfall?committer=grundler@google.com&builder=test_ap

fails with:
chromeos-chrome-65.0.3325.56_rc-r1:
../../../../../../../home/chrome-bot/chrome_root/src/chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge.cc:7:10:
fatal error:  'bluetooth/bluetooth.h' file not found
chromeos-chrome-65.0.3325.56_rc-r1: #include <bluetooth/bluetooth.h

$ equery-panther b bluetooth/bluetooth.h
 * Searching for bluetooth/bluetooth.h ... 
net-wireless/bluez-5.44-r120 (/usr/include/bluetooth/bluetooth.h)

So I either need to NOT build chromeos-chrome for the test-ap build OR I need to include net-wireless/bluez as a dependency.

Any advice for this poor lost soul? :)


TODO:
2) lock a host with stumpy in the wificell (see cautotest and use hostview to find one)

3) deploy the test image to the corresponding AP. Something like:
   cros flash chromeos15-row1-rack4-host5-router.cros xbuddy://remote/trybot-whirlwind-test-ap-tryjob/R65-10323.15.0-c39332


4) test the image. Something like:
    B=kefka ; HOST=chromeos15-row1-rack4-host5.cros; test_that -b $B  $HOST suite:wifi_perf

5) update network_WiFi_UpdateRouter to use the new image (this will update all the routers over night):
   e.g. https://chromium-review.googlesource.com/757122
 

6) verify all the routers are running release-R65-10323.B builds:
    for h in $(cat hosts-wificell.txt); do r="$h-router.cros" ; echo "$r " $(ssh root@$r fgrep DESCRIPTION /etc/lsb-release); done > routers-DESCRIPTION.txt

    grep stumpy routers-DESCRIPTION.txt | sed s'/.*CHROMEOS_RELEASE_DESCRIPTION=//' | cut -d " " -f 1 | sort | uniq -c

5) $PROFIT from better testing. :D

Other bugs worth looking at:
 crbug.com/770255  "Move to new stable whirlwind testbed-ap build and deploy to lab"
 
Blocking: 808174
Cc: mcchou@chromium.org dmitrygr@google.com
Seems like chrome started depending on bluez without actually listing it in the ebuild, as of this:

https://codereview.chromium.org/2166143002

(i.e., a long time ago)

We don't really need Chrome (and we are purposely disabling USE=bluetooth in the testbed-ap profile), so maybe we need to go whole-hog and move panther and stumpy testbed-ap to the embedded profile, just like we do for whirlwind.

This would have other ramifications, but so far, I think we're dealing with those ramifications for whirlwind.
~/trunk/src/private-overlays/overlay-stumpy-private $ git diff
diff --git a/profiles/testbed-ap/parent b/profiles/testbed-ap/parent
index 00222c6..54d59b5 100644
--- a/profiles/testbed-ap/parent
+++ b/profiles/testbed-ap/parent
@@ -1,2 +1,3 @@
 ../base
+chromiumos:features/embedded
 chromeos:features/testbed-ap

then setup the board:
 ./setup_board --board=stumpy --profile=testbed-ap --force

Failed with:

ERROR   :  build_image_util.sh:104:check_blacklist(), called: die 'Blacklisted packages found: dev-lang/python.' 
ERROR   : 
ERROR   : Error was:
ERROR   :   Blacklisted packages found: dev-lang/python.

Since whirlwind doesn't hit this issue, is that like due "../base" needing to be replaced with "chromiumos:default/linux/arm/10.0/chromeos" (or rather the equivalent for amd64)?
Sorry - a bit too terse in comment #3: build_image failed with the given error. Here my normal "build everything" command line:

for B in panther stumpy ; do nice ./build_packages --board=$B --withautotest; if [ $? -ne 0 ] ; then echo "===== FAILED : $(date) : ./build_packages --board=$B =====" >> FAILED.out; else nice ./build_image test --board=$B --noenable_rootfs_verification; if [ $? -ne 0 ] ; then echo "===== FAILED : $(date) : ./build_image test --board=$B =====" >> FAILED.out; fi; fi; done

Comment 5 by grundler@google.com, Feb 16 2018

Hrm..I suspect I need to drop the "--withautotest" so it doesn't automagically pull in python. Will try that.
vapier provided the right magic. \o/

~/trunk/src/overlays/overlay-stumpy $ cat scripts/board_specific_setup.sh 
#!/bin/bash
# Copyright 2018 The Chromium OS Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

if portageq-${FLAGS_board} envvar USE | grep -E '(^| )wifi_testbed_ap( |$)'; then
    #  crbug.com/809792  : python is needed on testbed-ap profiles.
    skip_blacklist_check=1
fi


flashing to USB and testing next.

Comment 7 by grundler@google.com, Feb 16 2018

Status: Started (was: Assigned)
This boots on stumpy but it seems to still have chrome and the UI login. :(

Three things I want to do related to this:
1) test this build anyway on real stump "-router" in the lab

2) figure out how to remove chrome from the build.  Will have to look at fizz-accelerator build.

3) post CLs, cherry-pick those to release-R65-10323.B, retest with official build


4) move testbed-ap stuff to public overlay (or first clone it there since that's were "chromium:features/embedded" lives)


Project Member

Comment 8 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/07fb6f3d6bd6ff287fd0f26232b50ef128fc03bc

commit 07fb6f3d6bd6ff287fd0f26232b50ef128fc03bc
Author: Grant Grundler <grundler@chromium.org>
Date: Fri Mar 02 03:13:35 2018

chromeos-init: start frecon if also embedded

When USE=cros_embedded,  not all upstart scripts are installed.

If USE=frecon is set, we need boot-splash.conf installed to
start frecon. Thus boot-splash.conf needs to be installed
when both flags are specified.

BUG= chromium:809792 
TEST=./setup_board --board=stumpy --profile=testbed-ap --force
	./build_packages --board=stumpy
	./build_image test --board=stumpy --noenable_rootfs_verification

	cros flash stumpy.lab
	# verify monitor shows a console

Change-Id: If9a831409c7f76110714d7fe29c3b2bc10d49455
Reviewed-on: https://chromium-review.googlesource.com/938641
Commit-Ready: Grant Grundler <grundler@chromium.org>
Tested-by: Grant Grundler <grundler@chromium.org>
Reviewed-by: Grant Grundler <grundler@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/07fb6f3d6bd6ff287fd0f26232b50ef128fc03bc/chromeos-base/chromeos-init/chromeos-init-9999.ebuild

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 3 2018

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 6 2018

Labels: merge-merged-release-R65-10323.B
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-stumpy-private/+/0c4f53309ff48a64e31ea3f3a0fb41fc2405e406

commit 0c4f53309ff48a64e31ea3f3a0fb41fc2405e406
Author: Grant Grundler <grundler@chromium.org>
Date: Tue Mar 06 22:21:02 2018

Status: WontFix (was: Started)
the follow CL allows one to build on top of R65 branch, the last version to officially support stumpy:
   https://chromium-review.googlesource.com/c/chromiumos/overlays/board-overlays/+/927228

However, wifi_matfunc tests failed entirely to connect the DUT with the stumpy. I didn't pursue debugging this since stumpy machines are unsupported HW and we have to replace all stumpy devices in any case.
Project Member

Comment 12 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/31f5f56c0194d8025ced5dd8283a0023be8d75ac

commit 31f5f56c0194d8025ced5dd8283a0023be8d75ac
Author: Grant Grundler <grundler@chromium.org>
Date: Fri May 11 06:18:06 2018

init: start frecon even if no assets

In "embedded" configurations, we don't have any chrome assets
and that makes frecon very unhappy (exits) once it finds out
the "*.png" doesn't exist.

This change also allows board specific overlays to overide the
"ASSETLESS_ARG" parameters to frecon.

BUG= chromium:809792 
TEST=./build_packages --board=kefka
     ./build_image test --board=kefka --noenable_rootfs_verification
     cros flash kefka.lab
     # verify console works in dev mode.

ORIG_TEST=./setup_board --board=stumpy --profile=testbed-ap --force
     ./build_packages --board=stumpy
     ./build_image test --board=stumpy --noenable_rootfs_verification
     cros flash stumpy.lab
     # verify monitor shows a console

Change-Id: Id9bf0563bc3564ee12ef6f354cf5fb78c4181d52
Reviewed-on: https://chromium-review.googlesource.com/939501
Commit-Ready: Grant Grundler <grundler@chromium.org>
Tested-by: Grant Grundler <grundler@chromium.org>
Reviewed-by: Grant Grundler <grundler@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>

[modify] https://crrev.com/31f5f56c0194d8025ced5dd8283a0023be8d75ac/init/upstart/boot-splash.conf

Sign in to add a comment