New issue
Advanced search Search tips

Issue 809771 link

Starred by 1 user
Status: Fixed
Owner:
mek@chromium.org
Closed: Jun 2018
Cc:
mek@chromium.org
dmu...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename LevelDBWrapper to DOMStorageDatabase

Project Member Reported by dmu...@chromium.org, Feb 6 2018 
LevelDBWrapper mojo interface has become very specifically tied to the implementation and functionality of DOMStorage.

Since namespace cloning in session storage is required to be in the same sequence as the leveldbwrapper calls, it makes sense to make this cloning as a method on the leveldbwrapper mojo interface. This doesn't make sense at all for a genearic leveldb wrapper, so the interface should be made specific to domstorage now.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de

commit f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Thu Jun 07 18:57:12 2018

[DOMStorage] Move leveldb_wrapper.mojom to blink in preparation for onion souping.

Also rename from LevelDBWrapper to StorageArea to better reflect what
the interface is used for.

Bug:  781870 ,  809771 
Change-Id: I712fee920d95f5e18dc6bfa74d1277c8aed4bd19
Reviewed-on: https://chromium-review.googlesource.com/1087495
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565365}
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/dom_storage_context_wrapper.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/dom_storage_context_wrapper.h
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/local_storage_context_mojo.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/local_storage_context_mojo.h
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/local_storage_context_mojo_unittest.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/session_storage_context_mojo.h
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/session_storage_context_mojo_unittest.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/session_storage_data_map.h
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/session_storage_data_map_unittest.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/session_storage_leveldb_wrapper.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/session_storage_leveldb_wrapper.h
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/session_storage_leveldb_wrapper_unittest.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/session_storage_namespace_impl_mojo.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/session_storage_namespace_impl_mojo.h
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/session_storage_namespace_impl_mojo_unittest.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/isolated_origin_browsertest.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/leveldb_wrapper_impl.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/leveldb_wrapper_impl.h
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/leveldb_wrapper_impl_unittest.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/storage_partition_impl.h
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/common/BUILD.gn
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/common/storage_partition_service.mojom
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/renderer/dom_storage/local_storage_cached_area.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/renderer/dom_storage/local_storage_cached_area.h
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/renderer/dom_storage/local_storage_cached_area_unittest.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/renderer/dom_storage/mock_leveldb_wrapper.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/renderer/dom_storage/mock_leveldb_wrapper.h
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/test/leveldb_wrapper_test_util.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/test/leveldb_wrapper_test_util.h
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/third_party/blink/public/mojom/BUILD.gn
[add] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/third_party/blink/public/mojom/dom_storage/OWNERS
[rename] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/third_party/blink/public/mojom/dom_storage/storage_area.mojom

Comment 2 by mek@chromium.org, Jun 11 2018

Cc: dmu...@chromium.org
Owner: mek@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819

commit 87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Wed Jun 13 00:18:29 2018

[DOMStorage] Rename LevelDBWrapperImpl to StorageAreaImpl.

And rename all names that were derived from this name (i.e. variable
names and other related classes) to no longer mention LevelDBWrapper as
well. Left alone the code in content/renderer/dom_storage for now, as
all that code will get moved/renamed as part of actually onion-souping
this anyway, so changing things now is just code churn for no good
reason.

Bug:  809771 
Change-Id: I5d8675f98bf19eb0e14329c42f7312f0b33fe982
Reviewed-on: https://chromium-review.googlesource.com/1096274
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566642}
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/BUILD.gn
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/OWNERS
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/browser_main_loop.cc
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/dom_storage_area.cc
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/local_storage_context_mojo.cc
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/local_storage_context_mojo.h
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/local_storage_context_mojo_unittest.cc
[rename] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_area_impl.cc
[rename] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_area_impl.h
[rename] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_area_impl_unittest.cc
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_context_mojo.cc
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_context_mojo.h
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_context_mojo_unittest.cc
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_data_map.cc
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_data_map.h
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_data_map_unittest.cc
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_namespace_impl_mojo.cc
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_namespace_impl_mojo.h
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_namespace_impl_mojo_unittest.cc
[rename] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/storage_area_impl.cc
[rename] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/storage_area_impl.h
[rename] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/storage_area_impl_unittest.cc
[rename] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/test/storage_area_test_util.cc
[rename] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/test/storage_area_test_util.h
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/test/BUILD.gn

Comment 4 by mek@chromium.org, Jun 13 2018

Status: Fixed (was: Started)
Marking as fixed. There is still MockLevelDBWrapper, but that will be renamed as part of onion-souping.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819

commit 87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Wed Jun 13 00:18:29 2018

[DOMStorage] Rename LevelDBWrapperImpl to StorageAreaImpl.

And rename all names that were derived from this name (i.e. variable
names and other related classes) to no longer mention LevelDBWrapper as
well. Left alone the code in content/renderer/dom_storage for now, as
all that code will get moved/renamed as part of actually onion-souping
this anyway, so changing things now is just code churn for no good
reason.

Bug:  809771 
Change-Id: I5d8675f98bf19eb0e14329c42f7312f0b33fe982
Reviewed-on: https://chromium-review.googlesource.com/1096274
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566642}
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/BUILD.gn
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/OWNERS
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/browser_main_loop.cc
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/dom_storage_area.cc
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/local_storage_context_mojo.cc
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/local_storage_context_mojo.h
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/local_storage_context_mojo_unittest.cc
[rename] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_area_impl.cc
[rename] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_area_impl.h
[rename] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_area_impl_unittest.cc
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_context_mojo.cc
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_context_mojo.h
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_context_mojo_unittest.cc
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_data_map.cc
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_data_map.h
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_data_map_unittest.cc
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_namespace_impl_mojo.cc
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_namespace_impl_mojo.h
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_namespace_impl_mojo_unittest.cc
[rename] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/storage_area_impl.cc
[rename] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/storage_area_impl.h
[rename] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/storage_area_impl_unittest.cc
[rename] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/test/storage_area_test_util.cc
[rename] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/test/storage_area_test_util.h
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/test/BUILD.gn
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819

commit 87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Wed Jun 13 00:18:29 2018

[DOMStorage] Rename LevelDBWrapperImpl to StorageAreaImpl.

And rename all names that were derived from this name (i.e. variable
names and other related classes) to no longer mention LevelDBWrapper as
well. Left alone the code in content/renderer/dom_storage for now, as
all that code will get moved/renamed as part of actually onion-souping
this anyway, so changing things now is just code churn for no good
reason.

Bug:  809771 
Change-Id: I5d8675f98bf19eb0e14329c42f7312f0b33fe982
Reviewed-on: https://chromium-review.googlesource.com/1096274
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566642}
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/BUILD.gn
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/OWNERS
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/browser_main_loop.cc
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/dom_storage_area.cc
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/local_storage_context_mojo.cc
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/local_storage_context_mojo.h
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/local_storage_context_mojo_unittest.cc
[rename] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_area_impl.cc
[rename] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_area_impl.h
[rename] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_area_impl_unittest.cc
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_context_mojo.cc
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_context_mojo.h
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_context_mojo_unittest.cc
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_data_map.cc
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_data_map.h
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_data_map_unittest.cc
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_namespace_impl_mojo.cc
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_namespace_impl_mojo.h
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/session_storage_namespace_impl_mojo_unittest.cc
[rename] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/storage_area_impl.cc
[rename] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/storage_area_impl.h
[rename] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/storage_area_impl_unittest.cc
[rename] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/test/storage_area_test_util.cc
[rename] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/browser/dom_storage/test/storage_area_test_util.h
[modify] https://crrev.com/87ab0fb7d634c8ae4453c8e3f91f5ed4499e9819/content/test/BUILD.gn
►

Sign in to add a comment