Issue metadata
Sign in to add a comment
|
At latest version, Tricium fails to poll Gerrit for changes |
||||||||||||||||||||||
Issue descriptionAt version 13882-47b35ea, Tricium fails to start AnalyzeRequest for new patch sets, because it appears to : failed to poll: failed to query for change: Get chromium-review.googlesource.com/a/changes/?o=CURRENT_REVISION&o=CURRENT_FILES&o=DETAILED_ACCOUNTS&q=project%3Aplayground%2Fgerrit-tricium%2Fdemo+after%3A%222018-02-06+22%3A07%3A43.000000000%22&start=0: API error 1 (urlfetch: INVALID_URL) :: {"error":"failed to query for change: Get chromium-review.googlesource.com/a/changes/?o=CURRENT_REVISION&o=CURRENT_FILES&o=DETAILED_ACCOUNTS&q=project%3Aplayground%2Fgerrit-tricium%2Fdemo+after%3A%222018-02-06+22%3A07%3A43.000000000%22&start=0: API error 1 (urlfetch: INVALID_URL)"} After switching back to version 13773-ffcc5e3, I get successful poll requests with messages including: Using URL: https://chromium-review.googlesource.com/a/changes/?o=CURRENT_REVISION&o=CURRENT_FILES&o=DETAILED_ACCOUNTS&q=project%3Aplayground%2Fgerrit-tricium%2Fdemo+after%3A%222018-02-06+23%3A14%3A42.000000000%22&start=0
,
Feb 6 2018
The clearest difference between the two log entries is the presence of https://. Change 11d51e0f0 is the suspected one that would affect that. Made a revert: https://canary-chromium-review.googlesource.com/c/infra/infra/+/905762
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/57743d01092ede02ddf224b7ad38154414c8fc55 commit 57743d01092ede02ddf224b7ad38154414c8fc55 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Wed Feb 07 00:10:04 2018 Revert "Remove temporary code used to add https to hosts" This reverts commit 11d51e0f0752a7193d296af70b74f5eb3ed1ff7e. Reason for revert: Apparently prepending https is still required sometimes, including when querying Gerrit: https://crbug.com/809767 Original change's description: > Remove temporary code used to add https to hosts > > Change-Id: I05c94420a9fe8828b3c9bd7d1a672a70f1347a62 > Reviewed-on: https://chromium-review.googlesource.com/903051 > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> > Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Bug: 809767 Change-Id: I8e26ba6d99cd714dec03d8614b2e7fb9df8d0afe Reviewed-on: https://chromium-review.googlesource.com/905762 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> [modify] https://crrev.com/57743d01092ede02ddf224b7ad38154414c8fc55/go/src/infra/tricium/appengine/gerrit/gerrit_test.go [modify] https://crrev.com/57743d01092ede02ddf224b7ad38154414c8fc55/go/src/infra/tricium/appengine/gerrit/gerrit.go
,
Feb 7 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by qyears...@chromium.org
, Feb 6 2018