New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 809767 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

At latest version, Tricium fails to poll Gerrit for changes

Project Member Reported by qyears...@chromium.org, Feb 6 2018

Issue description

Note: The changes in between ffcc5e3 and 47b35ea are:

 91e92e1e6 Roll luci-go.
 47b35eab2 In set review request, use patch set number
 78bd9ceaf [Tricium] Proofread and reformat comments
 11d51e0f0 Remove temporary code used to add https to hosts
 b6876f848 Fix two minor spelling issues in isolate.go
 afaeeb0fc [Tricium] Include notify: NONE when posting to Gerrit

Status: Started (was: Assigned)
The clearest difference between the two log entries is the presence of https://. Change 11d51e0f0 is the suspected one that would affect that. Made a revert: https://canary-chromium-review.googlesource.com/c/infra/infra/+/905762
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/57743d01092ede02ddf224b7ad38154414c8fc55

commit 57743d01092ede02ddf224b7ad38154414c8fc55
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Wed Feb 07 00:10:04 2018

Revert "Remove temporary code used to add https to hosts"

This reverts commit 11d51e0f0752a7193d296af70b74f5eb3ed1ff7e.

Reason for revert: Apparently prepending https is still required
sometimes, including when querying Gerrit:  https://crbug.com/809767 

Original change's description:
> Remove temporary code used to add https to hosts
>
> Change-Id: I05c94420a9fe8828b3c9bd7d1a672a70f1347a62
> Reviewed-on: https://chromium-review.googlesource.com/903051
> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

Bug:  809767 
Change-Id: I8e26ba6d99cd714dec03d8614b2e7fb9df8d0afe
Reviewed-on: https://chromium-review.googlesource.com/905762
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/57743d01092ede02ddf224b7ad38154414c8fc55/go/src/infra/tricium/appengine/gerrit/gerrit_test.go
[modify] https://crrev.com/57743d01092ede02ddf224b7ad38154414c8fc55/go/src/infra/tricium/appengine/gerrit/gerrit.go

Status: Fixed (was: Started)

Sign in to add a comment