When status is pending, Tricium ProgressResponse returns no status |
||||||||
Issue description
Example request:
{
consumer: "GERRIT",
gerritDetails: {
change: "playground%2Fgerrit-tricium%2Fdemo~master~I362c3eebfda853f8f22df3b98b2c0c572ae00f66",
host: "chromium-review.googlesource.com",
project: "playground/gerrit-tricium/demo",
revision: "refs/changes/63/899863/5"
}
}
Response:
{
"runId": "5723348596162560",
"state": "RUNNING",
"functionProgress": [{
"name": "GitFileIsolator",
"state": "RUNNING",
"swarmingUrl": "https://chromium-swarm.appspot.com",
"swarmingTaskId": "3b86383d14952f10"
}, {
"name": "Hello"
}, {
"name": "Spacey"
}]
}
What this means is that while analyzers are pending, they are shown in a white-background unstyled box. They could be shown in a colored box with an icon.
Possible fixes: The Progress response should included state: PENDING. Perhaps the plugin should also use PENDING as a default state if nothing is present in the response.
,
Feb 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/09a41d700b2f0d9c2d67e52a1d85abf1e02a1701 commit 09a41d700b2f0d9c2d67e52a1d85abf1e02a1701 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Thu Feb 08 17:52:16 2018 Interpret a result with no state field as "pending". Tricium currently returns results for analyzers that haven't started yet with no state field. No state field really means "pending" in this case. Bug: 809764 Change-Id: Ibfdc478694d58b997d12cc7f37582176653d89a3 Reviewed-on: https://chromium-review.googlesource.com/907347 Reviewed-by: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/09a41d700b2f0d9c2d67e52a1d85abf1e02a1701/test/tricium-view_test.html [modify] https://crrev.com/09a41d700b2f0d9c2d67e52a1d85abf1e02a1701/src/main/resources/static/tricium-view.js [modify] https://crrev.com/09a41d700b2f0d9c2d67e52a1d85abf1e02a1701/test/example.html
,
Mar 25 2018
Interesting related case: https://tricium-dev.appspot.com/run/5642383161032704 https://gerrit-review.googlesource.com/c/gerrit/+/168232/1 In this case, GitFileIsolator failed (it didn't handle the git submodule "plugins/replication" correctly) but it was apparently never marked as failed, and then Spacey got caught in limbo.
,
Apr 23 2018
,
May 15 2018
This is no longer really a problem since the change in #2; however, ideally I still think the progress RPC should return pending rather than nothing.
,
May 15 2018
,
May 15 2018
,
Jun 15 2018
,
Jun 15 2018
,
Jan 2
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by qyears...@chromium.org
, Feb 7 2018