New issue
Advanced search Search tips

Issue 809760 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ComponentUpdater is missing the session id of the Omaha protocol

Project Member Reported by sorin@chromium.org, Feb 6 2018

Issue description

Somehow it has not been implemented so far. The session id is required for the recovery component and the long tail analysis.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d69d43777574234faf9354c0d2e9ac75a8658697

commit d69d43777574234faf9354c0d2e9ac75a8658697
Author: Sorin Jianu <sorin@chromium.org>
Date: Wed Feb 07 19:44:22 2018

Add the session id attribute to the component updater protocol.

Bug:  809760 
Change-Id: Ia34c70ba563cdd11fbff2d545533c66df9a94601
Reviewed-on: https://chromium-review.googlesource.com/904945
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535103}
[modify] https://crrev.com/d69d43777574234faf9354c0d2e9ac75a8658697/components/update_client/component.cc
[modify] https://crrev.com/d69d43777574234faf9354c0d2e9ac75a8658697/components/update_client/component.h
[modify] https://crrev.com/d69d43777574234faf9354c0d2e9ac75a8658697/components/update_client/ping_manager_unittest.cc
[modify] https://crrev.com/d69d43777574234faf9354c0d2e9ac75a8658697/components/update_client/protocol_builder.cc
[modify] https://crrev.com/d69d43777574234faf9354c0d2e9ac75a8658697/components/update_client/protocol_builder.h
[modify] https://crrev.com/d69d43777574234faf9354c0d2e9ac75a8658697/components/update_client/protocol_builder_unittest.cc
[modify] https://crrev.com/d69d43777574234faf9354c0d2e9ac75a8658697/components/update_client/update_checker.cc
[modify] https://crrev.com/d69d43777574234faf9354c0d2e9ac75a8658697/components/update_client/update_checker.h
[modify] https://crrev.com/d69d43777574234faf9354c0d2e9ac75a8658697/components/update_client/update_checker_unittest.cc
[modify] https://crrev.com/d69d43777574234faf9354c0d2e9ac75a8658697/components/update_client/update_client_unittest.cc
[modify] https://crrev.com/d69d43777574234faf9354c0d2e9ac75a8658697/components/update_client/update_engine.cc
[modify] https://crrev.com/d69d43777574234faf9354c0d2e9ac75a8658697/components/update_client/update_engine.h

Comment 2 by sorin@chromium.org, Feb 12 2018

Status: Fixed (was: Started)

Sign in to add a comment