New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 809726 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 644851



Sign in to add a comment

SkiaRenderer for Android metabug

Project Member Reported by weiliangc@chromium.org, Feb 6 2018

Issue description

Tracking issue for making SkiaRenderer work w/ Android.
 
Cc: sohan.jy...@samsung.com egdaniel@chromium.org
One of the bug is OverscrollGlow UIBitmap in resource format alpha_8 causes crash.

Some of the work would overlap with Skia RGBA support?
So trying to remember from the email thread about the alpha_8 crash, but I believe everything is implemented on Skia's side. I'm looking at the the call site where we made the GrBackendTexture in chrome, https://cs.chromium.org/chromium/src/cc/resources/display_resource_provider.cc?sq=package:chromium&l=630, and it looks like it may be updated already to the new API. Can someone confirm whether there is still a crash or if is fixed now?
Cc: -sohan.jy...@samsung.com sohan.jy...@huawei.com
Sorry, i am OOO till 02.09. Can confirm once i am back. But looking at the code both skia and chromium changes look to be in place.
If you would like to try it, you can scroll/fling to the end of page rapidly and and check the glow effect.
The OverscrollGlow crash is fixed now on ToT (66.0.3346.0)
Looks like even though the OverscrollGlow crash is solved, there exists one more UIBitmap crash for compressed ETC1 textures. 
This would be drawn when we are in TabManager. The viz::TextureStorageFormat cannot handle it while drawing the texture quad. Not sure how stable/usable is GL_ETC1_RGB8_OES for ETC1 textures.
Currently i see blank thumbnails if i add the case.
case ETC1:
  return GL_ETC1_RGB8_OES; 

Any pointers ?
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/986b5c51b8744d193845b5e7ec667b3a6c2071af

commit 986b5c51b8744d193845b5e7ec667b3a6c2071af
Author: Eric Karl <ericrk@chromium.org>
Date: Mon Dec 03 22:03:47 2018

Fix SkiaRenderer on Android

Fixes two small issues preventing SkiaRenderer from running on Android:
- Enablment flags not forwarded via RendererSettings.
- gles2::FeatureInfo not available on SkiaOutputSurfaceImplOnGpu.

Bug: 809726
Change-Id: I66de6c577eaa4d4b1eb6e6ae45c5036ae0b098f0
Reviewed-on: https://chromium-review.googlesource.com/c/1352248
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613275}
[modify] https://crrev.com/986b5c51b8744d193845b5e7ec667b3a6c2071af/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
[modify] https://crrev.com/986b5c51b8744d193845b5e7ec667b3a6c2071af/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.h
[modify] https://crrev.com/986b5c51b8744d193845b5e7ec667b3a6c2071af/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/986b5c51b8744d193845b5e7ec667b3a6c2071af/content/browser/renderer_host/compositor_impl_android_browsertest.cc

Status: Untriaged (was: Available)
Available, but no owner or component? Please find a component, as no one will ever find this without one.

Sign in to add a comment