New issue
Advanced search Search tips

Issue 809684 link

Starred by 1 user
Status: Fixed
Owner:
rtoy@chromium.org
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

getFrequencyResponse must throw InvalidAccessError if arrays have different lengths

Project Member Reported by rtoy@chromium.org, Feb 6 2018 
For both the BiquadFilterNode and the IIRFilterNode, getFrequencyResponse must throw an InvalidAccessError if the three arrays are not the same length.

See https://webaudio.github.io/web-audio-api/#methods-9 and https://webaudio.github.io/web-audio-api/#methods-10
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/584a60c727a995065e26c231dd7fff9dc31afbd4

commit 584a60c727a995065e26c231dd7fff9dc31afbd4
Author: Raymond Toy <rtoy@chromium.org>
Date: Thu Feb 08 15:40:06 2018

getFrequencyResponse must signal error if arrays lengths differ

For both the BiquadFilterNode and the IIRFilterNode, the arrays passed
to getFrequencyResponse must have the same length.  If not, throw an
InvalidAccessError.

Bug:  809684 
Test: BiquadFilter/biquad-basic.html, IIRFilter/iirfilter-basic.html
Change-Id: Id6df2ae8b9cecd8f28e814a94c258264fa0ff70f
Reviewed-on: https://chromium-review.googlesource.com/905566
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535392}
[add] https://crrev.com/584a60c727a995065e26c231dd7fff9dc31afbd4/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-basic.html
[modify] https://crrev.com/584a60c727a995065e26c231dd7fff9dc31afbd4/third_party/WebKit/LayoutTests/webaudio/IIRFilter/iirfilter-basic.html
[modify] https://crrev.com/584a60c727a995065e26c231dd7fff9dc31afbd4/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp
[modify] https://crrev.com/584a60c727a995065e26c231dd7fff9dc31afbd4/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.h
[modify] https://crrev.com/584a60c727a995065e26c231dd7fff9dc31afbd4/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.idl
[modify] https://crrev.com/584a60c727a995065e26c231dd7fff9dc31afbd4/third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp

Comment 2 by rtoy@chromium.org, Feb 12 2018

Status: Fixed (was: Started)
►

Sign in to add a comment