Location bar isn't shown outside fullscreen on Mac, ChromeOS |
||||||||||||
Issue descriptionChrome Version: 66.0.3332.0 OS: Mac, ChromeOS What steps will reproduce the problem? (1) Start a presentation (e.g. via https://googlechrome.github.io/samples/presentation-api/). (2) Choose a wired display device. (3) Select the presentation window and exit fullscreen. What is the expected result? A location bar should appear above the receiver page. What happens instead? No location bar is shown.
,
Feb 8 2018
,
Feb 9 2018
,
Mar 20 2018
,
Mar 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7678b8c1421bf19cc89c34c51492d8b38895efda commit 7678b8c1421bf19cc89c34c51492d8b38895efda Author: btolsch <btolsch@chromium.org> Date: Wed Mar 21 22:30:22 2018 Fix presentation receiver window location bar in chromeos Chromebooks have an additional hardware button that allows them to toggle windows fullscreen. This bypasses the ExclusiveAccessManager, which is only tied to the normal platform shortcut (e.g. F11). This change adds a window observer for Chrome OS to watch for fullscreen changes outside the ExclusiveAccessManager. Bug: 809682 Change-Id: I021815dd4aff07bc1b389286d24d85380f380e0e Reviewed-on: https://chromium-review.googlesource.com/905447 Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#544877} [modify] https://crrev.com/7678b8c1421bf19cc89c34c51492d8b38895efda/chrome/browser/ui/views/media_router/presentation_receiver_window_view.cc [modify] https://crrev.com/7678b8c1421bf19cc89c34c51492d8b38895efda/chrome/browser/ui/views/media_router/presentation_receiver_window_view.h [add] https://crrev.com/7678b8c1421bf19cc89c34c51492d8b38895efda/chrome/browser/ui/views/media_router/presentation_receiver_window_view_chromeos_browsertest.cc [modify] https://crrev.com/7678b8c1421bf19cc89c34c51492d8b38895efda/chrome/test/BUILD.gn [modify] https://crrev.com/7678b8c1421bf19cc89c34c51492d8b38895efda/testing/buildbot/filters/mash.browser_tests.filter
,
Mar 26 2018
Should we merge #5 into M66?
,
Mar 27 2018
Sure
,
Mar 27 2018
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 27 2018
Approving merge to M66. Branch:3359
,
Mar 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae97e68b95cbf9e4fdeed206d71f4672d82594c3 commit ae97e68b95cbf9e4fdeed206d71f4672d82594c3 Author: btolsch <btolsch@chromium.org> Date: Thu Mar 29 17:03:18 2018 Fix presentation receiver window location bar in chromeos Chromebooks have an additional hardware button that allows them to toggle windows fullscreen. This bypasses the ExclusiveAccessManager, which is only tied to the normal platform shortcut (e.g. F11). This change adds a window observer for Chrome OS to watch for fullscreen changes outside the ExclusiveAccessManager. TBR=btolsch@chromium.org (cherry picked from commit 7678b8c1421bf19cc89c34c51492d8b38895efda) Bug: 809682 Change-Id: I021815dd4aff07bc1b389286d24d85380f380e0e Reviewed-on: https://chromium-review.googlesource.com/905447 Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Derek Cheng <imcheng@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#544877} Reviewed-on: https://chromium-review.googlesource.com/984386 Cr-Commit-Position: refs/branch-heads/3359@{#497} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/ae97e68b95cbf9e4fdeed206d71f4672d82594c3/chrome/browser/ui/views/media_router/presentation_receiver_window_view.cc [modify] https://crrev.com/ae97e68b95cbf9e4fdeed206d71f4672d82594c3/chrome/browser/ui/views/media_router/presentation_receiver_window_view.h [add] https://crrev.com/ae97e68b95cbf9e4fdeed206d71f4672d82594c3/chrome/browser/ui/views/media_router/presentation_receiver_window_view_chromeos_browsertest.cc [modify] https://crrev.com/ae97e68b95cbf9e4fdeed206d71f4672d82594c3/chrome/test/BUILD.gn [modify] https://crrev.com/ae97e68b95cbf9e4fdeed206d71f4672d82594c3/testing/buildbot/filters/mash.browser_tests.filter
,
Mar 30 2018
,
Mar 30 2018
Brandon has a fix out for Mac. Keeping this bug open until that lands.
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f8a2db374a1297d2831b8c60402e7ac0cceefff commit 5f8a2db374a1297d2831b8c60402e7ac0cceefff Author: btolsch <btolsch@chromium.org> Date: Tue Apr 03 01:43:43 2018 Add basic LocationBarView test for PresentationReceiverWindowView This change also fixes the showing of LocationBarView in PresentationReceiverWindowView on Mac by forcing a call to Layout if its state isn't correct after calling SetFullscreen on the frame. Bug: 809682 Change-Id: Ia7ee354be489354ad65165c6b13e474345e0ffdf Reviewed-on: https://chromium-review.googlesource.com/988269 Reviewed-by: Derek Cheng <imcheng@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#547594} [modify] https://crrev.com/5f8a2db374a1297d2831b8c60402e7ac0cceefff/chrome/browser/ui/views/media_router/presentation_receiver_window_view.cc [rename] https://crrev.com/5f8a2db374a1297d2831b8c60402e7ac0cceefff/chrome/browser/ui/views/media_router/presentation_receiver_window_view_browsertest.cc [modify] https://crrev.com/5f8a2db374a1297d2831b8c60402e7ac0cceefff/chrome/test/BUILD.gn
,
Apr 4 2018
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 Deleted