New issue
Advanced search Search tips

Issue 809676 link

Starred by 1 user
Status: Fixed
Owner:
xingliu@chromium.org
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
Downloads-Framework-Service


Sign in to add a comment

Download service incognito: Public API change for background fetch

Project Member Reported by xingliu@chromium.org, Feb 6 2018 
After background download incognito code is basically done. We need to change the public API to inform background fetch.

Also in background fetch client and some background fetch factory needs minor tweaks to use incognito mode support.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/465bfb2bc857ebfba652dfbb610ab65936d5c33c

commit 465bfb2bc857ebfba652dfbb610ab65936d5c33c
Author: Xing Liu <xingliu@chromium.org>
Date: Thu Mar 15 00:08:39 2018

Download service incognito: Pass BlobDataHandle to client.

This CL passes BlobDataHandle to client, which contains in memory
download data.

The blob data handle is copied through the pipeline. Internally
BlobDataHanle has thread safe reference counting. When the download is
succeeded, InMemoryDownload will be deleted and the client should be
the only holder of the blob data handle.

TBR=jsbell@chromium.org

Bug:  809676 ,766299
Change-Id: I1ec15d10b363b306392574269cbc1e2e15f08004
Reviewed-on: https://chromium-review.googlesource.com/956535
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543247}
[modify] https://crrev.com/465bfb2bc857ebfba652dfbb610ab65936d5c33c/components/download/internal/background_service/controller_impl.cc
[modify] https://crrev.com/465bfb2bc857ebfba652dfbb610ab65936d5c33c/components/download/internal/background_service/driver_entry.h
[modify] https://crrev.com/465bfb2bc857ebfba652dfbb610ab65936d5c33c/components/download/internal/background_service/in_memory_download.cc
[modify] https://crrev.com/465bfb2bc857ebfba652dfbb610ab65936d5c33c/components/download/internal/background_service/in_memory_download.h
[modify] https://crrev.com/465bfb2bc857ebfba652dfbb610ab65936d5c33c/components/download/internal/background_service/in_memory_download_driver.cc
[modify] https://crrev.com/465bfb2bc857ebfba652dfbb610ab65936d5c33c/components/download/internal/background_service/in_memory_download_driver_unittest.cc
[modify] https://crrev.com/465bfb2bc857ebfba652dfbb610ab65936d5c33c/components/download/public/background_service/BUILD.gn
[modify] https://crrev.com/465bfb2bc857ebfba652dfbb610ab65936d5c33c/components/download/public/background_service/DEPS
[modify] https://crrev.com/465bfb2bc857ebfba652dfbb610ab65936d5c33c/components/download/public/background_service/download_metadata.cc
[modify] https://crrev.com/465bfb2bc857ebfba652dfbb610ab65936d5c33c/components/download/public/background_service/download_metadata.h
[modify] https://crrev.com/465bfb2bc857ebfba652dfbb610ab65936d5c33c/components/download/public/background_service/features.cc

Comment 2 by xingliu@chromium.org, Mar 15 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment