Sqlite.Vfs_Events is Overflowing |
||||
Issue descriptionThe Sqlite.Vfs_Events sparse histogram is being incremented so frequently that it sometimes overflows the 31-bit sample count and rolls negative. Desktop does uploads about every 30 minutes (and resets the counters) so whatever events these are, it's happening on the order of 1M times per second on some occasions. https://uma.googleplex.com/p/chrome/histograms/?endDate=20180204&dayCount=1&histograms=Sqlite.Vfs_Events&fixupData=true&showMax=true&filters=channel%2Ceq%2C3%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial
,
Feb 6 2018
These can now be removed since we've punted on Sqlite changes we were planning to make based on these UMA stats. I'll send a CL.
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5f5b8431a0aef97e3f2355dc2e4da82867a600d commit e5f5b8431a0aef97e3f2355dc2e4da82867a600d Author: Maria Khomenko <mariakhomenko@chromium.org> Date: Fri Feb 09 22:41:13 2018 Remove Sqlite VFS histograms. These were added to validate a potential sqlite write improvement, which has since been punted and no one is looking at these metrics. Apparently the values also overflow. Bug: 809658 Change-Id: Iac1da18900ac66c181eb04afc41d4033231ea93b Reviewed-on: https://chromium-review.googlesource.com/905571 Reviewed-by: Victor Costan <pwnall@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#535857} [modify] https://crrev.com/e5f5b8431a0aef97e3f2355dc2e4da82867a600d/sql/vfs_wrapper.cc [modify] https://crrev.com/e5f5b8431a0aef97e3f2355dc2e4da82867a600d/tools/metrics/histograms/enums.xml [modify] https://crrev.com/e5f5b8431a0aef97e3f2355dc2e4da82867a600d/tools/metrics/histograms/histograms.xml
,
Feb 9 2018
,
Jun 29 2018
Still 8 reports from Dev in the past 28 days even though the histograms have been removed. :-) |
||||
►
Sign in to add a comment |
||||
Comment 1 by bcwh...@chromium.org
, Feb 6 2018