fix e2fsk based on gwendal input, change from -y to -p |
|||||
Issue description
View Change
1 comment:
File project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-external-storage-init.conf:
Patch Set #3, Line 25: /sbin/e2fsck -y "${usb_drive}"
-y is usually reserved for user interaction [-p for Automatically repair]. While -y will repair your FS, you allow e2fsck to lose a lot of data.
,
Feb 8 2018
We would need to look into another approach to check the main drive. I did a quick test and found that you can't check a mounted drive. localhost moblab # /sbin/e2fsck -p /dev/sda e2fsck 1.43.6 (29-Aug-2017) /dev/sda is in use. e2fsck: Cannot continue, aborting.
,
Feb 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/7138f3d18d4c5b72d47f434342552f24745faaa6 commit 7138f3d18d4c5b72d47f434342552f24745faaa6 Author: Keith Haddow <haddowk@chromium.org> Date: Sat Feb 17 23:00:02 2018 [moblab] Use auto repair flag for e2fsck on boot Changing the flag used on check disk on boot from -y to -p, which changes the operations run to only those that can be safely fixed without human intervention. BUG= chromium:809655 TEST=tested on a local device and verified that the command /sbin/e2fsck -p /drive/name appeared in the bootup logs Change-Id: I11abffa7326f3c916857dab3591c62d222a90937 Reviewed-on: https://chromium-review.googlesource.com/909529 Commit-Ready: Keith Haddow <haddowk@chromium.org> Tested-by: Keith Haddow <haddowk@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> [modify] https://crrev.com/7138f3d18d4c5b72d47f434342552f24745faaa6/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-external-storage-init.conf
,
Feb 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/7138f3d18d4c5b72d47f434342552f24745faaa6 commit 7138f3d18d4c5b72d47f434342552f24745faaa6 Author: Keith Haddow <haddowk@chromium.org> Date: Sat Feb 17 23:00:02 2018 [moblab] Use auto repair flag for e2fsck on boot Changing the flag used on check disk on boot from -y to -p, which changes the operations run to only those that can be safely fixed without human intervention. BUG= chromium:809655 TEST=tested on a local device and verified that the command /sbin/e2fsck -p /drive/name appeared in the bootup logs Change-Id: I11abffa7326f3c916857dab3591c62d222a90937 Reviewed-on: https://chromium-review.googlesource.com/909529 Commit-Ready: Keith Haddow <haddowk@chromium.org> Tested-by: Keith Haddow <haddowk@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> [modify] https://crrev.com/7138f3d18d4c5b72d47f434342552f24745faaa6/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-external-storage-init.conf
,
Feb 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/5a7eeee9db7c4501a64d35ae611678c649e69c66 commit 5a7eeee9db7c4501a64d35ae611678c649e69c66 Author: Keith Haddow <haddowk@chromium.org> Date: Wed Feb 21 18:59:31 2018 [moblab] Use auto repair flag for e2fsck on boot Changing the flag used on check disk on boot from -y to -p, which changes the operations run to only those that can be safely fixed without human intervention. BUG= chromium:809655 TEST=tested on a local device and verified that the command /sbin/e2fsck -p /drive/name appeared in the bootup logs Change-Id: I11abffa7326f3c916857dab3591c62d222a90937 Reviewed-on: https://chromium-review.googlesource.com/909529 Commit-Ready: Keith Haddow <haddowk@chromium.org> Tested-by: Keith Haddow <haddowk@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> (cherry picked from commit 7138f3d18d4c5b72d47f434342552f24745faaa6) Reviewed-on: https://chromium-review.googlesource.com/929444 Commit-Queue: Matt Mallett <mattmallett@chromium.org> Tested-by: Matt Mallett <mattmallett@chromium.org> Trybot-Ready: Matt Mallett <mattmallett@chromium.org> [modify] https://crrev.com/5a7eeee9db7c4501a64d35ae611678c649e69c66/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-external-storage-init.conf
,
Feb 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/e1b195dbe9f7b7e4b186a63e88d7138bac95e298 commit e1b195dbe9f7b7e4b186a63e88d7138bac95e298 Author: Keith Haddow <haddowk@chromium.org> Date: Wed Feb 21 18:59:34 2018 [moblab] Use auto repair flag for e2fsck on boot Changing the flag used on check disk on boot from -y to -p, which changes the operations run to only those that can be safely fixed without human intervention. BUG= chromium:809655 TEST=tested on a local device and verified that the command /sbin/e2fsck -p /drive/name appeared in the bootup logs Change-Id: I11abffa7326f3c916857dab3591c62d222a90937 Reviewed-on: https://chromium-review.googlesource.com/909529 Commit-Ready: Keith Haddow <haddowk@chromium.org> Tested-by: Keith Haddow <haddowk@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> (cherry picked from commit 7138f3d18d4c5b72d47f434342552f24745faaa6) Reviewed-on: https://chromium-review.googlesource.com/929443 Commit-Queue: Matt Mallett <mattmallett@chromium.org> Tested-by: Matt Mallett <mattmallett@chromium.org> Trybot-Ready: Matt Mallett <mattmallett@chromium.org> [modify] https://crrev.com/e1b195dbe9f7b7e4b186a63e88d7138bac95e298/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-external-storage-init.conf
,
Feb 21 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by haddowk@chromium.org
, Feb 6 2018