Add support for removing users for views-based login
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5716c4163b4e4f99a95f18fdb0ab66a2eb2cadeb commit 5716c4163b4e4f99a95f18fdb0ab66a2eb2cadeb Author: Jacob Dufault <jdufault@google.com> Date: Mon Feb 26 18:57:59 2018 cros: Make sure that user_info can_remove is sent to views-login. Bug: 809637 Change-Id: Ia3f111f1fc3840474be31150a1d3cb2028a28dc7 Reviewed-on: https://chromium-review.googlesource.com/919158 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#539216} [modify] https://crrev.com/5716c4163b4e4f99a95f18fdb0ab66a2eb2cadeb/chrome/browser/chromeos/login/screens/user_selection_screen.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92164ac330c9291b73d7638b79279be69c316380 commit 92164ac330c9291b73d7638b79279be69c316380 Author: Jacob Dufault <jdufault@google.com> Date: Tue Feb 27 19:24:47 2018 cros: Views-login UI for removing a user. Bug: 809637 Change-Id: Id06bf1b73bed7e2338488b68a1702f13582331f0 Reviewed-on: https://chromium-review.googlesource.com/930242 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#539519} [modify] https://crrev.com/92164ac330c9291b73d7638b79279be69c316380/ash/ash_strings.grd [modify] https://crrev.com/92164ac330c9291b73d7638b79279be69c316380/ash/login/ui/hover_notifier.h [modify] https://crrev.com/92164ac330c9291b73d7638b79279be69c316380/ash/login/ui/login_base_bubble_view.cc [modify] https://crrev.com/92164ac330c9291b73d7638b79279be69c316380/ash/login/ui/login_base_bubble_view.h [modify] https://crrev.com/92164ac330c9291b73d7638b79279be69c316380/ash/login/ui/login_bubble.cc [modify] https://crrev.com/92164ac330c9291b73d7638b79279be69c316380/ash/login/ui/login_bubble.h [modify] https://crrev.com/92164ac330c9291b73d7638b79279be69c316380/ash/login/ui/login_bubble_unittest.cc [modify] https://crrev.com/92164ac330c9291b73d7638b79279be69c316380/ash/login/ui/login_user_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f71f33aa748d044212d3a6d224c8f8645bc4b86 commit 3f71f33aa748d044212d3a6d224c8f8645bc4b86 Author: Jacob Dufault <jdufault@google.com> Date: Mon Mar 19 19:40:19 2018 cros: Views login backend for removing users. Bug: 809637 Change-Id: I1eebc6708f52539848d2a38025c087051ced9985 Reviewed-on: https://chromium-review.googlesource.com/935675 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#544128} [modify] https://crrev.com/3f71f33aa748d044212d3a6d224c8f8645bc4b86/ash/login/login_screen_controller.cc [modify] https://crrev.com/3f71f33aa748d044212d3a6d224c8f8645bc4b86/ash/login/login_screen_controller.h [modify] https://crrev.com/3f71f33aa748d044212d3a6d224c8f8645bc4b86/ash/login/mock_login_screen_client.cc [modify] https://crrev.com/3f71f33aa748d044212d3a6d224c8f8645bc4b86/ash/login/mock_login_screen_client.h [modify] https://crrev.com/3f71f33aa748d044212d3a6d224c8f8645bc4b86/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/3f71f33aa748d044212d3a6d224c8f8645bc4b86/ash/login/ui/lock_contents_view.h [modify] https://crrev.com/3f71f33aa748d044212d3a6d224c8f8645bc4b86/ash/login/ui/lock_screen_sanity_unittest.cc [modify] https://crrev.com/3f71f33aa748d044212d3a6d224c8f8645bc4b86/ash/login/ui/login_auth_user_view.cc [modify] https://crrev.com/3f71f33aa748d044212d3a6d224c8f8645bc4b86/ash/login/ui/login_auth_user_view.h [modify] https://crrev.com/3f71f33aa748d044212d3a6d224c8f8645bc4b86/ash/login/ui/login_auth_user_view_unittest.cc [modify] https://crrev.com/3f71f33aa748d044212d3a6d224c8f8645bc4b86/ash/login/ui/login_bubble.cc [modify] https://crrev.com/3f71f33aa748d044212d3a6d224c8f8645bc4b86/ash/login/ui/login_bubble.h [modify] https://crrev.com/3f71f33aa748d044212d3a6d224c8f8645bc4b86/ash/login/ui/login_bubble_unittest.cc [modify] https://crrev.com/3f71f33aa748d044212d3a6d224c8f8645bc4b86/ash/login/ui/login_test_base.h [modify] https://crrev.com/3f71f33aa748d044212d3a6d224c8f8645bc4b86/ash/login/ui/login_test_utils.cc [modify] https://crrev.com/3f71f33aa748d044212d3a6d224c8f8645bc4b86/ash/login/ui/login_test_utils.h [modify] https://crrev.com/3f71f33aa748d044212d3a6d224c8f8645bc4b86/ash/login/ui/login_user_view.cc [modify] https://crrev.com/3f71f33aa748d044212d3a6d224c8f8645bc4b86/ash/login/ui/login_user_view.h [modify] https://crrev.com/3f71f33aa748d044212d3a6d224c8f8645bc4b86/ash/login/ui/login_user_view_unittest.cc [modify] https://crrev.com/3f71f33aa748d044212d3a6d224c8f8645bc4b86/ash/login/ui/scrollable_users_list_view.cc [modify] https://crrev.com/3f71f33aa748d044212d3a6d224c8f8645bc4b86/ash/login/ui/scrollable_users_list_view.h [modify] https://crrev.com/3f71f33aa748d044212d3a6d224c8f8645bc4b86/ash/metrics/login_metrics_recorder_unittest.cc [modify] https://crrev.com/3f71f33aa748d044212d3a6d224c8f8645bc4b86/ash/public/interfaces/login_screen.mojom [modify] https://crrev.com/3f71f33aa748d044212d3a6d224c8f8645bc4b86/chrome/browser/ui/ash/login_screen_client.cc [modify] https://crrev.com/3f71f33aa748d044212d3a6d224c8f8645bc4b86/chrome/browser/ui/ash/login_screen_client.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e824a20658cfbf90f44439df7314d590cdcd533 commit 6e824a20658cfbf90f44439df7314d590cdcd533 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Mon Mar 19 23:46:11 2018 Revert "cros: Views login backend for removing users." This reverts commit 3f71f33aa748d044212d3a6d224c8f8645bc4b86. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 544128 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzNmNzFmMzNhYTc0OGQwNDQyMTJkM2E2ZDIyNGM4Zjg2NDViYzRiODYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/26652 Sample Failed Step: mus_ash_unittests Original change's description: > cros: Views login backend for removing users. > > Bug: 809637 > Change-Id: I1eebc6708f52539848d2a38025c087051ced9985 > Reviewed-on: https://chromium-review.googlesource.com/935675 > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544128} Change-Id: Ic583e23c993c1dddbf1965088a2b685093c610ca No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 809637 Reviewed-on: https://chromium-review.googlesource.com/969228 Cr-Commit-Position: refs/heads/master@{#544212} [modify] https://crrev.com/6e824a20658cfbf90f44439df7314d590cdcd533/ash/login/login_screen_controller.cc [modify] https://crrev.com/6e824a20658cfbf90f44439df7314d590cdcd533/ash/login/login_screen_controller.h [modify] https://crrev.com/6e824a20658cfbf90f44439df7314d590cdcd533/ash/login/mock_login_screen_client.cc [modify] https://crrev.com/6e824a20658cfbf90f44439df7314d590cdcd533/ash/login/mock_login_screen_client.h [modify] https://crrev.com/6e824a20658cfbf90f44439df7314d590cdcd533/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/6e824a20658cfbf90f44439df7314d590cdcd533/ash/login/ui/lock_contents_view.h [modify] https://crrev.com/6e824a20658cfbf90f44439df7314d590cdcd533/ash/login/ui/lock_screen_sanity_unittest.cc [modify] https://crrev.com/6e824a20658cfbf90f44439df7314d590cdcd533/ash/login/ui/login_auth_user_view.cc [modify] https://crrev.com/6e824a20658cfbf90f44439df7314d590cdcd533/ash/login/ui/login_auth_user_view.h [modify] https://crrev.com/6e824a20658cfbf90f44439df7314d590cdcd533/ash/login/ui/login_auth_user_view_unittest.cc [modify] https://crrev.com/6e824a20658cfbf90f44439df7314d590cdcd533/ash/login/ui/login_bubble.cc [modify] https://crrev.com/6e824a20658cfbf90f44439df7314d590cdcd533/ash/login/ui/login_bubble.h [modify] https://crrev.com/6e824a20658cfbf90f44439df7314d590cdcd533/ash/login/ui/login_bubble_unittest.cc [modify] https://crrev.com/6e824a20658cfbf90f44439df7314d590cdcd533/ash/login/ui/login_test_base.h [modify] https://crrev.com/6e824a20658cfbf90f44439df7314d590cdcd533/ash/login/ui/login_test_utils.cc [modify] https://crrev.com/6e824a20658cfbf90f44439df7314d590cdcd533/ash/login/ui/login_test_utils.h [modify] https://crrev.com/6e824a20658cfbf90f44439df7314d590cdcd533/ash/login/ui/login_user_view.cc [modify] https://crrev.com/6e824a20658cfbf90f44439df7314d590cdcd533/ash/login/ui/login_user_view.h [modify] https://crrev.com/6e824a20658cfbf90f44439df7314d590cdcd533/ash/login/ui/login_user_view_unittest.cc [modify] https://crrev.com/6e824a20658cfbf90f44439df7314d590cdcd533/ash/login/ui/scrollable_users_list_view.cc [modify] https://crrev.com/6e824a20658cfbf90f44439df7314d590cdcd533/ash/login/ui/scrollable_users_list_view.h [modify] https://crrev.com/6e824a20658cfbf90f44439df7314d590cdcd533/ash/metrics/login_metrics_recorder_unittest.cc [modify] https://crrev.com/6e824a20658cfbf90f44439df7314d590cdcd533/ash/public/interfaces/login_screen.mojom [modify] https://crrev.com/6e824a20658cfbf90f44439df7314d590cdcd533/chrome/browser/ui/ash/login_screen_client.cc [modify] https://crrev.com/6e824a20658cfbf90f44439df7314d590cdcd533/chrome/browser/ui/ash/login_screen_client.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc31c749f64ca05d8075f7410aa654c45b6bf523 commit fc31c749f64ca05d8075f7410aa654c45b6bf523 Author: Jacob Dufault <jdufault@google.com> Date: Tue Mar 20 17:32:19 2018 Reland cros: Views login backend for removing users. Relands https://chromium-review.googlesource.com/c/chromium/src/+/935675. It was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/969228 TBR: xiyuan@chromium.org TBR: dcheng@chromium.org Bug: 809637 Change-Id: I9e44d96cbe26bc090e177460e18542b8b4d387b2 Reviewed-on: https://chromium-review.googlesource.com/971161 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#544423} [modify] https://crrev.com/fc31c749f64ca05d8075f7410aa654c45b6bf523/ash/login/login_screen_controller.cc [modify] https://crrev.com/fc31c749f64ca05d8075f7410aa654c45b6bf523/ash/login/login_screen_controller.h [modify] https://crrev.com/fc31c749f64ca05d8075f7410aa654c45b6bf523/ash/login/mock_login_screen_client.cc [modify] https://crrev.com/fc31c749f64ca05d8075f7410aa654c45b6bf523/ash/login/mock_login_screen_client.h [modify] https://crrev.com/fc31c749f64ca05d8075f7410aa654c45b6bf523/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/fc31c749f64ca05d8075f7410aa654c45b6bf523/ash/login/ui/lock_contents_view.h [modify] https://crrev.com/fc31c749f64ca05d8075f7410aa654c45b6bf523/ash/login/ui/lock_screen_sanity_unittest.cc [modify] https://crrev.com/fc31c749f64ca05d8075f7410aa654c45b6bf523/ash/login/ui/login_auth_user_view.cc [modify] https://crrev.com/fc31c749f64ca05d8075f7410aa654c45b6bf523/ash/login/ui/login_auth_user_view.h [modify] https://crrev.com/fc31c749f64ca05d8075f7410aa654c45b6bf523/ash/login/ui/login_auth_user_view_unittest.cc [modify] https://crrev.com/fc31c749f64ca05d8075f7410aa654c45b6bf523/ash/login/ui/login_bubble.cc [modify] https://crrev.com/fc31c749f64ca05d8075f7410aa654c45b6bf523/ash/login/ui/login_bubble.h [modify] https://crrev.com/fc31c749f64ca05d8075f7410aa654c45b6bf523/ash/login/ui/login_bubble_unittest.cc [modify] https://crrev.com/fc31c749f64ca05d8075f7410aa654c45b6bf523/ash/login/ui/login_test_base.h [modify] https://crrev.com/fc31c749f64ca05d8075f7410aa654c45b6bf523/ash/login/ui/login_test_utils.cc [modify] https://crrev.com/fc31c749f64ca05d8075f7410aa654c45b6bf523/ash/login/ui/login_test_utils.h [modify] https://crrev.com/fc31c749f64ca05d8075f7410aa654c45b6bf523/ash/login/ui/login_user_view.cc [modify] https://crrev.com/fc31c749f64ca05d8075f7410aa654c45b6bf523/ash/login/ui/login_user_view.h [modify] https://crrev.com/fc31c749f64ca05d8075f7410aa654c45b6bf523/ash/login/ui/login_user_view_unittest.cc [modify] https://crrev.com/fc31c749f64ca05d8075f7410aa654c45b6bf523/ash/login/ui/scrollable_users_list_view.cc [modify] https://crrev.com/fc31c749f64ca05d8075f7410aa654c45b6bf523/ash/login/ui/scrollable_users_list_view.h [modify] https://crrev.com/fc31c749f64ca05d8075f7410aa654c45b6bf523/ash/metrics/login_metrics_recorder_unittest.cc [modify] https://crrev.com/fc31c749f64ca05d8075f7410aa654c45b6bf523/ash/public/interfaces/login_screen.mojom [modify] https://crrev.com/fc31c749f64ca05d8075f7410aa654c45b6bf523/chrome/browser/ui/ash/login_screen_client.cc [modify] https://crrev.com/fc31c749f64ca05d8075f7410aa654c45b6bf523/chrome/browser/ui/ash/login_screen_client.h
Comment 1 by ovanieva@chromium.org
, Feb 23 2018