New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 809635 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug


Participants' hotlists:
LoginRefresh


Sign in to add a comment

Add support for public session on views-based login

Project Member Reported by jdufault@chromium.org, Feb 6 2018

Issue description

We currently lack any UI for this.

Also see  issue 732452 .
 
Components: UI>Shell>StartScreen
The work includes 
1. Add mojo api for chrome to send public session info to LockContentsView in ash. CL: https://chromium-review.googlesource.com/c/chromium/src/+/941516

2. UI change for LoginUserView to display enterprise domain.
CL: https://chromium-review.googlesource.com/c/chromium/src/+/945133

3. UI change for add big user view for public session user.
CL:  https://chromium-review.googlesource.com/c/chromium/src/+/940623

4. UI change for the expanded public session user view.
Work in progress.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4cbba88dde0b6b4293d9f7c080a7dca5eea7b95

commit f4cbba88dde0b6b4293d9f7c080a7dca5eea7b95
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Wed Mar 07 01:34:12 2018

Add mojo api for public session information

Add the following mojo api for chrome to send public session information
to LockContentsView in ash.
1. SetPublicSessionDisplayName
2. SetPublicSessionLocales

These api will be used in a follow-up CL:
https://chromium-review.googlesource.com/c/chromium/src/+/940623

Bug:  809635 
Change-Id: I7b83d7188155c4c8547e8fef91aa53121dc760b3
Reviewed-on: https://chromium-review.googlesource.com/941516
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541269}
[modify] https://crrev.com/f4cbba88dde0b6b4293d9f7c080a7dca5eea7b95/ash/login/login_screen_controller.cc
[modify] https://crrev.com/f4cbba88dde0b6b4293d9f7c080a7dca5eea7b95/ash/login/login_screen_controller.h
[modify] https://crrev.com/f4cbba88dde0b6b4293d9f7c080a7dca5eea7b95/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/f4cbba88dde0b6b4293d9f7c080a7dca5eea7b95/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/f4cbba88dde0b6b4293d9f7c080a7dca5eea7b95/ash/login/ui/login_data_dispatcher.cc
[modify] https://crrev.com/f4cbba88dde0b6b4293d9f7c080a7dca5eea7b95/ash/login/ui/login_data_dispatcher.h
[modify] https://crrev.com/f4cbba88dde0b6b4293d9f7c080a7dca5eea7b95/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/f4cbba88dde0b6b4293d9f7c080a7dca5eea7b95/chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc
[modify] https://crrev.com/f4cbba88dde0b6b4293d9f7c080a7dca5eea7b95/chrome/browser/chromeos/login/screens/chrome_user_selection_screen.h
[modify] https://crrev.com/f4cbba88dde0b6b4293d9f7c080a7dca5eea7b95/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/f4cbba88dde0b6b4293d9f7c080a7dca5eea7b95/chrome/browser/chromeos/login/screens/user_selection_screen.h
[modify] https://crrev.com/f4cbba88dde0b6b4293d9f7c080a7dca5eea7b95/chrome/browser/chromeos/login/ui/login_display_views.cc
[modify] https://crrev.com/f4cbba88dde0b6b4293d9f7c080a7dca5eea7b95/chrome/browser/chromeos/login/user_selection_screen_proxy.cc
[modify] https://crrev.com/f4cbba88dde0b6b4293d9f7c080a7dca5eea7b95/chrome/browser/chromeos/login/user_selection_screen_proxy.h
[modify] https://crrev.com/f4cbba88dde0b6b4293d9f7c080a7dca5eea7b95/chrome/browser/ui/ash/login_screen_client.cc
[modify] https://crrev.com/f4cbba88dde0b6b4293d9f7c080a7dca5eea7b95/chrome/browser/ui/ash/login_screen_client.h

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4dea4d2f2e1d55841982b0238463b203f836167

commit c4dea4d2f2e1d55841982b0238463b203f836167
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Wed Mar 07 01:38:37 2018

Add domain info in the LoginUserView

Domain info is displayed for public account user in the login screen.
This CL adds domain info UI in the LoginUserView.

This is split from the following CL which will use this piece of UI:
https://chromium-review.googlesource.com/c/chromium/src/+/940623/

Bug:  809635 
Change-Id: I7efdd946817d9111597f404eaaa3b3a83140a309
Reviewed-on: https://chromium-review.googlesource.com/945133
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541277}
[modify] https://crrev.com/c4dea4d2f2e1d55841982b0238463b203f836167/ash/ash_strings.grd
[modify] https://crrev.com/c4dea4d2f2e1d55841982b0238463b203f836167/ash/login/ui/login_auth_user_view.cc
[modify] https://crrev.com/c4dea4d2f2e1d55841982b0238463b203f836167/ash/login/ui/login_user_view.cc
[modify] https://crrev.com/c4dea4d2f2e1d55841982b0238463b203f836167/ash/login/ui/login_user_view.h
[modify] https://crrev.com/c4dea4d2f2e1d55841982b0238463b203f836167/ash/login/ui/login_user_view_unittest.cc
[modify] https://crrev.com/c4dea4d2f2e1d55841982b0238463b203f836167/ash/login/ui/scrollable_users_list_view.cc
[modify] https://crrev.com/c4dea4d2f2e1d55841982b0238463b203f836167/ash/resources/vector_icons/BUILD.gn
[add] https://crrev.com/c4dea4d2f2e1d55841982b0238463b203f836167/ash/resources/vector_icons/login_screen_enterprise.1x.icon
[add] https://crrev.com/c4dea4d2f2e1d55841982b0238463b203f836167/ash/resources/vector_icons/login_screen_enterprise.icon

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/947f48c5081f76eb4345efa90c9e011c31bbce01

commit 947f48c5081f76eb4345efa90c9e011c31bbce01
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Thu Mar 22 20:28:02 2018

Add UI for public account user in login screen (part 1)

This CL does the following:
1. Add LoginBigUserView as the container view for LoginAuthUserView
   and LoginPublicAccountUserView.
   LoginAuthUserView is the authentication view for regular users which
   includes special view like LoginPasswordView and LoginPinView.
   LoginPublicAccountUserView is the authentication view for public
   account users which includes a special arrow button view.
   Both LoginAuthUserView and LoginPublicAccountUserView have
   LoginUserView, the latter has domain info after the user name.

2. Add some UI elements for the public session UI. Like ArrowButtonView

Bug:  809635 
Change-Id: Ic4081de21d77559f603b0e13ee2141b293e013db
Reviewed-on: https://chromium-review.googlesource.com/940623
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545226}
[modify] https://crrev.com/947f48c5081f76eb4345efa90c9e011c31bbce01/ash/BUILD.gn
[add] https://crrev.com/947f48c5081f76eb4345efa90c9e011c31bbce01/ash/login/ui/arrow_button_view.cc
[add] https://crrev.com/947f48c5081f76eb4345efa90c9e011c31bbce01/ash/login/ui/arrow_button_view.h
[modify] https://crrev.com/947f48c5081f76eb4345efa90c9e011c31bbce01/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/947f48c5081f76eb4345efa90c9e011c31bbce01/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/947f48c5081f76eb4345efa90c9e011c31bbce01/ash/login/ui/lock_contents_view_unittest.cc
[modify] https://crrev.com/947f48c5081f76eb4345efa90c9e011c31bbce01/ash/login/ui/lock_screen_sanity_unittest.cc
[modify] https://crrev.com/947f48c5081f76eb4345efa90c9e011c31bbce01/ash/login/ui/lock_window_unittest.cc
[modify] https://crrev.com/947f48c5081f76eb4345efa90c9e011c31bbce01/ash/login/ui/login_auth_user_view.cc
[modify] https://crrev.com/947f48c5081f76eb4345efa90c9e011c31bbce01/ash/login/ui/login_auth_user_view.h
[add] https://crrev.com/947f48c5081f76eb4345efa90c9e011c31bbce01/ash/login/ui/login_big_user_view.cc
[add] https://crrev.com/947f48c5081f76eb4345efa90c9e011c31bbce01/ash/login/ui/login_big_user_view.h
[add] https://crrev.com/947f48c5081f76eb4345efa90c9e011c31bbce01/ash/login/ui/login_public_account_user_view.cc
[add] https://crrev.com/947f48c5081f76eb4345efa90c9e011c31bbce01/ash/login/ui/login_public_account_user_view.h
[modify] https://crrev.com/947f48c5081f76eb4345efa90c9e011c31bbce01/ash/login/ui/login_test_base.cc
[modify] https://crrev.com/947f48c5081f76eb4345efa90c9e011c31bbce01/ash/login/ui/login_test_base.h
[modify] https://crrev.com/947f48c5081f76eb4345efa90c9e011c31bbce01/ash/login/ui/login_test_utils.cc
[modify] https://crrev.com/947f48c5081f76eb4345efa90c9e011c31bbce01/ash/login/ui/login_test_utils.h
[modify] https://crrev.com/947f48c5081f76eb4345efa90c9e011c31bbce01/ash/login/ui/login_user_view.cc
[modify] https://crrev.com/947f48c5081f76eb4345efa90c9e011c31bbce01/ash/login/ui/scrollable_users_list_view.cc
[modify] https://crrev.com/947f48c5081f76eb4345efa90c9e011c31bbce01/ash/login/ui/scrollable_users_list_view.h
[modify] https://crrev.com/947f48c5081f76eb4345efa90c9e011c31bbce01/ash/metrics/login_metrics_recorder_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fcf9f852134febae6c871c664e232bc0c3e1625

commit 3fcf9f852134febae6c871c664e232bc0c3e1625
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Thu Mar 22 20:32:54 2018

Mojo API for launching the public session

This CL includes:
1. Add mojo api for launching the public session.
2. Preload the webui for the post login screens.

Bug:  809635 
Change-Id: I8b3e3877f250ea193ec6a49f90f6a0f275bafbaf
Reviewed-on: https://chromium-review.googlesource.com/957309
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545233}
[modify] https://crrev.com/3fcf9f852134febae6c871c664e232bc0c3e1625/ash/login/login_screen_controller.cc
[modify] https://crrev.com/3fcf9f852134febae6c871c664e232bc0c3e1625/ash/login/login_screen_controller.h
[modify] https://crrev.com/3fcf9f852134febae6c871c664e232bc0c3e1625/ash/login/mock_login_screen_client.h
[modify] https://crrev.com/3fcf9f852134febae6c871c664e232bc0c3e1625/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/3fcf9f852134febae6c871c664e232bc0c3e1625/chrome/browser/chromeos/login/lock/views_screen_locker.cc
[modify] https://crrev.com/3fcf9f852134febae6c871c664e232bc0c3e1625/chrome/browser/chromeos/login/lock/views_screen_locker.h
[modify] https://crrev.com/3fcf9f852134febae6c871c664e232bc0c3e1625/chrome/browser/chromeos/login/ui/gaia_dialog_delegate.cc
[modify] https://crrev.com/3fcf9f852134febae6c871c664e232bc0c3e1625/chrome/browser/chromeos/login/ui/gaia_dialog_delegate.h
[modify] https://crrev.com/3fcf9f852134febae6c871c664e232bc0c3e1625/chrome/browser/chromeos/login/ui/login_display_host_views.cc
[modify] https://crrev.com/3fcf9f852134febae6c871c664e232bc0c3e1625/chrome/browser/chromeos/login/ui/login_display_host_views.h
[modify] https://crrev.com/3fcf9f852134febae6c871c664e232bc0c3e1625/chrome/browser/ui/ash/login_screen_client.cc
[modify] https://crrev.com/3fcf9f852134febae6c871c664e232bc0c3e1625/chrome/browser/ui/ash/login_screen_client.h

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7de02fd32925ff213bbbac81ca25508ddd206dbb

commit 7de02fd32925ff213bbbac81ca25508ddd206dbb
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Thu Apr 12 18:22:56 2018

Create expanded public session view.

This CL includes the following:
1. Create an expanded public session view which wraps a LoginUserView
, a submit button to enter the public session and two drop down menus
for user to select language and keyboard settings. The views for the
menus will be in a follow-up CL.

2. When the expanded view is shown, other views like big user view,
user list and top header view will be hidden in the login screen.
The expanded view will be dismissed by escape key or click outside its
bounds.


Bug:  809635 
Change-Id: Iac0a842a98e6eacd15bf9e91756e512f0d5dd364
Reviewed-on: https://chromium-review.googlesource.com/977230
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550277}
[modify] https://crrev.com/7de02fd32925ff213bbbac81ca25508ddd206dbb/ash/BUILD.gn
[modify] https://crrev.com/7de02fd32925ff213bbbac81ca25508ddd206dbb/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/7de02fd32925ff213bbbac81ca25508ddd206dbb/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/7de02fd32925ff213bbbac81ca25508ddd206dbb/ash/login/ui/lock_contents_view_unittest.cc
[add] https://crrev.com/7de02fd32925ff213bbbac81ca25508ddd206dbb/ash/login/ui/login_expanded_public_account_view.cc
[add] https://crrev.com/7de02fd32925ff213bbbac81ca25508ddd206dbb/ash/login/ui/login_expanded_public_account_view.h
[add] https://crrev.com/7de02fd32925ff213bbbac81ca25508ddd206dbb/ash/login/ui/login_expanded_public_account_view_unittest.cc
[modify] https://crrev.com/7de02fd32925ff213bbbac81ca25508ddd206dbb/ash/login/ui/login_public_account_user_view.cc
[modify] https://crrev.com/7de02fd32925ff213bbbac81ca25508ddd206dbb/ash/login/ui/login_user_view.cc
[modify] https://crrev.com/7de02fd32925ff213bbbac81ca25508ddd206dbb/ash/login/ui/login_user_view.h
[modify] https://crrev.com/7de02fd32925ff213bbbac81ca25508ddd206dbb/ash/resources/vector_icons/BUILD.gn
[add] https://crrev.com/7de02fd32925ff213bbbac81ca25508ddd206dbb/ash/resources/vector_icons/login_screen_button_dropdown.icon
[add] https://crrev.com/7de02fd32925ff213bbbac81ca25508ddd206dbb/ash/resources/vector_icons/login_screen_menu_dropdown.icon

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7de02fd32925ff213bbbac81ca25508ddd206dbb

commit 7de02fd32925ff213bbbac81ca25508ddd206dbb
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Thu Apr 12 18:22:56 2018

Create expanded public session view.

This CL includes the following:
1. Create an expanded public session view which wraps a LoginUserView
, a submit button to enter the public session and two drop down menus
for user to select language and keyboard settings. The views for the
menus will be in a follow-up CL.

2. When the expanded view is shown, other views like big user view,
user list and top header view will be hidden in the login screen.
The expanded view will be dismissed by escape key or click outside its
bounds.


Bug:  809635 
Change-Id: Iac0a842a98e6eacd15bf9e91756e512f0d5dd364
Reviewed-on: https://chromium-review.googlesource.com/977230
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550277}
[modify] https://crrev.com/7de02fd32925ff213bbbac81ca25508ddd206dbb/ash/BUILD.gn
[modify] https://crrev.com/7de02fd32925ff213bbbac81ca25508ddd206dbb/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/7de02fd32925ff213bbbac81ca25508ddd206dbb/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/7de02fd32925ff213bbbac81ca25508ddd206dbb/ash/login/ui/lock_contents_view_unittest.cc
[add] https://crrev.com/7de02fd32925ff213bbbac81ca25508ddd206dbb/ash/login/ui/login_expanded_public_account_view.cc
[add] https://crrev.com/7de02fd32925ff213bbbac81ca25508ddd206dbb/ash/login/ui/login_expanded_public_account_view.h
[add] https://crrev.com/7de02fd32925ff213bbbac81ca25508ddd206dbb/ash/login/ui/login_expanded_public_account_view_unittest.cc
[modify] https://crrev.com/7de02fd32925ff213bbbac81ca25508ddd206dbb/ash/login/ui/login_public_account_user_view.cc
[modify] https://crrev.com/7de02fd32925ff213bbbac81ca25508ddd206dbb/ash/login/ui/login_user_view.cc
[modify] https://crrev.com/7de02fd32925ff213bbbac81ca25508ddd206dbb/ash/login/ui/login_user_view.h
[modify] https://crrev.com/7de02fd32925ff213bbbac81ca25508ddd206dbb/ash/resources/vector_icons/BUILD.gn
[add] https://crrev.com/7de02fd32925ff213bbbac81ca25508ddd206dbb/ash/resources/vector_icons/login_screen_button_dropdown.icon
[add] https://crrev.com/7de02fd32925ff213bbbac81ca25508ddd206dbb/ash/resources/vector_icons/login_screen_menu_dropdown.icon

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9affb122dbbda951f1fdb6b988e7ec7ad782630

commit f9affb122dbbda951f1fdb6b988e7ec7ad782630
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Fri Apr 27 21:36:36 2018

Mojo api for requesting keyboard layouts for public account user.

The requested keyboard layouts will be used in public session UI to
populate a selection menu. (In a follow-up CL)

Bug:  809635 
Change-Id: I1154647d4bfdf3637ec37033f4452742c71ec377
Reviewed-on: https://chromium-review.googlesource.com/1020664
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554517}
[modify] https://crrev.com/f9affb122dbbda951f1fdb6b988e7ec7ad782630/ash/login/login_screen_controller.cc
[modify] https://crrev.com/f9affb122dbbda951f1fdb6b988e7ec7ad782630/ash/login/login_screen_controller.h
[modify] https://crrev.com/f9affb122dbbda951f1fdb6b988e7ec7ad782630/ash/login/mock_login_screen_client.h
[modify] https://crrev.com/f9affb122dbbda951f1fdb6b988e7ec7ad782630/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/f9affb122dbbda951f1fdb6b988e7ec7ad782630/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/f9affb122dbbda951f1fdb6b988e7ec7ad782630/ash/login/ui/lock_debug_view.cc
[modify] https://crrev.com/f9affb122dbbda951f1fdb6b988e7ec7ad782630/ash/login/ui/login_data_dispatcher.cc
[modify] https://crrev.com/f9affb122dbbda951f1fdb6b988e7ec7ad782630/ash/login/ui/login_data_dispatcher.h
[modify] https://crrev.com/f9affb122dbbda951f1fdb6b988e7ec7ad782630/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/f9affb122dbbda951f1fdb6b988e7ec7ad782630/ash/public/interfaces/login_user_info.mojom
[modify] https://crrev.com/f9affb122dbbda951f1fdb6b988e7ec7ad782630/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/f9affb122dbbda951f1fdb6b988e7ec7ad782630/chrome/browser/chromeos/login/screens/user_selection_screen.h
[modify] https://crrev.com/f9affb122dbbda951f1fdb6b988e7ec7ad782630/chrome/browser/chromeos/login/user_board_view_mojo.cc
[modify] https://crrev.com/f9affb122dbbda951f1fdb6b988e7ec7ad782630/chrome/browser/ui/ash/login_screen_client.cc
[modify] https://crrev.com/f9affb122dbbda951f1fdb6b988e7ec7ad782630/chrome/browser/ui/ash/login_screen_client.h

Project Member

Comment 10 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b12b2d3be5930b849f92577db5cb00d5ce092f45

commit b12b2d3be5930b849f92577db5cb00d5ce092f45
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Thu May 03 21:00:48 2018

Create menu view for public account user.

Bug:  809635 
Change-Id: Ifd6e73c24c0994f551442ce2d21355829e5454dd
Reviewed-on: https://chromium-review.googlesource.com/1022257
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555866}
[modify] https://crrev.com/b12b2d3be5930b849f92577db5cb00d5ce092f45/ash/BUILD.gn
[modify] https://crrev.com/b12b2d3be5930b849f92577db5cb00d5ce092f45/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/b12b2d3be5930b849f92577db5cb00d5ce092f45/ash/login/ui/lock_screen_sanity_unittest.cc
[modify] https://crrev.com/b12b2d3be5930b849f92577db5cb00d5ce092f45/ash/login/ui/login_bubble.cc
[modify] https://crrev.com/b12b2d3be5930b849f92577db5cb00d5ce092f45/ash/login/ui/login_bubble.h
[modify] https://crrev.com/b12b2d3be5930b849f92577db5cb00d5ce092f45/ash/login/ui/login_bubble_unittest.cc
[modify] https://crrev.com/b12b2d3be5930b849f92577db5cb00d5ce092f45/ash/login/ui/login_expanded_public_account_view.cc
[modify] https://crrev.com/b12b2d3be5930b849f92577db5cb00d5ce092f45/ash/login/ui/login_expanded_public_account_view.h
[add] https://crrev.com/b12b2d3be5930b849f92577db5cb00d5ce092f45/ash/login/ui/login_menu_view.cc
[add] https://crrev.com/b12b2d3be5930b849f92577db5cb00d5ce092f45/ash/login/ui/login_menu_view.h

When I try to use the views-based log-in screen for a public session, the Terms of Service doesn't load correctly ("Oops, something went wrong") and the log-in screen goes back to the initial view.

You have to specify a ToS in the admin console to have the ToS screen show up.
Re#11: Thanks Michael. Does the webui version load ToS screen correctly? 
Labels: ReleaseBlock-Stable
Status: Fixed (was: Assigned)

Sign in to add a comment