Issue metadata
Sign in to add a comment
|
hterm: X10 legacy mouse reporting broken |
||||||||||||||||||||
Issue descriptionwhile trying to fix SGR mouse reporting for tmux [1], it seems the change broke X10 legacy mouse reporting. rather than just patch it up again, need to go through the xterm source (and perhaps vim/tmux) to see what the X10 protocol looks like. the xterm docs [2] themselves don't say that 32 should be added, but it looks like it does just that in the source [3]. [1] https://chromium-review.googlesource.com/826008 [2] https://invisible-island.net/xterm/ctlseqs/ctlseqs.html#h2-Mouse-Tracking [3] https://github.com/ThomasDickey/xterm-snapshots/blob/3a481325dc7719e20ee28a38e61f439e5dcb31f5/button.c#L4582 [3] https://github.com/ThomasDickey/xterm-snapshots/blob/3a481325dc7719e20ee28a38e61f439e5dcb31f5/button.c#L4626
,
Feb 12 2018
Issue 810450 has been merged into this issue.
,
Jun 14 2018
Issue 852712 has been merged into this issue.
,
Jun 14 2018
for vim users, you probably want to `set ttymouse=sgr`: http://vimhelp.appspot.com/options.txt.html#%27ttymouse%27
,
Jun 18 2018
this is fixed in hterm-1.79+ and nassh-0.8.44+
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/apps/libapps/+/b418e218afff548921789570060f37f250160ccc commit b418e218afff548921789570060f37f250160ccc Author: Mike Frysinger <vapier@chromium.org> Date: Mon Jun 18 19:08:09 2018 hterm: unbreak legacy mouse wheel encoding In commit 31e9ece54c0013c84ceaf5d849edcc12bbdec06c ("hterm: fix typo in mouse wheel reporting"), we fixed SGR mouse encoding, but we also break legacy mouse encoding. The reason for the extra 32 wasn't in the comments here (like it was for the other sections), so it was a bit too easy to miss. Re-add for legacy, add an explicit comment, and fill our the mouse reporting & encoding sections of our docs. Hopefully this should prevent future regressions. And tests! BUG= chromium:809628 Change-Id: I17305e3be287ba6b6268a650076c706edf2e943b Reviewed-on: https://chromium-review.googlesource.com/928844 Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Vitaliy Shipitsyn <vsh@google.com> [modify] https://crrev.com/b418e218afff548921789570060f37f250160ccc/hterm/js/hterm_vt_tests.js [modify] https://crrev.com/b418e218afff548921789570060f37f250160ccc/hterm/doc/ControlSequences.md [modify] https://crrev.com/b418e218afff548921789570060f37f250160ccc/hterm/js/hterm_vt.js |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 Deleted