New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 809613 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in blink::MediaAttributeMatches

Project Member Reported by ClusterFuzz, Feb 6 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6231504766894080

Fuzzer: libFuzzer_html_preload_scanner_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  blink::MediaAttributeMatches
  void blink::TokenPreloadScanner::StartTagScanner::ProcessLinkAttribute<WTF::Atom
  blink::HTMLPreloadScanner::Scan
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=534492:534497

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6231504766894080

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Feb 6 2018

Components: Blink>HTML>Parser
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Feb 6 2018

Labels: Test-Predator-Auto-Owner
Owner: vollick@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/31c3e8642532f753ab688445c7093012dba3f8f1 ([vr] Add not-web-exposed media feature for immersive mode.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Labels: M-66
Needs
	immersive_mode(false),

inside the MediaValuesCached::MediaValuesCachedData::MediaValuesCachedData() member initialization list?
Status: Fixed (was: Assigned)
The offending change has already been reverted.
Cc: vollick@google.com rbyers@chromium.org
Proper fix is up here (https://chromium-review.googlesource.com/c/chromium/src/+/905782), though I'm currently having troubles reproducing. clusterfuzz is telling me that vollick@google.com doesn't have access to the test case.
Looks like cc'ing vollick@google.com fixed my repro issue and I think that the posted fix (which makes the change elawrence@ suggested) addresses the problem.
Project Member

Comment 9 by ClusterFuzz, Feb 7 2018

ClusterFuzz has detected this issue as fixed in range 534724:534740.

Detailed report: https://clusterfuzz.com/testcase?key=6231504766894080

Fuzzer: libFuzzer_html_preload_scanner_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  blink::MediaAttributeMatches
  void blink::TokenPreloadScanner::StartTagScanner::ProcessLinkAttribute<WTF::Atom
  blink::HTMLPreloadScanner::Scan
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=534492:534497
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=534724:534740

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6231504766894080

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Feb 7 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6231504766894080 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by sheriffbot@chromium.org, Feb 8 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 12 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 13 by sheriffbot@chromium.org, May 16 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by sheriffbot@chromium.org, Jul 28

Labels: Pri-1

Sign in to add a comment