New issue
Advanced search Search tips

Issue 809610 link

Starred by 1 user
Status: Fixed
Owner:
sdefresne@chromium.org
Closed: Oct 26
Cc:
pkasting@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 3
Type: Task



Sign in to add a comment

KeyedServiceFactory/RefcountedKeyedServiceFactory should not use std::function

Project Member Reported by carlosk@chromium.org, Feb 6 2018 
C++11's Function Objects (std::function) construct are not allowed in Chromium code [1] and their use in KeyedServiceFactory and RefcountedKeyedServiceFactory should be eliminated.

[1] https://chromium-cpp.appspot.com/#library-blacklist
Showing comments 28 - 127 of 127 Older ›
Project Member

Comment 28 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18512e23fa782ed67e0beb72d032c1956de8e92e

commit 18512e23fa782ed67e0beb72d032c1956de8e92e
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 10:28:36 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui.

This CL was uploaded by git cl split.

R=ellyjones@chromium.org

Bug:  809610 
Change-Id: I646b188142ae4695eb7810f8f78bc50fa19417a0
Reviewed-on: https://chromium-review.googlesource.com/c/1259005
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596575}
[modify] https://crrev.com/18512e23fa782ed67e0beb72d032c1956de8e92e/chrome/browser/ui/bookmarks/bookmark_unittest.cc
[modify] https://crrev.com/18512e23fa782ed67e0beb72d032c1956de8e92e/chrome/browser/ui/browser_close_unittest.cc
[modify] https://crrev.com/18512e23fa782ed67e0beb72d032c1956de8e92e/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
[modify] https://crrev.com/18512e23fa782ed67e0beb72d032c1956de8e92e/chrome/browser/ui/toolbar/toolbar_model_unittest.cc
Project Member

Comment 29 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01b771b2621375700611abcf75c793562b44c41d

commit 01b771b2621375700611abcf75c793562b44c41d
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 10:47:24 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/autofill.

This CL was uploaded by git cl split.

R=estade@chromium.org

Bug:  809610 
Change-Id: I9120558e0313fcc16cfeef3f9f01d032346abd52
Reviewed-on: https://chromium-review.googlesource.com/c/1257936
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596578}
[modify] https://crrev.com/01b771b2621375700611abcf75c793562b44c41d/chrome/browser/autofill/autofill_save_card_infobar_delegate_mobile_unittest.cc
Project Member

Comment 30 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/865e784661f0fdea6edeeb1fb88d4f1fa484d97e

commit 865e784661f0fdea6edeeb1fb88d4f1fa484d97e
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 10:51:51 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/notifications.

This CL was uploaded by git cl split.

R=dewittj@chromium.org

Bug:  809610 
Change-Id: Iab5158d08029f4755cb4a2c60628cdc7e34148a7
Reviewed-on: https://chromium-review.googlesource.com/c/1258357
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596579}
[modify] https://crrev.com/865e784661f0fdea6edeeb1fb88d4f1fa484d97e/chrome/browser/notifications/notification_display_service_tester.cc
[modify] https://crrev.com/865e784661f0fdea6edeeb1fb88d4f1fa484d97e/chrome/browser/notifications/persistent_notification_handler_unittest.cc
[modify] https://crrev.com/865e784661f0fdea6edeeb1fb88d4f1fa484d97e/chrome/browser/notifications/platform_notification_service_unittest.cc
Project Member

Comment 31 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fdc727fd300ac7d8610ca7522875c04cda31e52

commit 4fdc727fd300ac7d8610ca7522875c04cda31e52
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 11:09:46 2018

Convert GCMProfileServiceFactory to TestingFactory

TestingFactory is a base::Callback<> while TestingFactoryFunction
is a function pointer. Convert GCMProfileServiceFactory to the
callback based type.

Bug:  809610 
Change-Id: I8a031fa5eef35d5a4f669d931594ba14b926c8e7
Reviewed-on: https://chromium-review.googlesource.com/c/1245776
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596583}
[modify] https://crrev.com/4fdc727fd300ac7d8610ca7522875c04cda31e52/chrome/browser/extensions/api/instance_id/instance_id_apitest.cc
[modify] https://crrev.com/4fdc727fd300ac7d8610ca7522875c04cda31e52/chrome/browser/extensions/service_worker_apitest.cc
[modify] https://crrev.com/4fdc727fd300ac7d8610ca7522875c04cda31e52/chrome/browser/gcm/gcm_profile_service_factory.cc
[modify] https://crrev.com/4fdc727fd300ac7d8610ca7522875c04cda31e52/chrome/browser/gcm/gcm_profile_service_factory.h
[modify] https://crrev.com/4fdc727fd300ac7d8610ca7522875c04cda31e52/chrome/browser/push_messaging/push_messaging_browsertest.cc
Project Member

Comment 32 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e00ae44d0b36d415d3fe901a43af137454383421

commit e00ae44d0b36d415d3fe901a43af137454383421
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 11:11:31 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/extensions/extension_gcm_app_handler_unittest.cc.

This CL was uploaded by git cl split.

R=peter@chromium.org

Bug:  809610 
Change-Id: I4210652a5584af1dfb3a069f73bfed156ef65b55
Reviewed-on: https://chromium-review.googlesource.com/c/1258006
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596584}
[modify] https://crrev.com/e00ae44d0b36d415d3fe901a43af137454383421/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc
Project Member

Comment 33 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a34c61ad8ad4342cb7971266ff214df246f681b4

commit a34c61ad8ad4342cb7971266ff214df246f681b4
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 11:14:11 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//extensions/browser/api/storage.

This CL was uploaded by git cl split.

R=rdevlin.cronin@chromium.org

Bug:  809610 
Change-Id: I3230efd3d9d26eff70a220d471ea5c06c88df502
Reviewed-on: https://chromium-review.googlesource.com/c/1258178
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596585}
[modify] https://crrev.com/a34c61ad8ad4342cb7971266ff214df246f681b4/extensions/browser/api/storage/storage_api_unittest.cc
Project Member

Comment 34 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e95631bbaa55c6ac2d4c0fb80bf38b42e56cc325

commit e95631bbaa55c6ac2d4c0fb80bf38b42e56cc325
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 11:25:10 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/cocoa/test/cocoa_profile_test.mm.

This CL was uploaded by git cl split.

R=mark@chromium.org

Bug:  809610 
Change-Id: Id64f53e6b6a58c032f41c4461693d6d69116f406
Reviewed-on: https://chromium-review.googlesource.com/c/1259016
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596591}
[modify] https://crrev.com/e95631bbaa55c6ac2d4c0fb80bf38b42e56cc325/chrome/browser/ui/cocoa/test/cocoa_profile_test.mm
Project Member

Comment 35 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b585e92b0e53d7bca22d94702aea3fcaf4e2437c

commit b585e92b0e53d7bca22d94702aea3fcaf4e2437c
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 11:26:44 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//extensions/browser/api/sockets_tcp.

This CL was uploaded by git cl split.

R=xiyuan@chromium.org

Bug:  809610 
Change-Id: I158ac6df6d0cf950da4c516bfa7595f3a5dcc148
Reviewed-on: https://chromium-review.googlesource.com/c/1258172
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596592}
[modify] https://crrev.com/b585e92b0e53d7bca22d94702aea3fcaf4e2437c/extensions/browser/api/sockets_tcp/sockets_tcp_api_unittest.cc
Project Member

Comment 36 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48480cf68d8ed4486fd5527da546770f9e7b5b9b

commit 48480cf68d8ed4486fd5527da546770f9e7b5b9b
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 11:28:47 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//extensions/browser/api/feedback_private.

This CL was uploaded by git cl split.

R=afakhry@chromium.org

Bug:  809610 
Change-Id: I41eb7e5f4a7b0286c0e3338e1b1792f38c7fdfdb
Reviewed-on: https://chromium-review.googlesource.com/c/1259017
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596593}
[modify] https://crrev.com/48480cf68d8ed4486fd5527da546770f9e7b5b9b/extensions/browser/api/feedback_private/feedback_private_api_unittest_base_chromeos.cc
Project Member

Comment 37 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/275c01ca85a6375a41b8e426e4201ee268e58522

commit 275c01ca85a6375a41b8e426e4201ee268e58522
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 11:30:40 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ssl.

This CL was uploaded by git cl split.

R=rsleevi@chromium.org

Bug:  809610 
Change-Id: I27af4c0d03bd13ab7d7d9ed3941b7afea0de2302
Reviewed-on: https://chromium-review.googlesource.com/c/1258984
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596594}
[modify] https://crrev.com/275c01ca85a6375a41b8e426e4201ee268e58522/chrome/browser/ssl/ssl_blocking_page_unittest.cc
Project Member

Comment 38 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/288bc2fc669315b486744a5418f4cd6d7a0c926e

commit 288bc2fc669315b486744a5418f4cd6d7a0c926e
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 11:34:17 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/chromeos.

This CL was uploaded by git cl split.

R=xiyuan@chromium.org

Bug:  809610 
Change-Id: Id2dce79aff71ae34ea51f32f7f5c631cda602997
Reviewed-on: https://chromium-review.googlesource.com/c/1259015
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596595}
[modify] https://crrev.com/288bc2fc669315b486744a5418f4cd6d7a0c926e/chrome/browser/chromeos/customization/customization_document_unittest.cc
[modify] https://crrev.com/288bc2fc669315b486744a5418f4cd6d7a0c926e/chrome/browser/chromeos/net/wake_on_wifi_manager_unittest.cc
Project Member

Comment 39 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/600eb1191d1854f42dfb0f152f8a6e1112db0678

commit 600eb1191d1854f42dfb0f152f8a6e1112db0678
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 11:35:50 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/views/omnibox.

This CL was uploaded by git cl split.

R=tommycli@chromium.org

Bug:  809610 
Change-Id: Id899615e5de24f082ed88441d255c57f73d17b34
Reviewed-on: https://chromium-review.googlesource.com/c/1258359
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596596}
[modify] https://crrev.com/600eb1191d1854f42dfb0f152f8a6e1112db0678/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc
Project Member

Comment 40 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f77e8cfff2cb49ed9b9459fa3f461f300375857

commit 3f77e8cfff2cb49ed9b9459fa3f461f300375857
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 11:39:22 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/extensions/api/mdns.

This CL was uploaded by git cl split.

R=gene@chromium.org

Bug:  809610 
Change-Id: If3c540d1d4a21995f64f4774615a27fc374c2762
Reviewed-on: https://chromium-review.googlesource.com/c/1258910
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Gene Gutnik <gene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596597}
[modify] https://crrev.com/3f77e8cfff2cb49ed9b9459fa3f461f300375857/chrome/browser/extensions/api/mdns/mdns_api_unittest.cc
Project Member

Comment 41 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25e9322a688c686272a4349e539e215807f9623e

commit 25e9322a688c686272a4349e539e215807f9623e
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 11:39:32 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/desktop_ios_promotion.

This CL was uploaded by git cl split.

R=justincohen@chromium.org

Bug:  809610 
Change-Id: I5a51b5d4ada1e22557b10645166aaaa44b721bc0
Reviewed-on: https://chromium-review.googlesource.com/c/1258915
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596598}
[modify] https://crrev.com/25e9322a688c686272a4349e539e215807f9623e/chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_bubble_controller_unittest.cc
[modify] https://crrev.com/25e9322a688c686272a4349e539e215807f9623e/chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_util_unittest.cc
Project Member

Comment 42 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4917001c3471249d059cfc05440702b72e02484

commit c4917001c3471249d059cfc05440702b72e02484
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 11:42:27 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/extensions.

This CL was uploaded by git cl split.

R=rdevlin.cronin@chromium.org

Bug:  809610 
Change-Id: I6946ce73781d65738ac93e0b32868cd69087ac20
Reviewed-on: https://chromium-review.googlesource.com/c/1258921
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596599}
[modify] https://crrev.com/c4917001c3471249d059cfc05440702b72e02484/chrome/browser/ui/extensions/extension_message_bubble_bridge_unittest.cc
Project Member

Comment 43 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34215aa1f427473dee2ec7271af9e142463c5d5b

commit 34215aa1f427473dee2ec7271af9e142463c5d5b
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 11:45:28 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/chromeos/login/easy_unlock.

This CL was uploaded by git cl split.

R=xiyuan@chromium.org

Bug:  809610 
Change-Id: I4025e052bfa65fa8853cfff92216c4707d2ad2fa
Reviewed-on: https://chromium-review.googlesource.com/c/1259007
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596600}
[modify] https://crrev.com/34215aa1f427473dee2ec7271af9e142463c5d5b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_app_manager_unittest.cc
[modify] https://crrev.com/34215aa1f427473dee2ec7271af9e142463c5d5b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_unittest_chromeos.cc
Project Member

Comment 44 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f3a1b23a6927fd0ec706fa9ab04b751d0148fa2

commit 2f3a1b23a6927fd0ec706fa9ab04b751d0148fa2
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 11:48:16 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/views/media_router.

This CL was uploaded by git cl split.

R=takumif@chromium.org

Bug:  809610 
Change-Id: I1fe6c352e5560dae357b5ab6aec08c493d47513a
Reviewed-on: https://chromium-review.googlesource.com/c/1258008
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596603}
[modify] https://crrev.com/2f3a1b23a6927fd0ec706fa9ab04b751d0148fa2/chrome/browser/ui/views/media_router/cast_toolbar_button_unittest.cc
Project Member

Comment 45 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/901b0155ecc168d7a4f452c33577894474fbcefb

commit 901b0155ecc168d7a4f452c33577894474fbcefb
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 11:48:55 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/profile_resetter.

This CL was uploaded by git cl split.

R=vabr@chromium.org

Bug:  809610 
Change-Id: Ia86d7d59f8025845c04432b4fa92fed0de53d511
Reviewed-on: https://chromium-review.googlesource.com/c/1259027
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596604}
[modify] https://crrev.com/901b0155ecc168d7a4f452c33577894474fbcefb/chrome/browser/profile_resetter/profile_resetter_unittest.cc
Project Member

Comment 46 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c06b55ae1f943913c93a0f7103de625218dd8e99

commit c06b55ae1f943913c93a0f7103de625218dd8e99
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 11:49:31 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/prerender.

This CL was uploaded by git cl split.

R=mattcary@chromium.org

Bug:  809610 
Change-Id: I34264dec9e444fac342146dadbdf8453d3dad870
Reviewed-on: https://chromium-review.googlesource.com/c/1259036
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596605}
[modify] https://crrev.com/c06b55ae1f943913c93a0f7103de625218dd8e99/chrome/browser/prerender/prerender_browsertest.cc
Project Member

Comment 47 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87e77f9d5230ad487d6005e88bf8b882e0fde5f8

commit 87e77f9d5230ad487d6005e88bf8b882e0fde5f8
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 11:50:02 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/media_router.

This CL was uploaded by git cl split.

R=takumif@chromium.org

Bug:  809610 
Change-Id: I446325a4f9a288be91031ecf8d8465a5d84d2d8f
Reviewed-on: https://chromium-review.googlesource.com/c/1257935
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596606}
[modify] https://crrev.com/87e77f9d5230ad487d6005e88bf8b882e0fde5f8/chrome/browser/ui/media_router/media_router_ui_service_factory_unittest.cc
Project Member

Comment 48 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70554c2519a4b763642248176cbd60a9579b0050

commit 70554c2519a4b763642248176cbd60a9579b0050
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 11:51:49 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/feature_engagement.

This CL was uploaded by git cl split.

R=dtrainor@chromium.org

Bug:  809610 
Change-Id: Ie13b1a5069995cf5166c455a6631b55d4978b8f4
Reviewed-on: https://chromium-review.googlesource.com/c/1258916
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596607}
[modify] https://crrev.com/70554c2519a4b763642248176cbd60a9579b0050/chrome/browser/feature_engagement/incognito_window/incognito_window_tracker_browsertest.cc
[modify] https://crrev.com/70554c2519a4b763642248176cbd60a9579b0050/chrome/browser/feature_engagement/new_tab/new_tab_tracker_browsertest.cc
Project Member

Comment 49 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/745f93f9506ad9e38a2a2a9c40d97fac504f52f2

commit 745f93f9506ad9e38a2a2a9c40d97fac504f52f2
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 12:01:31 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc.

This CL was uploaded by git cl split.

R=btolsch@chromium.org

Bug:  809610 
Change-Id: I9a429817f8de25ca22a37a19bc564d3e408b9287
Reviewed-on: https://chromium-review.googlesource.com/c/1257794
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596608}
[modify] https://crrev.com/745f93f9506ad9e38a2a2a9c40d97fac504f52f2/chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc
Project Member

Comment 50 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2548f6f5797a48816ace702f4de7778b5864392c

commit 2548f6f5797a48816ace702f4de7778b5864392c
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 12:02:11 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/android/download.

This CL was uploaded by git cl split.

R=xingliu@chromium.org

Bug:  809610 
Change-Id: I196b778462b96eebc23acfe59de4a293aab0496e
Reviewed-on: https://chromium-review.googlesource.com/c/1257837
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596609}
[modify] https://crrev.com/2548f6f5797a48816ace702f4de7778b5864392c/chrome/browser/android/download/available_offline_content_provider_unittest.cc
Project Member

Comment 51 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25effeb3fae9e5380e7feb11ef41b1be6584fa14

commit 25effeb3fae9e5380e7feb11ef41b1be6584fa14
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 12:06:40 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/download.

This CL was uploaded by git cl split.

R=dtrainor@chromium.org

Bug:  809610 
Change-Id: Iac3369d290d17c49dac03816169bde2648cce8fd
Reviewed-on: https://chromium-review.googlesource.com/c/1258909
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596611}
[modify] https://crrev.com/25effeb3fae9e5380e7feb11ef41b1be6584fa14/chrome/browser/download/download_ui_controller_unittest.cc
Project Member

Comment 52 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbaba13ce1a9810d4e2733838d59f073e643d18a

commit bbaba13ce1a9810d4e2733838d59f073e643d18a
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 12:07:30 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/signin.

This CL was uploaded by git cl split.

R=droger@chromium.org

Bug:  809610 
Change-Id: I5e99fe5b0d4f6ffa748dbdc8983f831de17cdcc1
Reviewed-on: https://chromium-review.googlesource.com/c/1258911
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596612}
[modify] https://crrev.com/bbaba13ce1a9810d4e2733838d59f073e643d18a/chrome/browser/signin/signin_tracker_unittest.cc
Project Member

Comment 53 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad06db087701306928752f336107c1012a34d677

commit ad06db087701306928752f336107c1012a34d677
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 12:08:22 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc.

This CL was uploaded by git cl split.

R=felt@chromium.org

Bug:  809610 
Change-Id: Ide7e3f2e71665f015d1ec556a96bfcd956abbffc
Reviewed-on: https://chromium-review.googlesource.com/c/1259033
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596613}
[modify] https://crrev.com/ad06db087701306928752f336107c1012a34d677/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
Project Member

Comment 54 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80a7ff66002bdb6414951bc84c73ba04b90c69b1

commit 80a7ff66002bdb6414951bc84c73ba04b90c69b1
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 12:09:14 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/policy.

This CL was uploaded by git cl split.

R=pmarko@chromium.org

Bug:  809610 
Change-Id: I04cc21ab7c00b7062f78eb8b54fdcaf576f93ec6
Reviewed-on: https://chromium-review.googlesource.com/c/1258332
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596614}
[modify] https://crrev.com/80a7ff66002bdb6414951bc84c73ba04b90c69b1/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc
Project Member

Comment 55 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/044fe0efe4b83c646f2bb8e9238b54fb247d65ae

commit 044fe0efe4b83c646f2bb8e9238b54fb247d65ae
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 12:12:12 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/views/bookmarks.

This CL was uploaded by git cl split.

R=sky@chromium.org

Bug:  809610 
Change-Id: I7e0ba402a061a981339b38f1544c867f1052f803
Reviewed-on: https://chromium-review.googlesource.com/c/1259035
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596615}
[modify] https://crrev.com/044fe0efe4b83c646f2bb8e9238b54fb247d65ae/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc
Project Member

Comment 56 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a845b942ac0ecde1bbbf5d774f3a8aa9c7aebc58

commit a845b942ac0ecde1bbbf5d774f3a8aa9c7aebc58
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 12:13:04 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/webui/print_preview.

This CL was uploaded by git cl split.

R=rbpotter@chromium.org

Bug:  809610 
Change-Id: I054ccb17b5557e700aff2ccb0f72307af5e41a5f
Reviewed-on: https://chromium-review.googlesource.com/c/1258353
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596616}
[modify] https://crrev.com/a845b942ac0ecde1bbbf5d774f3a8aa9c7aebc58/chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc
Project Member

Comment 57 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70e5fe1a278ebc84e51b31ac17f1b8083df7294d

commit 70e5fe1a278ebc84e51b31ac17f1b8083df7294d
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 12:14:09 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/media/media_engagement_service_unittest.cc.

This CL was uploaded by git cl split.

R=mlamouri@chromium.org

Bug:  809610 
Change-Id: I6bef551f35ebab6bb192af99f86365e62ebe0b55
Reviewed-on: https://chromium-review.googlesource.com/c/1259002
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596617}
[modify] https://crrev.com/70e5fe1a278ebc84e51b31ac17f1b8083df7294d/chrome/browser/media/media_engagement_service_unittest.cc
Project Member

Comment 58 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75efcec1c4b48accacb21b1e332f94288636978e

commit 75efcec1c4b48accacb21b1e332f94288636978e
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 12:14:29 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/chromeos/arc/auth.

This CL was uploaded by git cl split.

R=khmel@chromium.org

Bug:  809610 
Change-Id: I16703180cb1ca7b4acdf5b2d5eb7d81125b5695e
Reviewed-on: https://chromium-review.googlesource.com/c/1259010
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596618}
[modify] https://crrev.com/75efcec1c4b48accacb21b1e332f94288636978e/chrome/browser/chromeos/arc/auth/arc_auth_service_browsertest.cc
Project Member

Comment 59 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fba92c02eb0a3fe64a036ba035efefb571b47e0

commit 7fba92c02eb0a3fe64a036ba035efefb571b47e0
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 12:16:48 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/gcm.

This CL was uploaded by git cl split.

R=fgorski@chromium.org

Bug:  809610 
Change-Id: I977d7f9586dffd411471f2c5a201f3d2cd386211
Reviewed-on: https://chromium-review.googlesource.com/c/1258985
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596620}
[modify] https://crrev.com/7fba92c02eb0a3fe64a036ba035efefb571b47e0/chrome/browser/gcm/gcm_profile_service_unittest.cc
Project Member

Comment 60 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20d1f1255b341d18e616ea69236b8b5e8be78fda

commit 20d1f1255b341d18e616ea69236b8b5e8be78fda
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 12:17:06 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/media/router.

This CL was uploaded by git cl split.

R=btolsch@chromium.org

Bug:  809610 
Change-Id: I04ceb8b57dfd8772d31bee0ea7f49e9025325934
Reviewed-on: https://chromium-review.googlesource.com/c/1258350
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596621}
[modify] https://crrev.com/20d1f1255b341d18e616ea69236b8b5e8be78fda/chrome/browser/media/router/event_page_request_manager_unittest.cc
[modify] https://crrev.com/20d1f1255b341d18e616ea69236b8b5e8be78fda/chrome/browser/media/router/media_router_factory_unittest.cc
[modify] https://crrev.com/20d1f1255b341d18e616ea69236b8b5e8be78fda/chrome/browser/media/router/mojo/media_route_controller_unittest.cc
[modify] https://crrev.com/20d1f1255b341d18e616ea69236b8b5e8be78fda/chrome/browser/media/router/presentation/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/20d1f1255b341d18e616ea69236b8b5e8be78fda/chrome/browser/media/router/providers/extension/extension_media_route_provider_proxy_unittest.cc
[modify] https://crrev.com/20d1f1255b341d18e616ea69236b8b5e8be78fda/chrome/browser/media/router/test/media_router_mojo_test.cc
Project Member

Comment 61 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14fcaf752316081e8ca68fee633ac883267a24c4

commit 14fcaf752316081e8ca68fee633ac883267a24c4
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 12:17:54 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/extensions/api/language_settings_private.

This CL was uploaded by git cl split.

R=michaelpg@chromium.org

Bug:  809610 
Change-Id: I565984f1f787a2b730d1f0c659e4d9c2f084fcd0
Reviewed-on: https://chromium-review.googlesource.com/c/1258920
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596622}
[modify] https://crrev.com/14fcaf752316081e8ca68fee633ac883267a24c4/chrome/browser/extensions/api/language_settings_private/language_settings_private_api_unittest.cc
[modify] https://crrev.com/14fcaf752316081e8ca68fee633ac883267a24c4/chrome/browser/extensions/api/language_settings_private/language_settings_private_delegate_unittest.cc
Project Member

Comment 62 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6f0576bdbacd75fdbe715f103915c89b95592f8

commit c6f0576bdbacd75fdbe715f103915c89b95592f8
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 12:18:41 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/resource_coordinator.

This CL was uploaded by git cl split.

R=haraken@chromium.org

Bug:  809610 
Change-Id: I057b0bd65c07e68f71692e9f02259cd1e02448c9
Reviewed-on: https://chromium-review.googlesource.com/c/1259030
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596623}
[modify] https://crrev.com/c6f0576bdbacd75fdbe715f103915c89b95592f8/chrome/browser/resource_coordinator/local_site_characteristics_webcontents_observer_unittest.cc
Project Member

Comment 63 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15ec5d6492c77eaeea4d66bc1b09eb1cf1714ce6

commit 15ec5d6492c77eaeea4d66bc1b09eb1cf1714ce6
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 12:19:10 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/startup.

This CL was uploaded by git cl split.

R=tmartino@chromium.org

Bug:  809610 
Change-Id: I90d1bbb37bbb2fefa701b1505a5e901c25bcbeda
Reviewed-on: https://chromium-review.googlesource.com/c/1259022
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596624}
[modify] https://crrev.com/15ec5d6492c77eaeea4d66bc1b09eb1cf1714ce6/chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc
Project Member

Comment 64 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f245fbdd5d6cde62ac32655f55e3761a111ca96d

commit f245fbdd5d6cde62ac32655f55e3761a111ca96d
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 12:22:22 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/search.

This CL was uploaded by git cl split.

R=treib@chromium.org

Bug:  809610 
Change-Id: I3c0bdf40ecbde2810d84368080ed8e316e2bd938
Reviewed-on: https://chromium-review.googlesource.com/c/1257861
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596626}
[modify] https://crrev.com/f245fbdd5d6cde62ac32655f55e3761a111ca96d/chrome/browser/search/instant_unittest_base.cc
[modify] https://crrev.com/f245fbdd5d6cde62ac32655f55e3761a111ca96d/chrome/browser/search/search_unittest.cc
Project Member

Comment 65 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3dd93585e12171785e12bfcdaa27ae2c3c5b80f8

commit 3dd93585e12171785e12bfcdaa27ae2c3c5b80f8
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 12:26:12 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/chromeos/arc.

This CL was uploaded by git cl split.

R=hidehiko@chromium.org

Bug:  809610 
Change-Id: I5fc6a8372a65e5433e17abdbd60c54c397ecc4d1
Reviewed-on: https://chromium-review.googlesource.com/c/1258351
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596627}
[modify] https://crrev.com/3dd93585e12171785e12bfcdaa27ae2c3c5b80f8/chrome/browser/chromeos/arc/arc_play_store_enabled_preference_handler_unittest.cc
[modify] https://crrev.com/3dd93585e12171785e12bfcdaa27ae2c3c5b80f8/chrome/browser/chromeos/arc/arc_session_manager_browsertest.cc
Project Member

Comment 66 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f7f7b796c9bc67d4593ea40415c24b99a574e54

commit 2f7f7b796c9bc67d4593ea40415c24b99a574e54
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 12:28:51 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/password_manager.

This CL was uploaded by git cl split.

R=vasilii@chromium.org

Bug:  809610 
Change-Id: Icfc16e13a6e72e0fbf99e3024c87470ead622e53
Reviewed-on: https://chromium-review.googlesource.com/c/1259012
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596629}
[modify] https://crrev.com/2f7f7b796c9bc67d4593ea40415c24b99a574e54/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
[modify] https://crrev.com/2f7f7b796c9bc67d4593ea40415c24b99a574e54/chrome/browser/password_manager/password_manager_test_base.cc
[modify] https://crrev.com/2f7f7b796c9bc67d4593ea40415c24b99a574e54/chrome/browser/password_manager/password_store_signin_notifier_impl_unittest.cc
Project Member

Comment 67 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05f665d705800ab7d77fe920fb3d934b22dc38e1

commit 05f665d705800ab7d77fe920fb3d934b22dc38e1
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 12:29:53 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome.

This CL was uploaded by git cl split.

R=sky@chromium.org

Bug:  809610 
Change-Id: I69743ec252e8de02491fb85992a9f74ce197f696
Reviewed-on: https://chromium-review.googlesource.com/c/1257795
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596630}
[modify] https://crrev.com/05f665d705800ab7d77fe920fb3d934b22dc38e1/chrome/test/base/chrome_render_view_host_test_harness.cc
[modify] https://crrev.com/05f665d705800ab7d77fe920fb3d934b22dc38e1/chrome/test/base/testing_profile_manager.cc
Project Member

Comment 68 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/711ff6b9f705d5047c3f7bad1dbc06b437efbbab

commit 711ff6b9f705d5047c3f7bad1dbc06b437efbbab
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 12:33:54 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/extensions.

This CL was uploaded by git cl split.

R=lazyboy@chromium.org

Bug:  809610 
Change-Id: I8acd294b25decd9f81be9cb8b76c41f3302644af
Reviewed-on: https://chromium-review.googlesource.com/c/1258171
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596632}
[modify] https://crrev.com/711ff6b9f705d5047c3f7bad1dbc06b437efbbab/chrome/browser/extensions/extension_action_runner_unittest.cc
[modify] https://crrev.com/711ff6b9f705d5047c3f7bad1dbc06b437efbbab/chrome/browser/extensions/extension_action_test_util.cc
[modify] https://crrev.com/711ff6b9f705d5047c3f7bad1dbc06b437efbbab/chrome/browser/extensions/extension_context_menu_model_unittest.cc
[modify] https://crrev.com/711ff6b9f705d5047c3f7bad1dbc06b437efbbab/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc
[modify] https://crrev.com/711ff6b9f705d5047c3f7bad1dbc06b437efbbab/chrome/browser/extensions/extension_service_test_base.cc
[modify] https://crrev.com/711ff6b9f705d5047c3f7bad1dbc06b437efbbab/chrome/browser/extensions/extension_storage_monitor_browsertest.cc
[modify] https://crrev.com/711ff6b9f705d5047c3f7bad1dbc06b437efbbab/chrome/browser/extensions/extension_web_ui_unittest.cc
[modify] https://crrev.com/711ff6b9f705d5047c3f7bad1dbc06b437efbbab/chrome/browser/extensions/external_pref_loader_unittest.cc
[modify] https://crrev.com/711ff6b9f705d5047c3f7bad1dbc06b437efbbab/chrome/browser/extensions/menu_manager_unittest.cc
[modify] https://crrev.com/711ff6b9f705d5047c3f7bad1dbc06b437efbbab/chrome/browser/extensions/ntp_overridden_bubble_delegate_unittest.cc
[modify] https://crrev.com/711ff6b9f705d5047c3f7bad1dbc06b437efbbab/chrome/browser/extensions/service_worker_apitest.cc
[modify] https://crrev.com/711ff6b9f705d5047c3f7bad1dbc06b437efbbab/chrome/browser/extensions/update_install_gate_unittest.cc
Project Member

Comment 69 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e48cd5cb3780b7fd5ee01651f59ec447d73e2e6d

commit e48cd5cb3780b7fd5ee01651f59ec447d73e2e6d
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 12:35:07 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/search_engines.

This CL was uploaded by git cl split.

R=pkasting@chromium.org

Bug:  809610 
Change-Id: I8f556cf9c85b9103051c036d2a81720d6bdcdb87
Reviewed-on: https://chromium-review.googlesource.com/c/1258173
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596633}
[modify] https://crrev.com/e48cd5cb3780b7fd5ee01651f59ec447d73e2e6d/chrome/browser/search_engines/template_url_service_factory_test_util.cc
Project Member

Comment 70 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/226e4913fe6b1c0980a0165a6e7cdb5c4b87af55

commit 226e4913fe6b1c0980a0165a6e7cdb5c4b87af55
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 12:35:57 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/plugins.

This CL was uploaded by git cl split.

R=tommycli@chromium.org

Bug:  809610 
Change-Id: Ic5c4219a327a8ab038371a21c5d62bba54595d2d
Reviewed-on: https://chromium-review.googlesource.com/c/1258919
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596634}
[modify] https://crrev.com/226e4913fe6b1c0980a0165a6e7cdb5c4b87af55/chrome/browser/plugins/plugin_prefs.cc
Project Member

Comment 71 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e503b0bfeeda8b58973363ecfec5a3bad4b2ee1

commit 8e503b0bfeeda8b58973363ecfec5a3bad4b2ee1
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 12:36:10 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/supervised_user.

This CL was uploaded by git cl split.

R=treib@chromium.org

Bug:  809610 
Change-Id: I3280d803989a93c67ff0d34b21c409028f8011d5
Reviewed-on: https://chromium-review.googlesource.com/c/1259037
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596635}
[modify] https://crrev.com/8e503b0bfeeda8b58973363ecfec5a3bad4b2ee1/chrome/browser/supervised_user/child_accounts/child_account_service_unittest.cc
[modify] https://crrev.com/8e503b0bfeeda8b58973363ecfec5a3bad4b2ee1/chrome/browser/supervised_user/supervised_user_service_unittest.cc
Project Member

Comment 72 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e75cab9657da51165fbcd5a87fcbfae32dd7f697

commit e75cab9657da51165fbcd5a87fcbfae32dd7f697
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 12:48:04 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//extensions.

This CL was uploaded by git cl split.

R=karandeepb@chromium.org

Bug:  809610 
Change-Id: Id51b769ac4c45ca7a92330cb820397ac42f4392e
Reviewed-on: https://chromium-review.googlesource.com/c/1257934
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596636}
[modify] https://crrev.com/e75cab9657da51165fbcd5a87fcbfae32dd7f697/extensions/browser/lazy_background_task_queue_unittest.cc
[modify] https://crrev.com/e75cab9657da51165fbcd5a87fcbfae32dd7f697/extensions/browser/test_event_router.h
Project Member

Comment 73 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b257b0d323ee78c13adbe010c0bf5e73396ec58

commit 1b257b0d323ee78c13adbe010c0bf5e73396ec58
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 13:13:38 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/autocomplete.

This CL was uploaded by git cl split.

R=tommycli@chromium.org

Bug:  809610 
Change-Id: I5c6588a869225aeefef8b6d8198d92678a2d7642
Reviewed-on: https://chromium-review.googlesource.com/c/1259028
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596640}
[modify] https://crrev.com/1b257b0d323ee78c13adbe010c0bf5e73396ec58/chrome/browser/autocomplete/search_provider_unittest.cc
[modify] https://crrev.com/1b257b0d323ee78c13adbe010c0bf5e73396ec58/chrome/browser/autocomplete/shortcuts_provider_extension_unittest.cc
Project Member

Comment 74 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0aea215b9e999fdd0891e962c222bc01f9419b16

commit 0aea215b9e999fdd0891e962c222bc01f9419b16
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 13:25:03 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/extensions/api/identity.

This CL was uploaded by git cl split.

R=courage@chromium.org

Bug:  809610 
Change-Id: Id702299e37de9a9f224e11f948537c13df068fc6
Reviewed-on: https://chromium-review.googlesource.com/c/1259042
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Michael Courage <courage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596644}
[modify] https://crrev.com/0aea215b9e999fdd0891e962c222bc01f9419b16/chrome/browser/extensions/api/identity/identity_apitest.cc
Project Member

Comment 75 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29ce3d0f37ab99cfdd354131112143f6fcfa4642

commit 29ce3d0f37ab99cfdd354131112143f6fcfa4642
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 13:40:45 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/sync.

This CL was uploaded by git cl split.

R=melandory@chromium.org

Bug:  809610 
Change-Id: Ie5cf8f1bb9884eb74ed4bd44697b8b5a94a85e39
Reviewed-on: https://chromium-review.googlesource.com/c/1258169
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596647}
[modify] https://crrev.com/29ce3d0f37ab99cfdd354131112143f6fcfa4642/chrome/browser/sync/sync_error_notifier_ash_unittest.cc
[modify] https://crrev.com/29ce3d0f37ab99cfdd354131112143f6fcfa4642/chrome/browser/sync/sync_startup_tracker_unittest.cc
[modify] https://crrev.com/29ce3d0f37ab99cfdd354131112143f6fcfa4642/chrome/browser/sync/test/integration/secondary_account_helper.cc
[modify] https://crrev.com/29ce3d0f37ab99cfdd354131112143f6fcfa4642/chrome/browser/sync/test/integration/sync_test.cc
Project Member

Comment 76 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0bf4cb6edf9965cfac415f3ebe24c7c05ac2acd

commit f0bf4cb6edf9965cfac415f3ebe24c7c05ac2acd
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 14:48:35 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/sync.

This CL was uploaded by git cl split.

R=msarda@chromium.org

Bug:  809610 
Change-Id: If5762ddf6e72164a48469b451923d757ab2e69c0
Reviewed-on: https://chromium-review.googlesource.com/c/1257933
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596666}
[modify] https://crrev.com/f0bf4cb6edf9965cfac415f3ebe24c7c05ac2acd/chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc
[modify] https://crrev.com/f0bf4cb6edf9965cfac415f3ebe24c7c05ac2acd/chrome/browser/ui/sync/one_click_signin_sync_starter_unittest.cc
[modify] https://crrev.com/f0bf4cb6edf9965cfac415f3ebe24c7c05ac2acd/chrome/browser/ui/sync/sync_promo_ui_unittest.cc
Project Member

Comment 77 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75564ba4c07d1847a55f9495dfb34cc9dab48ce6

commit 75564ba4c07d1847a55f9495dfb34cc9dab48ce6
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 15:20:35 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/passwords.

This CL was uploaded by git cl split.

R=vasilii@chromium.org

Bug:  809610 
Change-Id: Ibd9fe9cf5088c2c4885b3278073e0979f1b4c6f9
Reviewed-on: https://chromium-review.googlesource.com/c/1257838
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596673}
[modify] https://crrev.com/75564ba4c07d1847a55f9495dfb34cc9dab48ce6/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
[modify] https://crrev.com/75564ba4c07d1847a55f9495dfb34cc9dab48ce6/chrome/browser/ui/passwords/password_manager_presenter_unittest.cc
Project Member

Comment 78 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acf7561e68abcb51470fe1afcd66b4fbb8c27128

commit acf7561e68abcb51470fe1afcd66b4fbb8c27128
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 15:20:39 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/safe_browsing/settings_reset_prompt.

This CL was uploaded by git cl split.

R=robertshield@chromium.org

Bug:  809610 
Change-Id: Ia4da1523758d8091bad781d01026453d4085560f
Reviewed-on: https://chromium-review.googlesource.com/c/1259008
Reviewed-by: Robert Shield <robertshield@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596674}
[modify] https://crrev.com/acf7561e68abcb51470fe1afcd66b4fbb8c27128/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_model_unittest.cc
Project Member

Comment 79 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0015ebcb37a81ef374a49659d22c901986df284

commit b0015ebcb37a81ef374a49659d22c901986df284
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 15:21:42 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/webui/signin.

This CL was uploaded by git cl split.

R=rogerta@chromium.org

Bug:  809610 
Change-Id: Ib267c7d43afb0b4682fa8232431169012389e732
Reviewed-on: https://chromium-review.googlesource.com/c/1259004
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596675}
[modify] https://crrev.com/b0015ebcb37a81ef374a49659d22c901986df284/chrome/browser/ui/webui/signin/dice_turn_sync_on_helper_unittest.cc
[modify] https://crrev.com/b0015ebcb37a81ef374a49659d22c901986df284/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc
[modify] https://crrev.com/b0015ebcb37a81ef374a49659d22c901986df284/chrome/browser/ui/webui/signin/user_manager_ui_browsertest.cc
Project Member

Comment 80 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2748f4c6a89d5730f0ee196251491e2c23ea81dc

commit 2748f4c6a89d5730f0ee196251491e2c23ea81dc
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 15:21:45 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/views/autofill.

This CL was uploaded by git cl split.

R=vasilii@chromium.org

Bug:  809610 
Change-Id: Idd31113f973dcb3906be2c0db166fb8536ee5c99
Reviewed-on: https://chromium-review.googlesource.com/c/1258176
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596676}
[modify] https://crrev.com/2748f4c6a89d5730f0ee196251491e2c23ea81dc/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc
Project Member

Comment 81 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfa59d94b2cfff45037e2fd783a054fa915911d4

commit cfa59d94b2cfff45037e2fd783a054fa915911d4
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 15:22:48 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/profiles.

This CL was uploaded by git cl split.

R=skuhne@chromium.org

Bug:  809610 
Change-Id: Ic45b0fc9fbeb570f14e193b37723234c6ab74ee3
Reviewed-on: https://chromium-review.googlesource.com/c/1257932
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596677}
[modify] https://crrev.com/cfa59d94b2cfff45037e2fd783a054fa915911d4/chrome/browser/profiles/profile_downloader_unittest.cc
[modify] https://crrev.com/cfa59d94b2cfff45037e2fd783a054fa915911d4/chrome/browser/profiles/profile_statistics_browsertest.cc
[modify] https://crrev.com/cfa59d94b2cfff45037e2fd783a054fa915911d4/chrome/browser/profiles/profile_statistics_unittest.cc
Project Member

Comment 82 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf6d1eb7c87976bb46b9cab0333fcc417bd59cf5

commit cf6d1eb7c87976bb46b9cab0333fcc417bd59cf5
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 04 15:32:50 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/test/base/testing_profile.cc.

This CL was uploaded by git cl split.

R=<anyone>

Bug:  809610 
Change-Id: I5289c063a35968a1ea2bf9872e1b146e965d4dcf
Reviewed-on: https://chromium-review.googlesource.com/c/1259006
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596681}
[modify] https://crrev.com/cf6d1eb7c87976bb46b9cab0333fcc417bd59cf5/chrome/test/base/testing_profile.cc
Project Member

Comment 83 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b9ecbfb3c663b15afb82ea5f8696e9073c6c15b

commit 2b9ecbfb3c663b15afb82ea5f8696e9073c6c15b
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Fri Oct 05 09:01:28 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/engagement.

This CL was uploaded by git cl split.

R=raymes@chromium.org

Bug:  809610 
Change-Id: I903a5ae6c2d436837cfac97b3bfa1519be66bb1b
Reviewed-on: https://chromium-review.googlesource.com/c/1259013
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597042}
[modify] https://crrev.com/2b9ecbfb3c663b15afb82ea5f8696e9073c6c15b/chrome/browser/engagement/important_sites_util_unittest.cc
[modify] https://crrev.com/2b9ecbfb3c663b15afb82ea5f8696e9073c6c15b/chrome/browser/engagement/site_engagement_service_unittest.cc
Project Member

Comment 84 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/244f7b03e36c8e01afbce29736b9fbd22a8d34e3

commit 244f7b03e36c8e01afbce29736b9fbd22a8d34e3
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Fri Oct 05 09:03:12 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/webui/sync_internals_message_handler_unittest.cc.

This CL was uploaded by git cl split.

R=jkrcal@chromium.org

Bug:  809610 
Change-Id: Idd87a49ccd46ebc7d7aedd0a8cf47916fcd6fffd
Reviewed-on: https://chromium-review.googlesource.com/c/1258768
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597043}
[modify] https://crrev.com/244f7b03e36c8e01afbce29736b9fbd22a8d34e3/chrome/browser/ui/webui/sync_internals_message_handler_unittest.cc
Project Member

Comment 85 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24c3daeee2eb43c0d1b5d668e666ff99b8b36165

commit 24c3daeee2eb43c0d1b5d668e666ff99b8b36165
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Fri Oct 05 09:11:21 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//extensions/browser/api.

This CL was uploaded by git cl split.

R=tbarzic@chromium.org

Bug:  809610 
Change-Id: Id9e8d81f60c29865b75ea219472a029c0ba7e487
Reviewed-on: https://chromium-review.googlesource.com/c/1257793
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597046}
[modify] https://crrev.com/24c3daeee2eb43c0d1b5d668e666ff99b8b36165/extensions/browser/api/system_power_source/system_power_source_api_unittest.cc
Project Member

Comment 86 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da8161d7ccd5fed01922b160cf4e7c0083bf8796

commit da8161d7ccd5fed01922b160cf4e7c0083bf8796
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Fri Oct 05 09:12:06 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/extensions/api/downloads.

This CL was uploaded by git cl split.

R=dtrainor@chromium.org

Bug:  809610 
Change-Id: Ia28860b92100550ef7e0989566293b4e6ca302fd
Reviewed-on: https://chromium-review.googlesource.com/c/1258908
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597047}
[modify] https://crrev.com/da8161d7ccd5fed01922b160cf4e7c0083bf8796/chrome/browser/extensions/api/downloads/downloads_api_unittest.cc
Project Member

Comment 87 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9887ccc8905f7d8d4921b852a77ec5c023f6f8b1

commit 9887ccc8905f7d8d4921b852a77ec5c023f6f8b1
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Fri Oct 05 09:12:55 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/spellchecker.

This CL was uploaded by git cl split.

R=groby@chromium.org

Bug:  809610 
Change-Id: Idc50a6ffd6c25fa2c321c0d39f4fa62412581a64
Reviewed-on: https://chromium-review.googlesource.com/c/1258918
Reviewed-by: Rachel Blum <groby@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597048}
[modify] https://crrev.com/9887ccc8905f7d8d4921b852a77ec5c023f6f8b1/chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc
Project Member

Comment 88 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67973de9fb145459c50f2a233b0005d279663032

commit 67973de9fb145459c50f2a233b0005d279663032
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Fri Oct 05 09:13:23 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/extensions/api.

This CL was uploaded by git cl split.

R=tbarzic@chromium.org

Bug:  809610 
Change-Id: Iff395f785271dc038e2e9e07f3569d91d956f27e
Reviewed-on: https://chromium-review.googlesource.com/c/1259034
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597049}
[modify] https://crrev.com/67973de9fb145459c50f2a233b0005d279663032/chrome/browser/extensions/api/device_permissions_manager_unittest.cc
[modify] https://crrev.com/67973de9fb145459c50f2a233b0005d279663032/chrome/browser/extensions/api/management/management_api_unittest.cc
[modify] https://crrev.com/67973de9fb145459c50f2a233b0005d279663032/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate_unittest.cc
[modify] https://crrev.com/67973de9fb145459c50f2a233b0005d279663032/chrome/browser/extensions/api/sessions/sessions_apitest.cc
[modify] https://crrev.com/67973de9fb145459c50f2a233b0005d279663032/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager_unittest.cc
[modify] https://crrev.com/67973de9fb145459c50f2a233b0005d279663032/chrome/browser/extensions/api/socket/socket_api_unittest.cc
[modify] https://crrev.com/67973de9fb145459c50f2a233b0005d279663032/chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api_unittest.cc
Project Member

Comment 89 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6ef1878f9b1e64be0bd977e32c635a3e71c3d56

commit f6ef1878f9b1e64be0bd977e32c635a3e71c3d56
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Fri Oct 05 09:14:03 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/chromeos/extensions/users_private.

This CL was uploaded by git cl split.

R=emaxx@chromium.org

Bug:  809610 
Change-Id: Ie2a188fc12106a28474818c9e57dc4dbac233841
Reviewed-on: https://chromium-review.googlesource.com/c/1258769
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597050}
[modify] https://crrev.com/f6ef1878f9b1e64be0bd977e32c635a3e71c3d56/chrome/browser/chromeos/extensions/users_private/users_private_apitest.cc
Project Member

Comment 90 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cba024f7380d10fe738a1c5876cda549269189b

commit 6cba024f7380d10fe738a1c5876cda549269189b
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Fri Oct 05 09:15:10 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/chromeos/file_manager.

This CL was uploaded by git cl split.

R=fukino@chromium.org

Bug:  809610 
Change-Id: I08597fe6bfc322399ae478451c9f2f9091d87ae7
Reviewed-on: https://chromium-review.googlesource.com/c/1258175
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597052}
[modify] https://crrev.com/6cba024f7380d10fe738a1c5876cda549269189b/chrome/browser/chromeos/file_manager/path_util_unittest.cc
Project Member

Comment 91 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/882241fc2432444c912aa807af3abb1a30ce86e8

commit 882241fc2432444c912aa807af3abb1a30ce86e8
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Fri Oct 05 09:23:47 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/webui.

This CL was uploaded by git cl split.

R=calamity@chromium.org

Bug:  809610 
Change-Id: I7c730e9e509e911411e693892b817ce8992517c6
Reviewed-on: https://chromium-review.googlesource.com/c/1259025
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597055}
[modify] https://crrev.com/882241fc2432444c912aa807af3abb1a30ce86e8/chrome/browser/ui/webui/browsing_history_handler_unittest.cc
Project Member

Comment 92 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5bfe4101c2423e24df1f5b0a1fc3863f39d0dbe

commit f5bfe4101c2423e24df1f5b0a1fc3863f39d0dbe
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Fri Oct 05 09:58:26 2018

Convert ProfileInvalidationProviderFactory to TestingFactory

TestingFactory is a base::Callback<> while TestingFactoryFunction
is a function pointer. Convert ProfileInvalidationProviderFactory
to the callback based type.

Bug:  809610 
Change-Id: Id6ddc4e75960f5fd1ed952877d4bebdca515b706
Reviewed-on: https://chromium-review.googlesource.com/c/1246166
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597058}
[modify] https://crrev.com/f5bfe4101c2423e24df1f5b0a1fc3863f39d0dbe/chrome/browser/chromeos/policy/affiliated_invalidation_service_provider_impl_unittest.cc
[modify] https://crrev.com/f5bfe4101c2423e24df1f5b0a1fc3863f39d0dbe/chrome/browser/invalidation/deprecated_profile_invalidation_provider_factory.cc
[modify] https://crrev.com/f5bfe4101c2423e24df1f5b0a1fc3863f39d0dbe/chrome/browser/invalidation/deprecated_profile_invalidation_provider_factory.h
[modify] https://crrev.com/f5bfe4101c2423e24df1f5b0a1fc3863f39d0dbe/chrome/browser/invalidation/profile_invalidation_provider_factory.cc
[modify] https://crrev.com/f5bfe4101c2423e24df1f5b0a1fc3863f39d0dbe/chrome/browser/invalidation/profile_invalidation_provider_factory.h
[modify] https://crrev.com/f5bfe4101c2423e24df1f5b0a1fc3863f39d0dbe/chrome/browser/policy/cloud/cloud_policy_browsertest.cc
Project Member

Comment 93 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b20aa2afb43b012dc364c08e4b930bcc6e3a4087

commit b20aa2afb43b012dc364c08e4b930bcc6e3a4087
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Fri Oct 05 12:08:22 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/push_messaging.

This CL was uploaded by git cl split.

R=mvanouwerkerk@chromium.org

Bug:  809610 
Change-Id: Ib8ccd8e3763c2c8172b9d7dcb7dac3cbc5e8e809
Reviewed-on: https://chromium-review.googlesource.com/c/1261699
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597076}
[modify] https://crrev.com/b20aa2afb43b012dc364c08e4b930bcc6e3a4087/chrome/browser/push_messaging/push_messaging_browsertest.cc
[modify] https://crrev.com/b20aa2afb43b012dc364c08e4b930bcc6e3a4087/chrome/browser/push_messaging/push_messaging_service_factory.cc
[modify] https://crrev.com/b20aa2afb43b012dc364c08e4b930bcc6e3a4087/chrome/browser/push_messaging/push_messaging_service_unittest.cc
Project Member

Comment 94 by bugdroid1@chromium.org, Oct 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19c771138b5ce4dd48d7913593cff8aecd15cd6c

commit 19c771138b5ce4dd48d7913593cff8aecd15cd6c
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Mon Oct 08 09:24:05 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/offline_pages.

This CL was uploaded by git cl split.

R=dimich@chromium.org

Bug:  809610 
Change-Id: I8bcb6ce9389ed769c91d677c5b065866b5b1323d
Reviewed-on: https://chromium-review.googlesource.com/c/1258358
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597501}
[modify] https://crrev.com/19c771138b5ce4dd48d7913593cff8aecd15cd6c/chrome/browser/offline_pages/android/evaluation/offline_page_evaluation_bridge.cc
[modify] https://crrev.com/19c771138b5ce4dd48d7913593cff8aecd15cd6c/chrome/browser/offline_pages/offline_page_request_handler_unittest.cc
[modify] https://crrev.com/19c771138b5ce4dd48d7913593cff8aecd15cd6c/chrome/browser/offline_pages/offline_page_tab_helper_unittest.cc
[modify] https://crrev.com/19c771138b5ce4dd48d7913593cff8aecd15cd6c/chrome/browser/offline_pages/offline_page_utils_unittest.cc
[modify] https://crrev.com/19c771138b5ce4dd48d7913593cff8aecd15cd6c/chrome/browser/offline_pages/prefetch/prefetch_instance_id_proxy_unittest.cc
[modify] https://crrev.com/19c771138b5ce4dd48d7913593cff8aecd15cd6c/chrome/browser/offline_pages/recent_tab_helper_unittest.cc
Project Member

Comment 95 by bugdroid1@chromium.org, Oct 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e1001cadf8d876f1b666dceae89da4e650b6f0a

commit 8e1001cadf8d876f1b666dceae89da4e650b6f0a
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Mon Oct 08 09:26:09 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/webui/settings.

This CL was uploaded by git cl split.

R=stevenjb@chromium.org

Bug:  809610 
Change-Id: I5103cabe5c8ea6f58e9c1cd10f17e352c3f4cbe4
Reviewed-on: https://chromium-review.googlesource.com/c/1259024
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597502}
[modify] https://crrev.com/8e1001cadf8d876f1b666dceae89da4e650b6f0a/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler_unittest.cc
[modify] https://crrev.com/8e1001cadf8d876f1b666dceae89da4e650b6f0a/chrome/browser/ui/webui/settings/people_handler_unittest.cc
Project Member

Comment 96 by bugdroid1@chromium.org, Oct 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27aacfe4c8a0ac22452e5c5dd443c50342e7a7a8

commit 27aacfe4c8a0ac22452e5c5dd443c50342e7a7a8
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Mon Oct 08 09:29:05 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc.

This CL was uploaded by git cl split.

R=stevenjb@chromium.org

Bug:  809610 
Change-Id: I74d020e16e7346724b5119ade16005119b1c119f
Reviewed-on: https://chromium-review.googlesource.com/c/1258913
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597504}
[modify] https://crrev.com/27aacfe4c8a0ac22452e5c5dd443c50342e7a7a8/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
Project Member

Comment 97 by bugdroid1@chromium.org, Oct 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26b1d7a4ad43e5b8a535272c7699f64344ab03f4

commit 26b1d7a4ad43e5b8a535272c7699f64344ab03f4
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Mon Oct 08 09:29:38 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/ash.

This CL was uploaded by git cl split.

R=stevenjb@chromium.org

Bug:  809610 
Change-Id: I924f989afa69979481c82a6b32d3b5d9dfd24b49
Reviewed-on: https://chromium-review.googlesource.com/c/1258177
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597505}
[modify] https://crrev.com/26b1d7a4ad43e5b8a535272c7699f64344ab03f4/chrome/browser/ui/ash/session_controller_client_unittest.cc
Project Member

Comment 98 by bugdroid1@chromium.org, Oct 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70e53e900e24d80c86e26ed7682e87c12250b6be

commit 70e53e900e24d80c86e26ed7682e87c12250b6be
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Mon Oct 08 09:32:50 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/app_list.

This CL was uploaded by git cl split.

R=stevenjb@chromium.org

Bug:  809610 
Change-Id: I8b538c62942b3e166321c62f3044d33975a1f396
Reviewed-on: https://chromium-review.googlesource.com/c/1257931
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597506}
[modify] https://crrev.com/70e53e900e24d80c86e26ed7682e87c12250b6be/chrome/browser/ui/app_list/app_context_menu_unittest.cc
[modify] https://crrev.com/70e53e900e24d80c86e26ed7682e87c12250b6be/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[modify] https://crrev.com/70e53e900e24d80c86e26ed7682e87c12250b6be/chrome/browser/ui/app_list/search/answer_card/answer_card_search_provider_unittest.cc
Project Member

Comment 99 by bugdroid1@chromium.org, Oct 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f59c9a00965c9f3b43a3c549a56cf1eb40de1503

commit f59c9a00965c9f3b43a3c549a56cf1eb40de1503
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Mon Oct 08 09:40:11 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/extensions/api/passwords_private.

This CL was uploaded by git cl split.

R=stevenjb@chromium.org

Bug:  809610 
Change-Id: Ic7e228270788db02035262b532fcc2eee8cebf0f
Reviewed-on: https://chromium-review.googlesource.com/c/1258355
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597508}
[modify] https://crrev.com/f59c9a00965c9f3b43a3c549a56cf1eb40de1503/chrome/browser/extensions/api/passwords_private/passwords_private_apitest.cc
[modify] https://crrev.com/f59c9a00965c9f3b43a3c549a56cf1eb40de1503/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl_unittest.cc
Project Member

Comment 100 by bugdroid1@chromium.org, Oct 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85b48fe0fd3ddfe879689db454b9f6ffca1e2366

commit 85b48fe0fd3ddfe879689db454b9f6ffca1e2366
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Mon Oct 08 09:49:23 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/extensions/api/networking_private/networking_private_service_client_apitest.cc.

This CL was uploaded by git cl split.

R=stevenjb@chromium.org

Bug:  809610 
Change-Id: I26aafd6d9606d08a4052fada37728aeb7a513975
Reviewed-on: https://chromium-review.googlesource.com/c/1258907
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597509}
[modify] https://crrev.com/85b48fe0fd3ddfe879689db454b9f6ffca1e2366/chrome/browser/extensions/api/networking_private/networking_private_service_client_apitest.cc
Project Member

Comment 101 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afb366026d464d1acaf073d96a3b28f50e7afad9

commit afb366026d464d1acaf073d96a3b28f50e7afad9
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Wed Oct 10 13:47:28 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/chromeos/arc/fileapi.

This CL was uploaded by git cl split.

R=hashimoto@chromium.org

Bug:  809610 
Change-Id: I4105e62e8f782e621d70e8146f1ea61c514563e6
Reviewed-on: https://chromium-review.googlesource.com/c/1257839
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598307}
[modify] https://crrev.com/afb366026d464d1acaf073d96a3b28f50e7afad9/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_async_file_util_unittest.cc
[modify] https://crrev.com/afb366026d464d1acaf073d96a3b28f50e7afad9/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc
[modify] https://crrev.com/afb366026d464d1acaf073d96a3b28f50e7afad9/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root_unittest.cc
Project Member

Comment 102 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/602835ba62b1491ea9a3282c2146220c0f4c1775

commit 602835ba62b1491ea9a3282c2146220c0f4c1775
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Wed Oct 10 14:06:37 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/search.

This CL was uploaded by git cl split.

R=sfiera@chromium.org

Bug:  809610 
Change-Id: I0c1c2fb65c2fd0568f9a9434a7ee7ee08c2a526e
Reviewed-on: https://chromium-review.googlesource.com/c/1258765
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598309}
[modify] https://crrev.com/602835ba62b1491ea9a3282c2146220c0f4c1775/chrome/browser/ui/search/local_ntp_doodle_browsertest.cc
[modify] https://crrev.com/602835ba62b1491ea9a3282c2146220c0f4c1775/chrome/browser/ui/search/local_ntp_one_google_bar_browsertest.cc
[modify] https://crrev.com/602835ba62b1491ea9a3282c2146220c0f4c1775/chrome/browser/ui/search/search_ipc_router_unittest.cc
[modify] https://crrev.com/602835ba62b1491ea9a3282c2146220c0f4c1775/chrome/browser/ui/search/search_tab_helper_unittest.cc
Project Member

Comment 103 by bugdroid1@chromium.org, Oct 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/212b4b0063f80b762dadcb676d972d9601f50c5c

commit 212b4b0063f80b762dadcb676d972d9601f50c5c
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 11 16:32:05 2018

Provide RAII to install GCMProfileServiceFactory test factory

Define a new helper class to register and unregister the test
factory to use in GCMProfileServiceFactory. It uses RAII to
ensure the factory is properly unregistered during the test
cleanup.

Bug:  809610 
Change-Id: Iec5457b6372ea23d33f3a07de894c33100f7d9e0
Reviewed-on: https://chromium-review.googlesource.com/c/1261123
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598798}
[modify] https://crrev.com/212b4b0063f80b762dadcb676d972d9601f50c5c/chrome/browser/extensions/api/instance_id/instance_id_apitest.cc
[modify] https://crrev.com/212b4b0063f80b762dadcb676d972d9601f50c5c/chrome/browser/extensions/service_worker_apitest.cc
[modify] https://crrev.com/212b4b0063f80b762dadcb676d972d9601f50c5c/chrome/browser/gcm/gcm_profile_service_factory.cc
[modify] https://crrev.com/212b4b0063f80b762dadcb676d972d9601f50c5c/chrome/browser/gcm/gcm_profile_service_factory.h
[modify] https://crrev.com/212b4b0063f80b762dadcb676d972d9601f50c5c/chrome/browser/push_messaging/push_messaging_browsertest.cc
Project Member

Comment 104 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/434568b67f191e9963fd396907cc664e9cf4b313

commit 434568b67f191e9963fd396907cc664e9cf4b313
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Tue Oct 16 17:09:06 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/apps/platform_apps/api/easy_unlock_private.

This CL was uploaded by git cl split.

R=jhawkins@chromium.org

Bug:  809610 
Change-Id: I491e41bd7735ed3a940594eb11f88542dcc0e3e5
Reviewed-on: https://chromium-review.googlesource.com/c/1258906
Reviewed-by: James Hawkins <jhawkins@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600025}
[modify] https://crrev.com/434568b67f191e9963fd396907cc664e9cf4b313/chrome/browser/apps/platform_apps/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc
Project Member

Comment 105 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/051d36105dc4894d8e33acc3adc60ed4b4ff9b16

commit 051d36105dc4894d8e33acc3adc60ed4b4ff9b16
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Tue Oct 16 17:10:08 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//extensions/browser/api/lock_screen_data.

This CL was uploaded by git cl split.

R=rkc@chromium.org

Bug:  809610 
Change-Id: Id88e7e119165588735fe1032a95af99b71caf706
Reviewed-on: https://chromium-review.googlesource.com/c/1259029
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600026}
[modify] https://crrev.com/051d36105dc4894d8e33acc3adc60ed4b4ff9b16/extensions/browser/api/lock_screen_data/lock_screen_item_storage_unittest.cc
Project Member

Comment 106 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fd05fc144b94a04f3e310d4646a898c12c909b9

commit 0fd05fc144b94a04f3e310d4646a898c12c909b9
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Tue Oct 16 17:10:27 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/renderer_context_menu.

This CL was uploaded by git cl split.

R=avi@chromium.org

Bug:  809610 
Change-Id: Ib7d5220acd85a864cea773ed2a6ca66611beaf66
Reviewed-on: https://chromium-review.googlesource.com/c/1259031
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600027}
[modify] https://crrev.com/0fd05fc144b94a04f3e310d4646a898c12c909b9/chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc
Project Member

Comment 107 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96434bf7d270bac9343b39ddfba4a01c0b4952d9

commit 96434bf7d270bac9343b39ddfba4a01c0b4952d9
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Tue Oct 16 19:13:37 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/views/frame.

This CL was uploaded by git cl split.

R=pkasting@chromium.org

Bug:  809610 
Change-Id: Ib6b3670ddcac53d42e955d4cb51596b9f194e39a
Reviewed-on: https://chromium-review.googlesource.com/c/1258767
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600070}
[modify] https://crrev.com/96434bf7d270bac9343b39ddfba4a01c0b4952d9/chrome/browser/ui/views/frame/test_with_browser_view.cc
Project Member

Comment 108 by bugdroid1@chromium.org, Oct 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef240e7be59eb02d4bb012b807e18fdf74caffb8

commit ef240e7be59eb02d4bb012b807e18fdf74caffb8
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Wed Oct 17 09:27:40 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/extensions/api/networking_private/networking_private_apitest.cc.

This CL was uploaded by git cl split.

R=tbarzic@chromium.org

Bug:  809610 
Change-Id: Id109a7d2bf008951e3a1ad9bf6370a281523c515
Reviewed-on: https://chromium-review.googlesource.com/c/1258354
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600324}
[modify] https://crrev.com/ef240e7be59eb02d4bb012b807e18fdf74caffb8/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc
Project Member

Comment 109 by bugdroid1@chromium.org, Oct 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cfef8e00f8fbaf676a9d1ea8dd4c6b493e328c1

commit 5cfef8e00f8fbaf676a9d1ea8dd4c6b493e328c1
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Wed Oct 17 09:31:36 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/ash/multi_user.

This CL was uploaded by git cl split.

R=skuhne@chromium.org

Bug:  809610 
Change-Id: Iee592c3978d52e0f213f2cb752cd4317bcd65b21
Reviewed-on: https://chromium-review.googlesource.com/c/1258764
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600325}
[modify] https://crrev.com/5cfef8e00f8fbaf676a9d1ea8dd4c6b493e328c1/chrome/browser/ui/ash/multi_user/multi_user_util_chromeos_unittest.cc
Project Member

Comment 110 by bugdroid1@chromium.org, Oct 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8ee8deed86814cc910e8101c1e8a80b91ff0040

commit e8ee8deed86814cc910e8101c1e8a80b91ff0040
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Wed Oct 17 09:38:48 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//extensions/browser/api/idle.

This CL was uploaded by git cl split.

R=dcheng@chromium.org

Bug:  809610 
Change-Id: I6799d0c1c8e61ccfa4fb5c07155deb4258a22e85
Reviewed-on: https://chromium-review.googlesource.com/c/1259045
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600328}
[modify] https://crrev.com/e8ee8deed86814cc910e8101c1e8a80b91ff0040/extensions/browser/api/idle/idle_api_unittest.cc
Project Member

Comment 111 by bugdroid1@chromium.org, Oct 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ac699ea5097cbedcd35da291ec56ce06d0a7b43

commit 9ac699ea5097cbedcd35da291ec56ce06d0a7b43
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Wed Oct 17 09:52:10 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/chrome_content_browser_client_unittest.cc.

This CL was uploaded by git cl split.

R=<anyone>

Bug:  809610 
Change-Id: I845dacbc5ee28e89ab69bf2bebaf5700f931b6fb
Reviewed-on: https://chromium-review.googlesource.com/c/1258170
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600332}
[modify] https://crrev.com/9ac699ea5097cbedcd35da291ec56ce06d0a7b43/chrome/browser/chrome_content_browser_client_unittest.cc
Project Member

Comment 112 by bugdroid1@chromium.org, Oct 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62dfc8ce1edfb09ff72d5a92a2c245ed25e1ffc3

commit 62dfc8ce1edfb09ff72d5a92a2c245ed25e1ffc3
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Wed Oct 17 10:00:35 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/safe_browsing.

This CL was uploaded by git cl split.

R=nparker@chromium.org

Bug:  809610 
Change-Id: I95c33ffc6a6d7699e0c1813ea7f760b7a9654d83
Reviewed-on: https://chromium-review.googlesource.com/c/1259043
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600333}
[modify] https://crrev.com/62dfc8ce1edfb09ff72d5a92a2c245ed25e1ffc3/chrome/browser/safe_browsing/advanced_protection_status_manager_unittest.cc
[modify] https://crrev.com/62dfc8ce1edfb09ff72d5a92a2c245ed25e1ffc3/chrome/browser/safe_browsing/chrome_password_protection_service_browsertest.cc
[modify] https://crrev.com/62dfc8ce1edfb09ff72d5a92a2c245ed25e1ffc3/chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc
[modify] https://crrev.com/62dfc8ce1edfb09ff72d5a92a2c245ed25e1ffc3/chrome/browser/safe_browsing/download_protection/download_protection_service_unittest.cc
Project Member

Comment 113 by bugdroid1@chromium.org, Oct 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b8beba6f11637e5fabbf54baa876a30e29b4b93

commit 3b8beba6f11637e5fabbf54baa876a30e29b4b93
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Wed Oct 17 10:02:33 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/extensions/api/gcm.

This CL was uploaded by git cl split.

R=jianli@chromium.org

Bug:  809610 
Change-Id: I2467157d104d74299ab12f1ced3bbe0245a48b68
Reviewed-on: https://chromium-review.googlesource.com/c/1258905
Reviewed-by: Jian Li <jianli@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600334}
[modify] https://crrev.com/3b8beba6f11637e5fabbf54baa876a30e29b4b93/chrome/browser/extensions/api/gcm/gcm_apitest.cc
Project Member

Comment 114 by bugdroid1@chromium.org, Oct 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa193def16e7e93cb6bcfee6a3adf0bf57a9ff08

commit aa193def16e7e93cb6bcfee6a3adf0bf57a9ff08
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 18 15:10:59 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//extensions/browser/api/sockets_udp.

This CL was uploaded by git cl split.

R=rkc@chromium.org

Bug:  809610 
Change-Id: Id800ae4bd2e053483b447457cd78cb50657d8ace
Reviewed-on: https://chromium-review.googlesource.com/c/1259032
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600762}
[modify] https://crrev.com/aa193def16e7e93cb6bcfee6a3adf0bf57a9ff08/extensions/browser/api/sockets_udp/sockets_udp_api_unittest.cc
Project Member

Comment 115 by bugdroid1@chromium.org, Oct 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d4efbea584ecfcb94cbdb4df6734573c65717a9

commit 5d4efbea584ecfcb94cbdb4df6734573c65717a9
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 18 15:23:50 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/dom_distiller.

This CL was uploaded by git cl split.

R=bengr@chromium.org

Bug:  809610 
Change-Id: I30fc5cf421d359ac3072b38b940a783737e66f38
Reviewed-on: https://chromium-review.googlesource.com/c/1259023
Reviewed-by: Ben Greenstein <bengr@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600765}
[modify] https://crrev.com/5d4efbea584ecfcb94cbdb4df6734573c65717a9/chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc

Comment 116 by carlosk@chromium.org, Oct 18

Cc: -carl...@google.com
Project Member

Comment 117 by bugdroid1@chromium.org, Oct 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ea43a09326f0c0fde14da3e669559af4e09fbdf

commit 2ea43a09326f0c0fde14da3e669559af4e09fbdf
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Mon Oct 22 17:42:21 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/themes.

This CL was uploaded by git cl split.

R=pkotwicz@chromium.org

Bug:  809610 
Change-Id: I66ee3e218e4333f6d704e64b58003f100f1364e9
Reviewed-on: https://chromium-review.googlesource.com/c/1258352
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601635}
[modify] https://crrev.com/2ea43a09326f0c0fde14da3e669559af4e09fbdf/chrome/browser/themes/theme_syncable_service_unittest.cc
Project Member

Comment 118 by bugdroid1@chromium.org, Oct 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50ff782ea54a72162d479634088516802f0d96be

commit 50ff782ea54a72162d479634088516802f0d96be
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Mon Oct 22 17:46:31 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//extensions/browser/api/display_source.

This CL was uploaded by git cl split.

R=alexander.shalamov@intel.com

Bug:  809610 
Change-Id: I0296a88846eed33c92d7baa74217e845218f3bf5
Reviewed-on: https://chromium-review.googlesource.com/c/1257937
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601638}
[modify] https://crrev.com/50ff782ea54a72162d479634088516802f0d96be/extensions/browser/api/display_source/display_source_apitestbase.cc
Project Member

Comment 119 by bugdroid1@chromium.org, Oct 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9afa0fc358143f1829aef8d25d89e6aa43d067b6

commit 9afa0fc358143f1829aef8d25d89e6aa43d067b6
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Mon Oct 22 17:54:54 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/browsing_data.

This CL was uploaded by git cl split.

R=markusheintz@chromium.org

Bug:  809610 
Change-Id: Ie7a9a867b2214dd56e7c54fcf8328dc02cc0b4ea
Reviewed-on: https://chromium-review.googlesource.com/c/1258361
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601643}
[modify] https://crrev.com/9afa0fc358143f1829aef8d25d89e6aa43d067b6/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
Project Member

Comment 120 by bugdroid1@chromium.org, Oct 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/094b89d6c387c438cee2799cc6336c72c368bc4e

commit 094b89d6c387c438cee2799cc6336c72c368bc4e
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Mon Oct 22 17:55:22 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

Remove the RecentModelFactory::SetForProfileAndUseForTest
method as it pass a std::unique_ptr<> object to return from
the factory which is difficult to adapt to the new API that
requires a base::RepeatingCallback<>.

Instead inline the implementation in the sole unit test that
called this method and modify it to pass a factory returning
a std::vector<std::unique_ptr<RecentModel>>.

This converts uses in src//chrome/browser/chromeos/fileapi.

This CL was uploaded by git cl split.

R=slangley@chromium.org

Bug:  809610 
Change-Id: Idb8bae335e3defca5b2c6736d302586faf97d929
Reviewed-on: https://chromium-review.googlesource.com/c/1259014
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601644}
[modify] https://crrev.com/094b89d6c387c438cee2799cc6336c72c368bc4e/chrome/browser/chromeos/fileapi/recent_arc_media_source_unittest.cc
[modify] https://crrev.com/094b89d6c387c438cee2799cc6336c72c368bc4e/chrome/browser/chromeos/fileapi/recent_model_factory.cc
[modify] https://crrev.com/094b89d6c387c438cee2799cc6336c72c368bc4e/chrome/browser/chromeos/fileapi/recent_model_factory.h
[modify] https://crrev.com/094b89d6c387c438cee2799cc6336c72c368bc4e/chrome/browser/chromeos/fileapi/recent_model_unittest.cc
Project Member

Comment 121 by bugdroid1@chromium.org, Oct 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a66aa4482af064154956006ca31cbdbf77a4eef6

commit a66aa4482af064154956006ca31cbdbf77a4eef6
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Wed Oct 24 17:31:26 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/supervised_user.

This CL was uploaded by git cl split.

R=pam@chromium.org

Bug:  809610 
Change-Id: I702004601120d3c855ec3a1b1670358ee9b57fa8
Reviewed-on: https://chromium-review.googlesource.com/c/1297414
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602379}
[modify] https://crrev.com/a66aa4482af064154956006ca31cbdbf77a4eef6/chrome/browser/supervised_user/child_accounts/child_account_service_unittest.cc
Project Member

Comment 122 by bugdroid1@chromium.org, Oct 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/573243127b11df1e69049ea48352780a7e0e0ced

commit 573243127b11df1e69049ea48352780a7e0e0ced
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Wed Oct 24 17:42:53 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/safe_browsing.

This CL was uploaded by git cl split.

R=nparker@chromium.org

Bug:  809610 
Change-Id: I880627bdc67561e465ef16eae0bf1d3ad66c234d
Reviewed-on: https://chromium-review.googlesource.com/c/1297415
Reviewed-by: Nathan Parker <nparker@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602385}
[modify] https://crrev.com/573243127b11df1e69049ea48352780a7e0e0ced/chrome/browser/safe_browsing/download_protection/download_protection_service_unittest.cc
Project Member

Comment 123 by bugdroid1@chromium.org, Oct 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15f3ea1ac1ed50d187a31b46f8cff40f2257f148

commit 15f3ea1ac1ed50d187a31b46f8cff40f2257f148
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 25 16:28:48 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//components/arc.

This CL was uploaded by git cl split.

R=hidehiko@chromium.org

Bug:  809610 
Change-Id: I3ebf3890b470a03e517a5c512bfc90d96bcba15c
Reviewed-on: https://chromium-review.googlesource.com/c/1298195
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602738}
[modify] https://crrev.com/15f3ea1ac1ed50d187a31b46f8cff40f2257f148/components/arc/arc_browser_context_keyed_service_factory_base.h
Project Member

Comment 124 by bugdroid1@chromium.org, Oct 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/683bcd0f1e7d53ae8822be760cda95584fd0bac4

commit 683bcd0f1e7d53ae8822be760cda95584fd0bac4
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 25 16:29:32 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/offline_pages.

This CL was uploaded by git cl split.

R=carlosk@chromium.org

Bug:  809610 
Change-Id: I6c24c769f8a87f98eb98bc6fa7e080f5eb1353fc
Reviewed-on: https://chromium-review.googlesource.com/c/1297979
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602739}
[modify] https://crrev.com/683bcd0f1e7d53ae8822be760cda95584fd0bac4/chrome/browser/offline_pages/offline_page_auto_fetcher_unittest.cc
Project Member

Comment 125 by bugdroid1@chromium.org, Oct 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61c5978cc8a9f368a057464a2d34ef8f881a96cb

commit 61c5978cc8a9f368a057464a2d34ef8f881a96cb
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 25 16:44:15 2018

Convert indirect uses of TestingFactoryFunction

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/signin.

This CL was uploaded by git cl split.

R=droger@chromium.org

Bug:  809610 
Change-Id: I809c0bcb31b04db3fb1f43b93952348a4ba1d93d
Reviewed-on: https://chromium-review.googlesource.com/c/1297134
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602751}
[modify] https://crrev.com/61c5978cc8a9f368a057464a2d34ef8f881a96cb/chrome/browser/signin/force_signin_verifier_unittest.cc
Project Member

Comment 126 by bugdroid1@chromium.org, Oct 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fba5700fc98ee2a666f7fb9b054e5724c0ffdd80

commit fba5700fc98ee2a666f7fb9b054e5724c0ffdd80
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Fri Oct 26 16:13:11 2018

Remove deprecated method of BCKSF

All clients of BCKSF uses the new API taking a base::Callback<>
instead of the deprecated API that was using a raw function
pointer.

Remove the now obsolete deprecated API.

Bug:  809610 
Change-Id: I18359b2f91a1a6d9445affcf4720eed528d74af3
Reviewed-on: https://chromium-review.googlesource.com/c/1297354
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603106}
[modify] https://crrev.com/fba5700fc98ee2a666f7fb9b054e5724c0ffdd80/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/fba5700fc98ee2a666f7fb9b054e5724c0ffdd80/chrome/test/base/testing_profile.h
[modify] https://crrev.com/fba5700fc98ee2a666f7fb9b054e5724c0ffdd80/components/keyed_service/content/browser_context_keyed_service_factory.cc
[modify] https://crrev.com/fba5700fc98ee2a666f7fb9b054e5724c0ffdd80/components/keyed_service/content/browser_context_keyed_service_factory.h
[modify] https://crrev.com/fba5700fc98ee2a666f7fb9b054e5724c0ffdd80/components/keyed_service/content/refcounted_browser_context_keyed_service_factory.cc
[modify] https://crrev.com/fba5700fc98ee2a666f7fb9b054e5724c0ffdd80/components/keyed_service/content/refcounted_browser_context_keyed_service_factory.h

Comment 127 by sdefresne@chromium.org, Oct 26

Status: Fixed (was: Started)
Showing comments 28 - 127 of 127 Older ›
►

Sign in to add a comment