New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 809578 link

Starred by 4 users
Status: Verified
Owner:
█ bhthompson@chromium.org
Last visit > 30 days ago
Closed: Feb 2018
Cc:
perezju@chromium.org
█ pho...@chromium.org
xixuan@chromium.org
█ josa...@chromium.org
achuith@chromium.org
ihf@chromium.org
█ bhthompson@chromium.org
saintlou@google.com
josa...@google.com
puneetster@google.com
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 0
Type: Bug



Sign in to add a comment

R65 Branch Failing Autotests

Project Member Reported by bhthompson@google.com, Feb 6 2018 
https://cros-goldeneye.corp.google.com/chromeos/console/viewBuild?version=10323.17.0&channel=dev&type=release has many failures

https://stainless.corp.google.com/search?exclude_retried=true&first_date=2018-01-31&master_builder_name=%5Emaster%5C-release%5C+release%5C-R65%5C-10323%5C.B%24&builder_name_number=&shard=&exclude_acts=true&builder_name=%5Easuka%5C-release%5C+release%5C-R65%5C-10323%5C.B%24&master_builder_name_number=%5Emaster%5C-release%5C+release%5C-R65%5C-10323%5C.B%5C%2F16%24&owner=&retry=&exclude_cts=false&exclude_non_production=true&hostname=&board=&test=&exclude_not_run=false&build=&status=FAIL&status=ERROR&status=ABORT&reason=&waterfall=&suite=&last_date=2018-02-06&exclude_non_release=false&exclude_au=true&model=&view=list looks like these are all TypeError

https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/174874507-chromeos-test/chromeos6-row1-rack22-host5/debug/ digging into one:
...
02/06 05:11:40.901 ERROR|   logging_manager:0626| tko parser: parsing partial test security_SandboxStatus security_SandboxStatus
02/06 05:11:40.902 ERROR|   logging_manager:0626| tko parser: RUNNING: RUNNING
02/06 05:11:40.902 ERROR|   logging_manager:0626| Subdir: security_SandboxStatus
02/06 05:11:40.903 ERROR|   logging_manager:0626| Testname: security_SandboxStatus
02/06 05:11:40.903 ERROR|   logging_manager:0626| 
02/06 05:11:40.903 ERROR|   logging_manager:0626| tko parser: update RUNNING reason: Unhandled TypeError: Create() takes exactly 1 argument (2 given)
02/06 05:11:40.904 ERROR|   logging_manager:0626| tko parser: parsing test security_SandboxStatus security_SandboxStatus
02/06 05:11:40.904 ERROR|   logging_manager:0626| tko parser: ADD: FAIL
02/06 05:11:40.905 ERROR|   logging_manager:0626| Subdir: security_SandboxStatus
02/06 05:11:40.905 ERROR|   logging_manager:0626| Testname: security_SandboxStatus
02/06 05:11:40.905 ERROR|   logging_manager:0626| Unhandled TypeError: Create() takes exactly 1 argument (2 given)
02/06 05:11:40.906 ERROR|   logging_manager:0626| tko parser: parsing test None CLIENT_JOB.0
02/06 05:11:40.906 ERROR|   logging_manager:0626| tko parser: ADD: GOOD
02/06 05:11:40.907 ERROR|   logging_manager:0626| Subdir: None
02/06 05:11:40.907 ERROR|   logging_manager:0626| Testname: CLIENT_JOB.0
...

The CL range is:
https://crosland.corp.google.com/log/10323.14.0..10323.17.0

This does not appear to be happening on ToT.

It is not clear if the test failures are legitimate, it looks like something broke autotest. Still trying to narrow down where the error happened, the line after the unhandled type error appears to be https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/tko/models.py?rcl=dcb1a82fc2672c8fa21a2dc2d5b92867ca5a173d&l=162

Comment 1 by josa...@chromium.org, Feb 6 2018

Cc: pho...@chromium.org xixuan@chromium.org
Labels: M-65
+infra deputies

Comment 2 by bhthompson@google.com, Feb 6 2018

Cc: perezju@chromium.org
Owner: achuith@chromium.org
This looks more actionable https://00e9e64bac506d6d1dc935d8739c238e512c08124eb81907a0-apidata.googleusercontent.com/download/storage/v1/b/chromeos-autotest-results/o/174874507-chromeos-test%2Fchromeos6-row1-rack22-host5%2Fdebug%2Fclient.0.DEBUG?qk=AD5uMEuI8ycARv6DAHMfVHVo9ztD_4iYBhBBJ6rycRLZxYee12WB-zyi5nfvkIudagIRgmznKO27UE_cLSkQ7PMMgJ2TdmpoVgj8wJou0rXeAmP4DXJzFdJA34LtQPgyEwP8jOEHZZyqX8rr5ruEU-Z96fdT1lS_BCRWr_IU3XjfbhZyXjKj50J2ae0FhYwY--tk4Ru4FnzG2J5Je3xsao54K1EBPRJW__7745sqIFHS4mBBCcS5SvnG9zcy0-AiOmhysEcWTC4GALhh34rXvEyjI3v2RDXePHSlyTTBEFUkHwpeuZBVyUXXMWkTyX_G-GSkHa1ecj6rtGNf96m7z5wZ93UpMTWF1XxdeMdjnfeyYZ5uuWGNHI6DD7ofBdwZ0HUGXi5uRExLggcZSgNTdmwUG126lXtPrY9Ms03OfcV86aHz0iA0FKhWTHNyVIrO47HkLTA5T_lQ7MVZ41LfzxG8xYXfdSvJjJxbWExiayZxubPAW8i6pASMliY80nHToCLrZdzpCtfXnw2g5mn0qu7QrvcKOoRWEQwvtJyL2gKSktwv_-8b0AeBAb_1D92bBDIr7ymfUyW-7UBzNj-Pysy_-jMv7KFsu_gvdj9qvi3mDRzQzYavXQv6NhTyZKt0ilaEBZGEixv9AITtHWDszgCLyYmB7LCuu2oz9ASOOdbi8i5lYVG5IYHUChyB9q4MPgMdUtEQNMzQBGlc0cZ0rg9mQeOXx6KVRsnxtjCZUTlZyduvKNMj2s6eH-GJn5PYhRM2y67DUNnuI7xX3QAOjhKi425sfV57ResjEauWSj6AT04PApWUUNDkW2y87pF39jBo7LHjAKgisz3MODYOBeD1YMP3moSJ6g
...
02/06 05:11:31.950 WARNI|              test:0637| The test failed with the following exception
Traceback (most recent call last):
  File "/usr/local/autotest/common_lib/test.py", line 631, in _exec
    _call_test_function(self.execute, *p_args, **p_dargs)
  File "/usr/local/autotest/common_lib/test.py", line 837, in _call_test_function
    raise error.UnhandledTestFail(e)
UnhandledTestFail: Unhandled TypeError: Create() takes exactly 1 argument (2 given)
Traceback (most recent call last):
  File "/usr/local/autotest/common_lib/test.py", line 831, in _call_test_function
    return func(*args, **dargs)
  File "/usr/local/autotest/common_lib/test.py", line 495, in execute
    dargs)
  File "/usr/local/autotest/common_lib/test.py", line 362, in _call_run_once_with_retry
    postprocess_profiled_run, args, dargs)
  File "/usr/local/autotest/common_lib/test.py", line 400, in _call_run_once
    self.run_once(*args, **dargs)
  File "/usr/local/autotest/tests/security_SandboxStatus/security_SandboxStatus.py", line 58, in run_once
    with chrome.Chrome() as cr:
  File "/usr/local/autotest/common_lib/cros/chrome.py", line 171, in __init__
    self._browser = browser_to_create.Create(finder_options)
TypeError: Create() takes exactly 1 argument (2 given)
...

It looks like this might be related to a recent ToT change https://chromium-review.googlesource.com/#/c/chromiumos/third_party/autotest/+/881308/

I am wondering if picking this into the branch will help?

Comment 3 by bhthompson@google.com, Feb 6 2018 

It looks like autotest depends on telemetry which seems like it might be on the Chrome side, and part of the Catapult package, which was revved recently by https://chrome-internal-review.googlesource.com/#/c/chrome/tools/buildspec/+/560678/

This appears to be the most smoking gun so far.

Comment 4 by perezju@chromium.org, Feb 6 2018 

Indeed, this should be fixed by cherry-picking http://crrev.com/c/881308 into your branch.

Comment 5 by bhthompson@google.com, Feb 6 2018 

Ok we can merge that, I will kick off another build once it lands. 

The Catapult roll only applied to 65 right? (want to ensure 64 is ok)

Comment 6 by perezju@chromium.org, Feb 6 2018 

Correct, 64 should be fine.

Comment 7 by achuith@chromium.org, Feb 6 2018

Cc: achuith@chromium.org
Owner: bhthompson@chromium.org
Assigning to Bernie for the merge.

Comment 8 by bhthompson@google.com, Feb 6 2018

Status: Fixed (was: Untriaged)
We are merged and I kicked off another build, hope is we are now fixed but we should know this evening.

Comment 10 by bhthompson@google.com, Feb 6 2018

Cc: bhthompson@chromium.org
 Issue 809698  has been merged into this issue.

Comment 11 by kathrelk...@chromium.org, Feb 7 2018

Cc: ihf@chromium.org
 Issue 809728  has been merged into this issue.

Comment 12 by bhthompson@google.com, Feb 7 2018

Status: Verified (was: Fixed)
Tests are passing on the new build.
►

Sign in to add a comment