add media control user actions |
|||
Issue descriptionPressing Eve's play/pause button does not currently record anything at chrome://user-actions Let's add tracker Accel_PlayPause for that button. warx@, are you the right owner for this?
,
Feb 7 2018
I also see, media next track and media previous track, shall we add user actions for those, too?
,
Feb 7 2018
Hmm where are those? I don't see them on my keyboard or shortcuts for them. (If you're using an EVT keyboard, there's some buttons that changed before production).
,
Feb 7 2018
It doesn't exist on keyboard. They could exist on wired headphones.
,
Feb 7 2018
Oh gotcha, yep let's add those too.
,
Feb 7 2018
The planned user actions are: Accel_Media_Next_Track Accel_Media_PlayPause Accel_Media_Prev_Track
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a4b1314ecb02b5a6a14df48621307faacf99815 commit 6a4b1314ecb02b5a6a14df48621307faacf99815 Author: Qiang Xu <warx@google.com> Date: Wed Feb 07 18:54:38 2018 cros: add media controls user actions changes: This CL adds the following user actions to record: Accel_Media_Next_Track Accel_Media_PlayPause Accel_Media_Prev_Track Bug: 809575 Test: tested on device, see actions on chrome://user-actions Change-Id: I8e7000c7489fe58eac830cfcd5fb51bf3a22f16e Reviewed-on: https://chromium-review.googlesource.com/905935 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#535080} [modify] https://crrev.com/6a4b1314ecb02b5a6a14df48621307faacf99815/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/6a4b1314ecb02b5a6a14df48621307faacf99815/tools/metrics/actions/actions.xml
,
Feb 7 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by warx@chromium.org
, Feb 6 2018