Error when dumping sync nodes to a file at chrome://sync-internals/ |
||||||||
Issue descriptionChrome Version: 64.0.3282.140 (Official Build) (64-bit) OS: Linux What steps will reproduce the problem? (1) Navigate to chrome://sync-internals/ (2) Go to the "Data" tab. (3) Select "Autofill" or "Device Info" or "User Events" (4) Click the "Dump sync nodes to file" button What is the expected result? A file should be downloaded with the contents of the sync nodes What happens instead? Error is thrown in the console Cannot read property 'slice' of undefined The issue seems to be that in https://cs.chromium.org/chromium/src/components/sync/driver/resources/data.js?l=71&rcl=9030625190ec0a2b60be2af279bcb234f47d3f51 var version = node['BASE_VERSION']; returns unknown. Probably those data type nodes are missing a "BASE_VERSION" field.
,
Feb 6 2018
,
Feb 19 2018
,
Feb 19 2018
I think those 3 types have been migrated to USS. Not sure if there is a connection.
,
Jul 5
,
Jul 5
,
Jul 5
Tentatively assigning to melandory@.
,
Jul 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52ab194d449080e8481d1e5f39dc7e9993b9a81a commit 52ab194d449080e8481d1e5f39dc7e9993b9a81a Author: Tanja Gornak <melandory@chromium.org> Date: Mon Jul 16 09:13:52 2018 Fix the error when dumping sync nodes to a file at chrome://sync-internals/ Proper fix should populate missing data in nodes. For the time being let's just check that the data isn't there. Bug: 809558 Change-Id: I31a97b3c332c309ebd3cab15e5fa0c1575d5c711 Reviewed-on: https://chromium-review.googlesource.com/1136534 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#575208} [modify] https://crrev.com/52ab194d449080e8481d1e5f39dc7e9993b9a81a/components/sync/driver/resources/data.js
,
Jul 17
Unable to reproduce the issue on ubuntu 17.10 and win-10 using chrome reported version #64.0.3282.140 as per comment #0. Attached a screen cast for reference. Observed that a file got downloaded with the contents of the sync nodes as expected. Hence, was unable to verify the fix on latest chrome version #69.0.3494.0 melandory@ - Could you please check the attached screen cast and please let us know if anything missed from our end. Thanks...!!
,
Jul 17
Since I am the original reporter, I can still repro on Version 67.0.3396.99 (Official Build) (64-bit) I think what's missing is to be signed in to Chrome. Sorry for not adding this in the original bug description.
,
Aug 27
Interesting, will take a look.
,
Aug 27
@melandory@chromium.org: my comment was a reply to krajshree@chromium.org. not you because he couldn't repro. IIUC, no need to investigate.
,
Oct 1
I will close this bug since the solution is appropriate for now. It's not clear if USS data types would actually have the missing fields. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by mamir@chromium.org
, Feb 6 2018