DidFinishNavigation() is not called if the load is rejected by ShouldAllowResponse |
||||
Issue descriptionNavigationAndLoadCallbacksTest.DisallowResponse test demonstrates the bug
,
Mar 1 2018
,
Mar 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf7702c8359306643d7858fa37019af4ebe62812 commit cf7702c8359306643d7858fa37019af4ebe62812 Author: Mohammad Refaat <mrefaat@chromium.org> Date: Mon Mar 19 19:28:51 2018 Add missing DidFinishNavigation call Fix Error handling, so didFinishNavigation is called when a response is canceled. BUG= 809557 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icee04cd3bcf10110bc7d53a62df2234bc3065050 Reviewed-on: https://chromium-review.googlesource.com/959590 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#544114} [modify] https://crrev.com/cf7702c8359306643d7858fa37019af4ebe62812/ios/web/public/web_state/navigation_context.h [modify] https://crrev.com/cf7702c8359306643d7858fa37019af4ebe62812/ios/web/web_state/navigation_and_load_callbacks_inttest.mm [modify] https://crrev.com/cf7702c8359306643d7858fa37019af4ebe62812/ios/web/web_state/ui/crw_web_controller.mm
,
Mar 19 2018
,
Mar 19 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by eugene...@chromium.org
, Mar 1 2018