Issue metadata
Sign in to add a comment
|
14.4%-17.6% regression in blink_perf.canvas at 533906:533985 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Feb 6 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/16922069840000
,
Feb 9 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/16922069840000 [ArrayBuffer] Give each SecurityOrigin a Partition for ArrayBuffers. by bbudge@chromium.org chromium @ eaa730ff5abd585b0b629f07406df6701589e7ff Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Feb 9 2018
This looks like a significant performance regression. It is likely the overhead of converting the isolate to a SecurityOrigin. Long term, we probably want V8 to provide extra information to speed up the association of ArrayBuffers with SecurityOrigins. There is ongoing debate in V8 about whether typed arrays and ArrayBuffers should be off-heap or on-heap (right now we have a combination of both.) Since that will take time to resolve, I think the right thing to do is revert this for now. I'll prepare the revert CL.
,
Feb 9 2018
Alternately, I could try to fix this slowdown by simplifying getting the key that maps allocations to partitions. Would isolate->context() or isolate->native_context() be equivalent?
,
Mar 19 2018
Regressing patch was reverted. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Feb 6 2018