New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 809546 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

14.4%-17.6% regression in blink_perf.canvas at 533906:533985

Project Member Reported by kraynov@chromium.org, Feb 6 2018

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=809546

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=19aaa105f8d4bb887412fa5e30481452f0f3d5b5acf6fcc0ddf9e521186d70a1


Bot(s) for this bug's original alert(s):

android-nexus6
chromium-rel-mac11-pro
Cc: haraken@chromium.org palmer@chromium.org bbudge@chromium.org
Owner: bbudge@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/16922069840000

[ArrayBuffer] Give each SecurityOrigin a Partition for ArrayBuffers. by bbudge@chromium.org
chromium @ eaa730ff5abd585b0b629f07406df6701589e7ff

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
This looks like a significant performance regression. It is likely the overhead of converting the isolate to a SecurityOrigin.

Long term, we probably want V8 to provide extra information to speed up the association of ArrayBuffers with SecurityOrigins. There is ongoing debate in V8 about whether typed arrays and ArrayBuffers should be off-heap or on-heap (right now we have a combination of both.) Since that will take time to resolve, I think the right thing to do is revert this for now.

I'll prepare the revert CL.
Alternately, I could try to fix this slowdown by simplifying getting the key that maps allocations to partitions. Would isolate->context() or isolate->native_context() be equivalent?

Comment 6 by bbudge@chromium.org, Mar 19 2018

Status: Fixed (was: Assigned)
Regressing patch was reverted.

Sign in to add a comment