New issue
Advanced search Search tips

Issue 809524 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

components_unittests StabilityDebuggingTest.CrashingTest fails under WinASan

Project Member Reported by h...@chromium.org, Feb 6 2018

Issue description

Example build: https://ci.chromium.org/buildbot/chromium.clang/CrWinAsan/311

This reproduces locally with pinned Clang as well, so it's not a Clang roll blocker.
 

Comment 1 by h...@chromium.org, Feb 6 2018

It's been red a long time; last green build was https://ci.chromium.org/buildbot/chromium.clang/CrWinAsan/150

Comment 2 by h...@chromium.org, Feb 6 2018

Cc: etienneb@chromium.org
Bisection points to the commit below.

Looking at the code, this suggests maybe we should just disable the test for Win ASan?


commit 5f4de1c7c6b8cfa5a8171ce30ab9c661f894f82a
Author: Etienne Bergeron <etienneb@chromium.org>
Date:   Tue Nov 21 20:08:56 2017 +0000

    Fix an infinite loop with ASAN instrumented build on windows.

    The vector exception code used by chrome is incompatible with ASAN 64.
    The following patch is commenting out the code when ASAN is present.

    See comment in the code for details.

    R=rnk@chromium.org, siggi@chromium.org, inferno@chromium.org

    Bug: 783296
    Change-Id: I8dbe192e658225840fe2249e99d9b84b518f558b
    Reviewed-on: https://chromium-review.googlesource.com/782399
    Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
    Commit-Queue: Abhishek Arya <inferno@chromium.org>
    Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#518354}
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8a57e6f64bd80866415085dca600c7669e994e6

commit d8a57e6f64bd80866415085dca600c7669e994e6
Author: Hans Wennborg <hans@chromium.org>
Date: Wed Feb 07 08:49:29 2018

Disable StabilityDebuggingTest.CrashingTest under WinASan

Bug:  809524 
Change-Id: Idb19580820a149899613ec2e4b0875ff1a8d2b21
Reviewed-on: https://chromium-review.googlesource.com/905306
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534952}
[modify] https://crrev.com/d8a57e6f64bd80866415085dca600c7669e994e6/components/browser_watcher/stability_debugging_win_unittest.cc

Comment 5 by h...@chromium.org, Feb 8 2018

Owner: h...@chromium.org
Status: Fixed (was: Available)
The bot is green: https://ci.chromium.org/buildbot/chromium.clang/CrWinAsan/315

Sign in to add a comment