Changes to tast-common don't trigger tast-{local,remote}-tests-cros uprevs |
||
Issue descriptionThe chromeos-base/tast-local-tests-cros and chromeos-base/tast-remote-tests-cros packages attempt to depend on chromeos-base/tast-common via a DEPEND var that gets set via tast-bundle.eclass. After https://crrev.com/c/900128 modified code that gets installed by tast-common, commit fc33becb in chromiumos-overlay marked the tast-common 9999 ebuild as stable but not the test package's ebuilds: commit fc33becb2fb07ccd68d84a375f2c5a2cd65a59c8 Author: chrome-bot <chrome-bot@chromium.org> Date: Sun Feb 4 20:43:13 2018 -0800 Marking set of ebuilds as stable regen cache Change-Id: If1ff292d5cd4f3ce282d260c061edc0027dccb39 Marking 9999 ebuild for chromeos-base/tast-common as stable. Marking 9999 ebuild for chromeos-base/tast-local-test-runner as stable. Marking 9999 ebuild for chromeos-base/tast-cmd as stable. Change-Id: I750c3af4652cce371ace8cd157ee28c69c91afd0 The last commit that updated the test packages was this one: commit 4b39f6556a5a732f6f8a5e90a8acc0cbe6538b82 Author: chrome-bot <chrome-bot@chromium.org> Date: Fri Feb 2 07:27:03 2018 -0800 Marking set of ebuilds as stable ... Marking 9999 ebuild for chromeos-base/tast-local-tests-cros as stable. ... Marking 9999 ebuild for chromeos-base/tast-remote-tests-cros as stable. Is setting DEPEND within tast-bundle.eclass expected to work? I assumed so, since there are a bunch of other eclass files that do it.
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/b911d71124769d6201da19ef08fbf347a59a22cd commit b911d71124769d6201da19ef08fbf347a59a22cd Author: Daniel Erat <derat@chromium.org> Date: Tue Feb 06 15:13:19 2018 tast-tests: Trivial docs update to trigger uprev. BUG= chromium:809518 TEST=none TBR=jclinton@chromium.org Change-Id: I165fc9ab3dcedb87717d3e2e1b3be3f2d305a3e7 Reviewed-on: https://chromium-review.googlesource.com/904433 Reviewed-by: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/b911d71124769d6201da19ef08fbf347a59a22cd/README.md
,
Feb 10 2018
Mike, do you have any ideas about what's going on here? equery lists the dependency correctly: $ equery g tast-remote-tests-cros ... * dependency graph for chromeos-base/tast-remote-tests-cros-9999 `-- chromeos-base/tast-remote-tests-cros-9999 unknown `-- dev-vcs/git-2.13.5 (dev-vcs/git) unknown `-- dev-lang/go-1.9.2-r1 (dev-lang/go) amd64 `-- chromeos-base/tast-common-9999 (chromeos-base/tast-common) unknown [ chromeos-base/tast-remote-tests-cros-9999 stats: packages (4), max depth (1) ]
,
Feb 10 2018
sorry, but what is it you want to happen ? a DEPEND setting has never been used to mark a package for uprevving. only changes to the respective ebuilds or the source repos they point to will trigger an uprev of an ebuild.
,
Feb 11 2018
I guess I didn't realize how this works. I'm not sure whether there are any benefits of having the tast-common package. Rahul, would I be better off removing tast-common and just making all of the tast-* packages include chromiumos/platform/tast in CROS_WORKON_PROJECT if they don't already? If my understanding is correct, the tast-common package doesn't buy us anything in terms of shorter compile times and also makes it so that packages that depend on it won't get automatically rebuilt when it's updated.
,
Feb 12 2018
if everything is statically linked, it makes sharing ebuilds harder. we do have some ebuild logic to try and trigger rebuilds, but it isn't an uprev, and there are some edge cases where it doesn't happen.
the only other option to provide more of a rebuild guarantee would be subslots. the tast-common package would have SLOT="0/${PVR}", and the packages that build against tast-common do so with a ":=" subslot dep.
,
Feb 12 2018
Yes, I think in this case you'd be better off just adding "chromiumos/platform/tast" in CROS_WORKON_PROJECT of all other ebuilds that need it. This way, every time "chromiumos/platform/tast" gets a new commit, all those ebuilds will get up-revved and re-built, just like you want. You can still keep the tast-common ebuild around for running tests (i.e. define CROS_GO_TEST in it, but not CROS_GO_PACKAGES so nothing gets installed). Maybe rename it to tast-common-tests. This way, you'd run the unit tests for these common packages only once instead of in every ebuild that imports them. What you'd lose is installation of these packages in the system-wide gopath in the chroot (/usr/lib/gopath). So if you're importing these packages from there as part of your local development workflow, it would need to change.
,
Feb 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ba511f8f689f1c529928241e4e49f6819cca9e5a commit ba511f8f689f1c529928241e4e49f6819cca9e5a Author: Daniel Erat <derat@chromium.org> Date: Fri Feb 16 01:42:33 2018 tast-common: Delete package. Remove the chromeos-base/tast-common package and instead make tast-{local,remote}-tests-cros use code directly from the main tast repository. This ensures that those packages will be uprev-ed in response to changes to the repo. The unit tests formerly built and run by tast-common are now pulled in by tast-cmd (for the host) and tast-local-test-runner (for various boards). BUG= chromium:809518 TEST=built all packages with FEATURES=test; also verified that dev workflow using fast_build.sh still works and that tests are built successfully by the tast command Change-Id: If807e6478707170f9948dc8dea2ffbc2e9c08a8c Reviewed-on: https://chromium-review.googlesource.com/916881 Commit-Ready: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Rahul Chaudhry <rahulchaudhry@chromium.org> [modify] https://crrev.com/ba511f8f689f1c529928241e4e49f6819cca9e5a/eclass/tast-bundle.eclass [delete] https://crrev.com/b86e1c5e35bfda9ce45553dac15d1f8468922e12/chromeos-base/tast-common/tast-common-9999.ebuild [modify] https://crrev.com/ba511f8f689f1c529928241e4e49f6819cca9e5a/chromeos-base/tast-remote-tests-cros/tast-remote-tests-cros-9999.ebuild [modify] https://crrev.com/ba511f8f689f1c529928241e4e49f6819cca9e5a/chromeos-base/tast-local-test-runner/tast-local-test-runner-9999.ebuild [delete] https://crrev.com/b86e1c5e35bfda9ce45553dac15d1f8468922e12/chromeos-base/tast-common/tast-common-0.0.1-r71.ebuild [modify] https://crrev.com/ba511f8f689f1c529928241e4e49f6819cca9e5a/chromeos-base/tast-local-tests-cros/tast-local-tests-cros-9999.ebuild [modify] https://crrev.com/ba511f8f689f1c529928241e4e49f6819cca9e5a/chromeos-base/tast-cmd/tast-cmd-9999.ebuild
,
Feb 16 2018
,
Feb 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0398f6f9c39ac4fb9042396d7738a793d92acc9d commit 0398f6f9c39ac4fb9042396d7738a793d92acc9d Author: Daniel Erat <derat@chromium.org> Date: Mon Feb 26 22:10:03 2018 tast-{cmd,local-test-runner}: Remove tast-common blockers. Make the tast-cmd and tast-local-test-runner no longer block the tast-common package. BUG= chromium:809518 TEST=none Change-Id: I3691b572b0fa0ac5fc8ebbf5231ca739a94a2ab0 Reviewed-on: https://chromium-review.googlesource.com/930164 Commit-Ready: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Rahul Chaudhry <rahulchaudhry@chromium.org> [modify] https://crrev.com/0398f6f9c39ac4fb9042396d7738a793d92acc9d/chromeos-base/tast-local-test-runner/tast-local-test-runner-9999.ebuild [modify] https://crrev.com/0398f6f9c39ac4fb9042396d7738a793d92acc9d/chromeos-base/tast-cmd/tast-cmd-9999.ebuild
,
Feb 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f3aceabb308e8e143f2b45b496e5c50b90dd80e8 commit f3aceabb308e8e143f2b45b496e5c50b90dd80e8 Author: Dan Erat <derat@chromium.org> Date: Tue Feb 27 06:07:12 2018 Revert "tast-{cmd,local-test-runner}: Remove tast-common blockers." This reverts commit 0398f6f9c39ac4fb9042396d7738a793d92acc9d. Reason for revert: Keeping blockers is preferred. Original change's description: > tast-{cmd,local-test-runner}: Remove tast-common blockers. > > Make the tast-cmd and tast-local-test-runner no longer block > the tast-common package. > > BUG= chromium:809518 > TEST=none > > Change-Id: I3691b572b0fa0ac5fc8ebbf5231ca739a94a2ab0 > Reviewed-on: https://chromium-review.googlesource.com/930164 > Commit-Ready: Dan Erat <derat@chromium.org> > Tested-by: Dan Erat <derat@chromium.org> > Reviewed-by: Rahul Chaudhry <rahulchaudhry@chromium.org> Bug: chromium:809518 Change-Id: I3d2562e32d7cb16838f312ae9f3cae4bf5cde936 Reviewed-on: https://chromium-review.googlesource.com/938781 Commit-Ready: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Rahul Chaudhry <rahulchaudhry@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/f3aceabb308e8e143f2b45b496e5c50b90dd80e8/chromeos-base/tast-local-test-runner/tast-local-test-runner-9999.ebuild [modify] https://crrev.com/f3aceabb308e8e143f2b45b496e5c50b90dd80e8/chromeos-base/tast-cmd/tast-cmd-9999.ebuild |
||
►
Sign in to add a comment |
||
Comment 1 by derat@chromium.org
, Feb 6 2018