New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 809492 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

10.3% regression in blink_perf.shadow_dom at 532680:532791

Project Member Reported by kraynov@chromium.org, Feb 6 2018

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=809492

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=7136542ae6e96c38c9c33a7d96575558857e2fd4382443bc31a3db09582c7dfd


Bot(s) for this bug's original alert(s):

chromium-rel-win7-x64-dual
📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/12a704b1840000
Re-running bisect on a wider range.
Cc: tsepez@chromium.org mattm@chromium.org jam@chromium.org juncai@chromium.org
Owner: juncai@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14eaf4c2440000

NetworkService: Implement URLLoader::OnCertificateRequested by juncai@chromium.org
https://chromium.googlesource.com/chromium/src/+/9409ded1ffb68a4fba35a4a37dc3e39a8f1e5718

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Status: Started (was: Assigned)
I took a look at the code in the CL:
https://chromium-review.googlesource.com/c/chromium/src/+/848303
and haven't found obvious change which causes this regression. The only place that may cause this is that we now use ContentBrowserClient::CreateClientCertStore() to create an instance of net::ClientCertStore instead of using ResourceLoaderDelegate::CreateClientCertStore(). Since this change is necessary for the Network Service, I am wondering if this can justify marking this bug as "WontFix".

Comment 9 by mattm@chromium.org, Mar 7 2018

Most likely it's just misattributed. 
1) Creating a ClientCertStore doesn't actually do any work.
2) I doubt perf tests are using client certs, so they wouldn't be hitting this code at all.
Status: WontFix (was: Started)

Sign in to add a comment