Issue metadata
Sign in to add a comment
|
10.3% regression in blink_perf.shadow_dom at 532680:532791 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Feb 6 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12a704b1840000
,
Feb 7 2018
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/12a704b1840000
,
Mar 4 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14eaf4c2440000
,
Mar 4 2018
Re-running bisect on a wider range.
,
Mar 5 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/14eaf4c2440000 NetworkService: Implement URLLoader::OnCertificateRequested by juncai@chromium.org https://chromium.googlesource.com/chromium/src/+/9409ded1ffb68a4fba35a4a37dc3e39a8f1e5718 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Mar 5 2018
,
Mar 7 2018
I took a look at the code in the CL: https://chromium-review.googlesource.com/c/chromium/src/+/848303 and haven't found obvious change which causes this regression. The only place that may cause this is that we now use ContentBrowserClient::CreateClientCertStore() to create an instance of net::ClientCertStore instead of using ResourceLoaderDelegate::CreateClientCertStore(). Since this change is necessary for the Network Service, I am wondering if this can justify marking this bug as "WontFix".
,
Mar 7 2018
Most likely it's just misattributed. 1) Creating a ClientCertStore doesn't actually do any work. 2) I doubt perf tests are using client certs, so they wouldn't be hitting this code at all.
,
Mar 16 2018
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Feb 6 2018