New issue
Advanced search Search tips

Issue 809444 link

Starred by 1 user
Status: Fixed
Owner:
jochen@chromium.org
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 796544



Sign in to add a comment

Convert CloudPrint to talk to Identity Service client library

Project Member Reported by blundell@chromium.org, Feb 6 2018 
GCDApiFlow takes in an O2TS, which GCDApiFlowImpl uses to make access token requests. I verified that it is ProfileOAuth2TokenService that is supplied: the only creation flow is via GCDApiFlow, which is only invoked here:
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc?type=cs&q=GCDApiFlow::Create&l=523

The above should be convertible to PrimaryAccountAccessTokenFetcher I think.

PrivetNotifications checks whether user is signed in on ChromeOS in order to determine whether to start. This should be straightforward to convert to IdentityManager.

Comment 1 by blundell@chromium.org, Feb 6 2018

Blocking: 796544
Components: Internals>Services>Identity
Status: Available (was: Untriaged)

Comment 2 by blundell@chromium.org, Jun 12 2018

Owner: jochen@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d42eaeb42f11341b69630b1d5ca206e88089376

commit 5d42eaeb42f11341b69630b1d5ca206e88089376
Author: Jochen Eisinger <jochen@chromium.org>
Date: Tue Jun 19 13:04:05 2018

Convert CloudPrint to talk to Identity Service client library

BUG= 809444 
R=blundell@chromium.org

Change-Id: Iea99e6e7809faa2f03702bab7a575c8a6c4e17b8
Reviewed-on: https://chromium-review.googlesource.com/1104421
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568421}
[modify] https://crrev.com/5d42eaeb42f11341b69630b1d5ca206e88089376/chrome/browser/printing/cloud_print/gcd_api_flow.cc
[modify] https://crrev.com/5d42eaeb42f11341b69630b1d5ca206e88089376/chrome/browser/printing/cloud_print/gcd_api_flow.h
[modify] https://crrev.com/5d42eaeb42f11341b69630b1d5ca206e88089376/chrome/browser/printing/cloud_print/gcd_api_flow_impl.cc
[modify] https://crrev.com/5d42eaeb42f11341b69630b1d5ca206e88089376/chrome/browser/printing/cloud_print/gcd_api_flow_impl.h
[modify] https://crrev.com/5d42eaeb42f11341b69630b1d5ca206e88089376/chrome/browser/printing/cloud_print/gcd_api_flow_unittest.cc
[modify] https://crrev.com/5d42eaeb42f11341b69630b1d5ca206e88089376/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc
[modify] https://crrev.com/5d42eaeb42f11341b69630b1d5ca206e88089376/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.h

Comment 4 by jochen@chromium.org, Jun 19 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment