New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 809432 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner: ----
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Font ligatures rendered incorrectly in omnibox.

Reported by lxy.lixi...@gmail.com, Feb 6 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36

Steps to reproduce the problem:
See attachment.

What is the expected behavior?

What went wrong?
See attachment.

Did this work before? N/A 

Chrome version: 64.0.3282.140  Channel: stable
OS Version: Fedora 27
Flash Version:
 
ligatures.png
4.6 KB View Download
Labels: Needs-Triage-M64
Cc: vamshi.k...@techmahindra.com
Components: -UI UI>Browser>Omnibox
Labels: Triaged-ET Needs-Feedback
Unable to reproduce the issue on reported chrome version 64.0.3282.140 and on the latest canary 66.0.3341.0 using Mac 10.13.1 with the below mentioned steps.
1. Launched chrome
2. Typed draftjs.org then hit return.
3. Cleared the omni bar and started retyping the text.
Attaching the screenshot for reference. 

@Reporter: Could you please check the screenshot and let us know if we have missed anything while reproducing the issue. Any further inputs from your end may help us to triage the issue in a better way.

Thanks!
809432.png
190 KB View Download
#2: Could you please test it on Linux? This bug may be only related to Linux platform.
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 8 2018

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "vamshi.kommuri@techmahindra.com" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Also, you may need a font which supports "ft" ligature, or use other urls which contains "fi" / "ff" ligatures.
3HyGrsf.png
2.7 KB View Download
Cc: js...@chromium.org derat@chromium.org
I feel like there's a bug on file about this somewhere; can't seem to find it though.  CC two people who know more than I do about this area.

Comment 7 by derat@chromium.org, Feb 9 2018

Cc: behdad@chromium.org drott@chromium.org
I haven't heard about this before and don't know anything about why ligatures would be rendered differently in the omnibox vs. elsewhere. Can you attach a screenshot of the same font being rendered elsewhere within Chrome, e.g. within a webpage?
Omnibox uses RenderTextHarfBuzz or RenderTextMac. Blink is completely separate. No?

Anyway rendering this correctly need specially handling attr changes in the middle of glyph and rendering it properly. Quite possible that was not implemented.

Comment 9 by derat@chromium.org, Feb 9 2018

Ah, perhaps so. Sorry, I haven't stayed caught up on the font rendering paths used in different places.
The first: select di"f"f
The last: select dif"f"
liga-0.png
1.6 KB View Download
liga-1.png
1.7 KB View Download
In omnibox:
liga-omni-0.png
2.8 KB View Download
liga-omni-1.png
2.5 KB View Download

Comment 12 by derat@chromium.org, Feb 11 2018

Cc: -derat@chromium.org
The reason Blink doesn't have this problem is that Blink does NOT allow selecting part of a ligature.

Comment 14 by drott@chromium.org, Feb 13 2018

Mid ligature selection is WIP for Blink here:
https://chromium-review.googlesource.com/c/chromium/src/+/752342

Owner: fs...@chromium.org
Status: Started (was: Unconfirmed)
Owner: ----
Status: Untriaged (was: Started)
Oops, the CL referenced in Comment 14 is for Blink and was just offered (I assume) as an example. Unassigning this from fserb (owner of the Blink CL).

Comment 17 by fs...@chromium.org, Feb 13 2018

Owner: fs...@chromium.org
Status: Started (was: Untriaged)
Yeah, that's the right CL. :)
I'm pretty sure the blink changes reflect on the omnibox, but I'll double check it.

Comment 18 by drott@chromium.org, Feb 14 2018

The Blink CL will fix ligature selection on all web pages, but it won't affect the omnibox. There is a bigger refactoring consideration of sharing more code between UI text rendering and Blink's text rendering.

Comment 19 by fs...@chromium.org, Feb 14 2018

Cc: fs...@chromium.org
Owner: ----
Status: Available (was: Started)
Ops. So I'll remove myself from this. :)
Cc: jdonnelly@chromium.org
Labels: -Pri-2 Pri-3
drott: can you suggest someone familiar with the RenderText code who could look into this?
Mergedinto: 702716
Status: Duplicate (was: Available)
Ligature rendering is fine, the issue is applying multiple colors to a single glyph if the selection point is mid-glyph.  Bug 702716 is about this and on comment 8 there mpearson points out the relevant code comment about adding this.

Comment 22 by drott@chromium.org, Feb 15 2018

For the record, I filed issue 812530 to track the discussion of unifying the text stacks.

Sign in to add a comment