Font ligatures rendered incorrectly in omnibox.
Reported by
lxy.lixi...@gmail.com,
Feb 6 2018
|
||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36 Steps to reproduce the problem: See attachment. What is the expected behavior? What went wrong? See attachment. Did this work before? N/A Chrome version: 64.0.3282.140 Channel: stable OS Version: Fedora 27 Flash Version:
,
Feb 7 2018
Unable to reproduce the issue on reported chrome version 64.0.3282.140 and on the latest canary 66.0.3341.0 using Mac 10.13.1 with the below mentioned steps. 1. Launched chrome 2. Typed draftjs.org then hit return. 3. Cleared the omni bar and started retyping the text. Attaching the screenshot for reference. @Reporter: Could you please check the screenshot and let us know if we have missed anything while reproducing the issue. Any further inputs from your end may help us to triage the issue in a better way. Thanks!
,
Feb 8 2018
#2: Could you please test it on Linux? This bug may be only related to Linux platform.
,
Feb 8 2018
Thank you for providing more feedback. Adding requester "vamshi.kommuri@techmahindra.com" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 8 2018
Also, you may need a font which supports "ft" ligature, or use other urls which contains "fi" / "ff" ligatures.
,
Feb 8 2018
I feel like there's a bug on file about this somewhere; can't seem to find it though. CC two people who know more than I do about this area.
,
Feb 9 2018
I haven't heard about this before and don't know anything about why ligatures would be rendered differently in the omnibox vs. elsewhere. Can you attach a screenshot of the same font being rendered elsewhere within Chrome, e.g. within a webpage?
,
Feb 9 2018
Omnibox uses RenderTextHarfBuzz or RenderTextMac. Blink is completely separate. No? Anyway rendering this correctly need specially handling attr changes in the middle of glyph and rendering it properly. Quite possible that was not implemented.
,
Feb 9 2018
Ah, perhaps so. Sorry, I haven't stayed caught up on the font rendering paths used in different places.
,
Feb 11 2018
The first: select di"f"f The last: select dif"f"
,
Feb 11 2018
In omnibox:
,
Feb 11 2018
,
Feb 12 2018
The reason Blink doesn't have this problem is that Blink does NOT allow selecting part of a ligature.
,
Feb 13 2018
Mid ligature selection is WIP for Blink here: https://chromium-review.googlesource.com/c/chromium/src/+/752342
,
Feb 13 2018
,
Feb 13 2018
Oops, the CL referenced in Comment 14 is for Blink and was just offered (I assume) as an example. Unassigning this from fserb (owner of the Blink CL).
,
Feb 13 2018
Yeah, that's the right CL. :) I'm pretty sure the blink changes reflect on the omnibox, but I'll double check it.
,
Feb 14 2018
The Blink CL will fix ligature selection on all web pages, but it won't affect the omnibox. There is a bigger refactoring consideration of sharing more code between UI text rendering and Blink's text rendering.
,
Feb 14 2018
Ops. So I'll remove myself from this. :)
,
Feb 14 2018
drott: can you suggest someone familiar with the RenderText code who could look into this?
,
Feb 14 2018
Ligature rendering is fine, the issue is applying multiple colors to a single glyph if the selection point is mid-glyph. Bug 702716 is about this and on comment 8 there mpearson points out the relevant code comment about adding this.
,
Feb 15 2018
For the record, I filed issue 812530 to track the discussion of unifying the text stacks. |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by krajshree@chromium.org
, Feb 6 2018