New issue
Advanced search Search tips

Issue 809404 link

Starred by 1 user
Status: Fixed
Owner:
futhark@chromium.org
Closed: Feb 2018
Cc:
yosin@chromium.org
hayato@chromium.org
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Contenteditable not correctly propagated to light tree children

Project Member Reported by futhark@chromium.org, Feb 6 2018 
The "Editable text" below should be editable even if the slot to which the child div is assigned is wrapped in elements inside the shadow tree:

<host contenteditable><div>Editable text</div></host>

See attached test.
host.html
984 bytes View Download

Comment 1 by futhark@chromium.org, Feb 6 2018 

The html spec says an element is contenteditable if its parent element is:

https://html.spec.whatwg.org/multipage/interaction.html#contenteditable

Assuming this is the light tree parent.

Comment 2 by futhark@chromium.org, Feb 6 2018 

Fwiw, the host.html test passes in WebKit.

Comment 3 by nainar@google.com, Feb 7 2018

Labels: Hotlist-Interop
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f225bcfe5ee31f9e2b0d35fb5cadc7f19bf32abe

commit f225bcfe5ee31f9e2b0d35fb5cadc7f19bf32abe
Author: Rune Lillesveen <futhark@chromium.org>
Date: Wed Feb 07 12:00:10 2018

Propagate contentEditable to light tree children.

contentEditable is implemented through -webkit-user-modify. We
propagated this property from shadow hosts to distributed children,
overriding inheritance through the flat tree for Shadow DOM v0. This CL
does the same for Shadow DOM v1.

https://html.spec.whatwg.org/multipage/interaction.html#attr-contenteditable

Bug:  809404 
Change-Id: I54f3421317fe806fa71a8e4837ef1cc125978c66
Reviewed-on: https://chromium-review.googlesource.com/903925
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534982}
[add] https://crrev.com/f225bcfe5ee31f9e2b0d35fb5cadc7f19bf32abe/third_party/WebKit/LayoutTests/external/wpt/html/editing/editing-0/contenteditable/contentEditable-slotted-inherit.html
[modify] https://crrev.com/f225bcfe5ee31f9e2b0d35fb5cadc7f19bf32abe/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

Comment 5 by futhark@chromium.org, Feb 7 2018

Status: Fixed (was: Started)
►

Sign in to add a comment