New issue
Advanced search Search tips

Issue 809402 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 809102
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

-webkit-box-reflect regression: Reflection disappears after animation completes

Reported by mathias....@gmail.com, Feb 6 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36

Steps to reproduce the problem:
1. Please see our website https://www.footway.se/skor/dam
2. Close the size chooser modal
3. Observe the animation on the big image at the top of the page
4. In earlier versions of Chrome the webkit-box-reflect was working, and at the end of the animation it stayed visible. Now it is replace by the hidden part of the image.

What is the expected behavior?
The reflection should still be visible at the end of the animation.

What went wrong?
The reflection is replace by the hidden part of the image at the end of the animation.

Did this work before? Yes 64.0.3282.134 I think, but at least verified on 63.0.3239.132

Does this work in other browsers? Yes

Chrome version: 64.0.3282.140  Channel: stable
OS Version: 10.0
Flash Version: 

I'm sorry I didn't have time to create an isolated test case. But I think the problem is obvious at our live site. :-)
 
Labels: Needs-Triage-M64 Needs-Bisect
Components: Blink>Animation Blink>Paint
Cc: chrishtr@chromium.org
Labels: -Needs-Bisect -Needs-Triage-M64 RegressedIn-64 Target-65 FoundIn-66 FoundIn-64 FoundIn-65 OS-Android OS-Chrome OS-Linux OS-Mac
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: -webkit-box-reflect regression: Reflection disappears after animation completes (was: -webkit-box-reflect regression)
Bisects to this range

https://chromium.googlesource.com/chromium/src/+log/54eed3302edef045f45053c98f1be4c52def3822..e0cc690b716678354395f7f66f32f9032811d2f9

Strongly suggests

Detect tightness of clip rects in GeometryMapper
https://chromium.googlesource.com/chromium/src/+/1a4f7077baed35c6c653a5d17e3311c46cb05105

Given the difficulty of reducing to a small case, could you leave your site unchanged for a few days? Or put a copy someplace where we can continue to see the problem?
Yes, we will leave this online for a while with the hope of a quick fix. :-)
Reduced test case
reflect.html
342 bytes View Download
The cause of reflection replaced by hidden part is of the same reason as  bug 809102 , but the workaround for  bug 809102  doesn't directly work for this bug. Will try to find a workaround.

There are more complications in M65 and M66:

- The test starts to crash since https://chromium.googlesource.com/chromium/src/+log/f758f57f0648b5aa316e7cdd23f95916e1c55995..fb01b483c647cdb8d72d0a04ed4b609676edaf16 (r529806:r529822)

- The test shows no reflection during animation after the crash is fixed (https://chromium.googlesource.com/chromium/src/+log/cc7ddcb128b5ed469bf44edf34790804066871ce..fb25d8a626538f7dd54f3efb381db9fe20927650)

The crash should be bug 803777 and has been fixed in M65 and M66. Will find which revision caused no reflection during animation. I suspect some change about composited reflection mask.


Mergedinto: 809102
Status: Duplicate (was: Assigned)
I filed  bug 810214  for the issue of missing reflection during animation on M65 and M66, then this bug can be merged into  bug 809102 .
Chrome 66 seems to partially fix this bug, but the reflection is still not drawn correct. 

Please see our site:
https://www.footway.co.uk/shoes

The big top image has a reflected area, and a reflected textbox to the left. The text overflows into the reflection sometimes, and at th end of the animation the reflection is cut off in the right edge a few pixels. :-)
Re #c9: I'm not sure if I did the correct thing to reproduce. Can you attach a screenshot?
Sure, here it comes. You can also see the url.
reflection-bug.png
1.6 MB View Download
athias.kallberg@footway.com, thanks for the screenshot. Now I can reproduce the issue on 66.0.3359.181, and the latest Canary with --disable-blink-features=SlimmingPaintV175. This confirms that the bug has been fixed by SlimmingPaintV175 which is shipped in M67. It will be in the stable channel soon.
Awesome, thanks!

Sign in to add a comment