New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 809381 link

Starred by 5 users
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Feb 2018
Cc:
█ manoranj...@chromium.org
nyerramilli@chromium.org
pbomm...@chromium.org
rbasuvula@chromium.org
█ sc00335...@techmahindra.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : ‘Clear All’ option is missing in ‘More actions’ menu list.

Reported by avsha...@etouch.net, Feb 6 2018 
Chrome Version : 66.0.3341.0 (Official Build) 9b4cb224d2ee360861c27dfaefe17b9ae02a25c1-refs/heads/master@{#534605} 32/64-bit
OS : Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.4), Linux(14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome and save two pages such that download entries appear in chrome://downloads page.
2. On chrome://downloads page, click on ‘More actions..’ icon and observe the menu list. 

Actual Result : ‘Clear All’ option is missing in ‘More actions’ menu list.

Expected Result : ‘Clear All’ option should be there in ‘More actions’ menu list when multiple download entries are present on chrome://downloads page.

This is a regression issue broken in ‘M-66’ and Will soon update remaining info.
Actual_Result.mov
2.9 MB View Download

Comment 1 by avsha...@etouch.net, Feb 6 2018

Labels: hasbisect-per-revision ET-MUM-Reported
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
This is a regression issue broken in ‘M-66’ and providing the bisect using ‘per-revision’ script:
Good build : 66.0.3336.0 (Revision: 533410)
Bad build : 66.0.3338.0 (Revision: 534242)

You are probably looking for a change made after 533916 (known good), but no later than 533917 (first known bad).

Change Log URL:
https://chromium.googlesource.com/chromium/src/+log/c5d6215aa737d444849bdc614f0fcd96c8ce6edc..c69754281d9862212a7957ee367812dcb52bfb18

Suspect : https://chromium.googlesource.com/chromium/src/+/c69754281d9862212a7957ee367812dcb52bfb18

@dpapad : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Note : Issue is not observed in today's Dev #65.0.3325.51 build.
Expected_Result.mov
3.1 MB View Download

Comment 2 by avsha...@etouch.net, Feb 6 2018

Labels: RegressedIn-66 FoundIn-66 Target-66

Comment 3 by rbasuvula@chromium.org, Feb 6 2018

Cc: pbomm...@chromium.org manoranj...@chromium.org
Labels: ReleaseBlock-Beta
Adding release blocker label for this issue.Please reduce priority or remove if not the case.

Thank You!

Comment 4 by dpa...@chromium.org, Feb 6 2018

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c69778aabd2cdc75008d2dcefa5e35b8ba7783e

commit 4c69778aabd2cdc75008d2dcefa5e35b8ba7783e
Author: dpapad <dpapad@chromium.org>
Date: Tue Feb 06 23:08:36 2018

Downloads UI: Fix "clear all" cr-action-menu entry.

It was missed in r533917.

Bug:  809381 , 808182 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4b7d574e2a1f6b3522547def1b2c6615e974143a
Reviewed-on: https://chromium-review.googlesource.com/904851
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534824}
[modify] https://crrev.com/4c69778aabd2cdc75008d2dcefa5e35b8ba7783e/chrome/browser/resources/md_downloads/toolbar.html

Comment 6 by dpa...@chromium.org, Feb 6 2018

Status: Fixed (was: Started)

Comment 7 by sc00335...@techmahindra.com, Feb 7 2018

Cc: sc00335...@techmahindra.com
 Issue 809768  has been merged into this issue.

Comment 8 by avsha...@etouch.net, Feb 7 2018

Labels: TE-Verified-66.0.3342.0 TE-Verified-M66
Update : 
Retested above issue on Windows(7,8,8.1,10), Linux(14.04 LTS) &  Mac(10.12.6, 10.13.1, 10.13.4) OS using latest Canary build #66.0.3342.0 and the issue is fixed. Kindly review an attached screen cast.

Thank you!
Canary_behaviour.mov
3.9 MB View Download

Comment 9 by ajha@chromium.org, Feb 9 2018 

 Issue 810435  has been merged into this issue.
►

Sign in to add a comment