New issue
Advanced search Search tips

Issue 809368 link

Starred by 1 user
Status: Assigned
Owner:
peria@chromium.org
Cc:
hs1217....@samsung.com
bashi@chromium.org
lfg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug

Blocking:
issue 807008


Participants' hotlists:
Hotlist-Bindings-IDLCompiler


Sign in to add a comment

IDL compiler: Build fail when using [PutForwards] with [SameObject]

Project Member Reported by hs1217....@samsung.com, Feb 6 2018 
build fail when using PutForwards keyword in idl.

[Exposed=Window,
 NoInterfaceObject]
interface ElementCSSInlineStyle {
  [SameObject, PutForwards=cssText] readonly attribute CSSStyleDeclaration style;
};

https://chromium-review.googlesource.com/c/chromium/src/+/894970/8/third_party/WebKit/Source/core/css/cssom/ElementCSSInlineStyle.idl#10

https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/640530

[6232/28915] ACTION //third_party/WebKit/Source/bindings/core/v8:generate_bindings_core_v8_interfaces(//build/toolchain/win:win_clang_x86)
FAILED: gen/blink/bindings/core/v8/V8HTMLElement.cpp gen/blink/bindings/core/v8/V8HTMLElement.h 
C:/b/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe ../../third_party/WebKit/Source/bindings/scripts/idl_compiler.py --cache-dir gen/blink/bindings/scripts --output-dir gen/blink/bindings/core/v8 --info-dir gen/blink/bindings --target-component core ../../third_party/WebKit/Source/core/html/HTMLElement.idl
Traceback (most recent call last):
  File "../../third_party/WebKit/Source/bindings/scripts/idl_compiler.py", line 210, in <module>
    sys.exit(main())
  File "../../third_party/WebKit/Source/bindings/scripts/idl_compiler.py", line 206, in main
    input_filenames)
  File "../../third_party/WebKit/Source/bindings/scripts/idl_compiler.py", line 139, in generate_bindings
    idl_compiler.compile_file(idl_filename)
  File "../../third_party/WebKit/Source/bindings/scripts/idl_compiler.py", line 125, in compile_file
    self.compile_and_write(idl_filename)
  File "../../third_party/WebKit/Source/bindings/scripts/idl_compiler.py", line 115, in compile_and_write
    target_definitions, interface_name)
  File "C:\b\c\b\win\src\third_party\WebKit\Source\bindings\scripts\code_generator_v8.py", line 149, in generate_code
    return self.generate_code_internal(definitions, definition_name)
  File "C:\b\c\b\win\src\third_party\WebKit\Source\bindings\scripts\code_generator_v8.py", line 174, in generate_code_internal
    definitions.interfaces[definition_name])
  File "C:\b\c\b\win\src\third_party\WebKit\Source\bindings\scripts\code_generator_v8.py", line 212, in generate_interface_code
    template_context = interface_context(interface, definitions.interfaces)
  File "C:\b\c\b\win\src\third_party\WebKit\Source\bindings\scripts\v8_interface.py", line 392, in interface_context
    attributes = attributes_context(interface, interfaces)
  File "C:\b\c\b\win\src\third_party\WebKit\Source\bindings\scripts\v8_interface.py", line 525, in attributes_context
    for attribute in interface.attributes]
  File "C:\b\c\b\win\src\third_party\WebKit\Source\bindings\scripts\v8_attributes.py", line 196, in attribute_context
    setter_context(interface, attribute, interfaces, context)
  File "C:\b\c\b\win\src\third_party\WebKit\Source\bindings\scripts\v8_attributes.py", line 424, in setter_context
    interface = interfaces[target_interface_name]
KeyError: 'CSSStyleDeclaration'

but there is not build error without PutForwards keyword.
PutForwards keyword must be needed.

thanks.

Comment 1 by hs1217....@samsung.com, Feb 6 2018

Blocking: 807008

Comment 2 by hs1217....@samsung.com, Feb 6 2018

Cc: hs1217....@samsung.com

Comment 3 by hs1217....@samsung.com, Feb 6 2018

Labels: -OS-iOS

Comment 4 by jbroman@chromium.org, Feb 12 2018

Cc: bashi@chromium.org
Owner: peria@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 5 by hs1217....@samsung.com, Feb 27 2018

Description: Show this description

Comment 6 by peria@chromium.org, May 3 2018

Blockedon: 839389

Comment 7 by peria@chromium.org, May 25 2018

Blockedon: -839389
Labels: Hotlist-Bindings-IDLCompiler

Comment 8 by peria@chromium.org, Jul 13

Summary: IDL compiler: Build fail when using [PutForwards] with [SameObject] (was: build fail when using PutForwards keyword in idl)
►

Sign in to add a comment