New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 809314 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Resizing Files window doesn't render quick view of a pdf file correctly

Project Member Reported by mkarkada@chromium.org, Feb 6 2018

Issue description

What steps will reproduce the problem?
1. Open Files app and select a pdf file from Downloads folder
2. Press Space key to preview the file
3. Resize the Files app window to different sizes

Expected behavior:
Quick view should be rendered correctly according to the different sizes of Files window

Actual behavior:
Quick view is not rendered correctly

Please refer video attachments for the expected and actual behaviors.
 
Build info:
CrOS 10323.15.0, 65.0.3325.39

Videos related to this issue in the link below:
https://pantheon.corp.google.com/storage/browser/chromiumos-test-logs/bugfiles/cr/809314/
Components: -Platform>Apps>FileManager Internals>Plugins>PDF
This is also happening to PDFs via the Chrome browser, so redirecting to the PDF team to take a look.
Cc: thestig@chromium.org
Components: -Internals>Plugins>PDF Platform>Apps>FileManager
When the File Manager opened the PDF in quick view, it sets the zoom to a specific level. When this happens, the zoom stays at the specific level. The File Manager needs to open the PDF Viewer in Fit-to-width or Fit-to-page mode. Then the PDF Viewer will get the desired behavior.
Owner: fukino@chromium.org
Status: Assigned (was: Untriaged)
thanks thestig@! fukino@ could you please take a look?
Labels: -M-65 M-66
Moving back to M66 to investigate.

Comment 6 by sashab@chromium.org, Feb 22 2018

Labels: CrOS-FilesApp-QuickView

Comment 7 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp-QuickView CrOSFilesFeature-QuickView
Labels: -M-66 M-67

Comment 9 by fukino@chromium.org, Mar 28 2018

WIP CL: http://crrev.com/c/984912
Cc: hnakashima@chromium.org
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0fb2a3bc358481049677a2aec556ef8d5d81120

commit e0fb2a3bc358481049677a2aec556ef8d5d81120
Author: Naoki Fukino <fukino@chromium.org>
Date: Wed Apr 04 09:45:09 2018

Files app: Preview PDF file in fit-to-page mode in quick view.

Instead of using the default zoom level, we can set fit-to-zoom mode by default
to resize the preview automatically when Files app window is resized.

Bug:  809314 
Test: Manually tested
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6e8d2113c9bbbd65071de2191f4be37b62ef6fd0
Reviewed-on: https://chromium-review.googlesource.com/984912
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548013}
[modify] https://crrev.com/e0fb2a3bc358481049677a2aec556ef8d5d81120/ui/file_manager/file_manager/foreground/js/quick_view_controller.js

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified on Chrome OS 10575.26.0, 67.0.3396.31

Sign in to add a comment