Splitview divider covers overview windows. |
||||||
Issue description(1) Enter tablet mode. (2) Open two snappable windows. (3) Snap one window left. (4) Drag the remaining window onto the left side. What is the expected result? n/a What happens instead? Dragging window covers the snapped window, but is covered by the divider. On release, the dragged window is under both.
,
Feb 10 2018
Oh good catch, Sammie. Sorry for the slow response. I was going to say the dragged window should be above everything, but I think to reduce confusion about what you can do with it (i.e., you shouldn't be able to drag it and replace the first snapped window) we should layer it below both the divider and the snapped window.
,
Feb 16 2018
,
Mar 3 2018
Daisy or Sammie, as a stopgap for m66 can we please layer dragged overview windows below both the splitscreen divider and any snapped windows.
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41066cf8c7e89bcac79af3b27b79910d3025225e commit 41066cf8c7e89bcac79af3b27b79910d3025225e Author: Xiaoqian Dai <xdai@chromium.org> Date: Fri Mar 09 21:07:14 2018 Cros splitscreen: Stack the dragged window below the snapped window during dragging. Bug: 809298 Change-Id: I7d8b5e5e9a792b689129937c912bc16e6ef2e053 Reviewed-on: https://chromium-review.googlesource.com/950139 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#542220} [modify] https://crrev.com/41066cf8c7e89bcac79af3b27b79910d3025225e/ash/wm/overview/window_selector_item.cc
,
Mar 9 2018
Fixed for M66.
,
Mar 10 2018
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a318a3e776102a6ff8b75bc7e1a3ffb65a584bee commit a318a3e776102a6ff8b75bc7e1a3ffb65a584bee Author: Xiaoqian Dai <xdai@chromium.org> Date: Tue Mar 13 18:52:14 2018 [Merge to M66] Cros splitscreen: Stack the dragged window below the snapped window during dragging. TBR=oshima@chromium.org (cherry picked from commit 41066cf8c7e89bcac79af3b27b79910d3025225e) Bug: 809298 Change-Id: I7d8b5e5e9a792b689129937c912bc16e6ef2e053 Reviewed-on: https://chromium-review.googlesource.com/950139 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#542220} Reviewed-on: https://chromium-review.googlesource.com/961243 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#213} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/a318a3e776102a6ff8b75bc7e1a3ffb65a584bee/ash/wm/overview/window_selector_item.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sammiequon@chromium.org
, Feb 6 2018Status: Assigned (was: Untriaged)