New issue
Advanced search Search tips

Issue 809297 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

git shows third_party/gles1_conform/ as untracked

Project Member Reported by skobes@chromium.org, Feb 6 2018

Issue description

Recently every "gclient sync" creates a directory third_party/gles1_conform/ which shows up as untracked:

$ git status
HEAD detached at origin/master
Untracked files:
  (use "git add <file>..." to include in what will be committed)

	third_party/gles1_conform/

nothing added to commit but untracked files present (use "git add" to track)

I'm guessing it's related to this commit, although I don't understand DEPS well enough to say what's wrong with it:

  https://chrome-internal.googlesource.com/chrome/src-internal/+/2aef9c11251fd3a893b649b930549bb8461d9b1d
 
Cc: -geoffl...@chromium.org
Owner: geoffl...@chromium.org
Status: Started (was: Untriaged)
Looks like I forgot to add it to .gitignore

Thanks for noticing.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66b8b7d0d5bffc0155bcce6ed169934f33db988d

commit 66b8b7d0d5bffc0155bcce6ed169934f33db988d
Author: Geoff Lang <geofflang@chromium.org>
Date: Tue Feb 06 16:08:39 2018

Add third_party/gles1_conform to .gitignore.

TBR=jmadill@chromium.org

BUG= 809297 
BUG= angleproject:2303 

Change-Id: I5bd998c3b7eec3dfbba2a8012eba61da0e2b4041
Reviewed-on: https://chromium-review.googlesource.com/904686
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534692}
[modify] https://crrev.com/66b8b7d0d5bffc0155bcce6ed169934f33db988d/third_party/.gitignore

Status: Fixed (was: Started)

Sign in to add a comment