New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 809293 link

Starred by 33 users
Status: Fixed
Owner:
aee@chromium.org
Closed: Mar 2018
Cc:
aee@chromium.org
pnangunoori@chromium.org
rdevlin....@chromium.org
█ hdodda@chromium.org
█ pawli...@chromium.org
nyerramilli@chromium.org
dbeam@chromium.org
tbuck...@chromium.org
█ tkonch...@chromium.org
bettes@chromium.org
dpa...@chromium.org
jawag@chromium.org
█ dschuyler@chromium.org
namratakannan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature

Blocking:
issue 741339
issue 822019



Sign in to add a comment

WebUI Switcher in Settings

Project Member Reported by bettes@chromium.org, Feb 6 2018 
Create a new list in the side drawer of settings to allow access to other Chrome pages


Behavior:
- Opening and collapsing 'Other pages' should be sticky, just as Advanced is today
- 'Other pages' should only be seen in Settings (not all webUI pages)

Ordering
- We should use UMA to inform the ordering of these pages. If I'm interpreting correctly, from top to bottom: History, About, Downloads, Extensions, Bookmarks

Iron icons
- History: history
- About: chrome_product.svg (attached)
- Downloads: file-download
- Extensions: extension
- Bookmarks:  star
chrome_product.svg
880 bytes Download
alternative_switcher (1).png
55.0 KB View Download

Comment 1 by namratakannan@chromium.org, Mar 13 2018 

Updating this bug with the discussion on the chrome-ui review thread:https://groups.google.com/a/google.com/forum/#!topic/chrome-ui-review/Mi31U3puhVg

Proposal:
Add only a link to the Extensions settings module within the Settings side-nav, without introducing the bottom page switcher in Settings and other Web UI pages.

Behavior:
Clicking on the extensions link opens extensions in a new tab.

Iron icon: open-in-new, 20X20
side-nav.png
327 KB View Download
side-nav_spec.png
333 KB View Download

Comment 2 by aee@chromium.org, Mar 14 2018

Owner: aee@chromium.org

Comment 3 by dpa...@chromium.org, Mar 14 2018

Labels: -Pri-3 Pri-2

Comment 4 by dpa...@chromium.org, Mar 14 2018

Blocking: 741339

Comment 5 by dpa...@chromium.org, Mar 14 2018

Cc: pnangunoori@chromium.org tbuck...@chromium.org
 Issue 747489  has been merged into this issue.

Comment 6 by dpa...@chromium.org, Mar 14 2018

Cc: rdevlin....@chromium.org pawli...@chromium.org aee@chromium.org bettes@chromium.org namratakannan@chromium.org nyerramilli@chromium.org dbeam@chromium.org tkonch...@chromium.org hdodda@chromium.org
 Issue 621132  has been merged into this issue.

Comment 7 by jawag@chromium.org, Mar 14 2018

Blocking: 822019

Comment 8 by aee@chromium.org, Mar 26 2018

Status: Started (was: Available)
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/496814ca5225455f342e5b8d799d8fd2d759af35

commit 496814ca5225455f342e5b8d799d8fd2d759af35
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Tue Mar 27 05:54:30 2018

Settings WebUI: adding extensions external link in settings sidebar menu

Bug:  809293 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I301fa871eb33ccbae30c219f4ff3b12c7916f6dd
Reviewed-on: https://chromium-review.googlesource.com/976942
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546033}
[modify] https://crrev.com/496814ca5225455f342e5b8d799d8fd2d759af35/chrome/browser/resources/settings/settings_menu/settings_menu.html
[modify] https://crrev.com/496814ca5225455f342e5b8d799d8fd2d759af35/chrome/browser/resources/settings/settings_menu/settings_menu.js
[modify] https://crrev.com/496814ca5225455f342e5b8d799d8fd2d759af35/chrome/browser/resources/settings/settings_ui/settings_ui.js
[modify] https://crrev.com/496814ca5225455f342e5b8d799d8fd2d759af35/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/496814ca5225455f342e5b8d799d8fd2d759af35/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/496814ca5225455f342e5b8d799d8fd2d759af35/chrome/test/data/webui/settings/settings_menu_test.js

Comment 10 by aee@chromium.org, Mar 27 2018

Status: Fixed (was: Started)

Comment 11 by dpa...@chromium.org, Mar 28 2018

Blocking: -741339

Comment 12 by dpa...@chromium.org, Mar 28 2018

Blocking: 741339
Cc: dschuyler@chromium.org
 Issue 741339  has been merged into this issue.
►

Sign in to add a comment