New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 809271 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

EOL notification: Clicking on Learn more link while in Guest mode causes browser crash

Project Member Reported by sdantul...@chromium.org, Feb 6 2018

Issue description

Google Chrome	65.0.3325.35 (Official Build) dev (64-bit)
Revision	0
Platform	10323.9.0 (Official Build) dev-channel lumpy

What steps will reproduce the problem?
1. AU device to 10323.9.0, 65.0.3325.35
2. Click on "Browse as Guest"
3. See "End of support" notification
4. Click on "Learn more" 

What is the expected result?
Learn more link should open in browser tab

What happens instead?
Browser crash.
 
Description: Show this description
Summary: EOL notification: Clicking on Learn more link while in Guest mode causes browser crash (was: EOL notification: Clicking on Learn more link while in Guest mode results in black screen)
Cc: xiaoyinh@chromium.org
Labels: ReleaseBlock-Stable
Owner: xiaoyinh@chromium.org
Status: Assigned (was: Untriaged)
Stack trace indicates that we should use OffTheRecordProfile for guest session:

[137410:137410:0216/165431.663373:FATAL:browser.cc(399)] Check failed: !profile_->IsGuestSession() || profile_->IsOffTheRecord(). Only off the record browser may be opened in guest mode
#0 0x55ef4d5e64cc base::debug::StackTrace::StackTrace()
#1 0x55ef4d5fa7b3 logging::LogMessage::~LogMessage()
#2 0x55ef4f5c92ba Browser::Browser()
#3 0x55ef4f5d83e7 Navigate()
#4 0x55ef4c7f3a84 chromeos::(anonymous namespace)::EolNotificationDelegate::ButtonClick()
#5 0x55ef4f370cda message_center::MessageCenterImpl::ClickOnNotificationButton()
#6 0x55ef50a7aac1 message_center::NotificationViewMD::ButtonPressed()
#7 0x55ef4eb6107d views::Button::OnMouseReleased()
#8 0x55ef4eb58a89 views::InkDropHostView::OnMouseEvent()
#9 0x55ef506ec532 ui::ScopedTargetHandler::OnEvent()
#10 0x55ef4ddb5ef4 ui::EventDispatcher::ProcessEvent()
#11 0x55ef4ddb5d3f ui::EventDispatcherDelegate::DispatchEvent()
#12 0x55ef4ebb80bd views::internal::RootView::OnMouseReleased()
#13 0x55ef4eb96707 views::Widget::OnMouseEvent()
#14 0x55ef4ddb5ef4 ui::EventDispatcher::ProcessEvent()
#15 0x55ef4ddb5d3f ui::EventDispatcherDelegate::DispatchEvent()
#16 0x55ef506ec32e ui::EventProcessor::OnEventFromSource()
#17 0x55ef4ddb6858 ui::EventSource::SendEventToSink()
#18 0x55ef4f39889e ash::AshWindowTreeHostPlatform::DispatchEvent()
#19 0x55ef4ddb7184 ui::DispatchEventFromNativeUiEvent()
#20 0x55ef4e1ed391 ui::X11WindowOzone::DispatchEvent()
#21 0x55ef4dab5dc3 ui::PlatformEventSource::DispatchEvent()
#22 0x55ef4e1e1fb9 ui::X11EventSourceLibevent::DispatchPlatformEvent()
#23 0x55ef4e1e1e44 ui::X11EventSourceLibevent::ProcessXEvent()
#24 0x55ef4e1e2543 ui::X11EventSource::ExtractCookieDataDispatchEvent()
#25 0x55ef4e1e24ed ui::X11EventSource::DispatchXEvents()
#26 0x55ef4d6000b9 base::MessagePumpLibevent::OnLibeventNotification()
#27 0x55ef4d684afd event_base_loop
#28 0x55ef4d6003b2 base::MessagePumpLibevent::Run()
#29 0x55ef4d61ed05 base::RunLoop::Run()
#30 0x55ef4d32cb5b ChromeBrowserMainParts::MainMessageLoopRun()
#31 0x55ef4bf8b687 content::BrowserMainLoop::RunMainMessageLoopParts()
#32 0x55ef4bf8e012 content::BrowserMainRunnerImpl::Run()
#33 0x55ef4bf87a3b content::BrowserMain()
#34 0x55ef4d31add6 content::ContentMainRunnerImpl::Run()
#35 0x55ef4d322de2 service_manager::Main()
#36 0x55ef4d319a24 content::ContentMain()
#37 0x55ef4b5fb57f ChromeMain
#38 0x7f6dc1737f45 __libc_start_main
#39 0x55ef4b5fb24a _start

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3327cfed3f0a3d7dca70057cafa0d271e20daeff

commit 3327cfed3f0a3d7dca70057cafa0d271e20daeff
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Thu Feb 22 17:46:08 2018

Fix crash when open new tab from eol notification in guest session

Bug:  809271 
Change-Id: I769b03038509625eeade3fb4787d0d73ff105f03
Reviewed-on: https://chromium-review.googlesource.com/924755
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538477}
[modify] https://crrev.com/3327cfed3f0a3d7dca70057cafa0d271e20daeff/chrome/browser/profiles/profile_manager.cc

Labels: Merge-Request-65
Project Member

Comment 9 by sheriffbot@chromium.org, Feb 22 2018

Labels: -Merge-Request-65 Merge-Review-65 Hotlist-Merge-Review
This bug requires manual review: We are only 11 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-65 Merge-Approved-65
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 24 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c79d8ff2933a82c923fb78804764ad62fc91a03

commit 3c79d8ff2933a82c923fb78804764ad62fc91a03
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Sat Feb 24 01:47:53 2018

[Merge to M65]Fix crash when open new tab from eol notification in guest session

TBR=skuhne@chromium.org,xiyuan@chromium.org
(cherry picked from commit 3327cfed3f0a3d7dca70057cafa0d271e20daeff)

Bug:  809271 
Change-Id: I769b03038509625eeade3fb4787d0d73ff105f03
Reviewed-on: https://chromium-review.googlesource.com/924755
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#538477}
Reviewed-on: https://chromium-review.googlesource.com/936042
Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#581}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/3c79d8ff2933a82c923fb78804764ad62fc91a03/chrome/browser/profiles/profile_manager.cc

Status: Fixed (was: Assigned)

Sign in to add a comment